Confirmed users
1,927
edits
Phabricator/TestPlan: Difference between revisions
Merge the review test plans
(Consistency of arc diff commands) |
(Merge the review test plans) |
||
| Line 140: | Line 140: | ||
* There are 2 corresponding <code>x-phabricator-request</code> attachments on the bug in Bugzilla. | * There are 2 corresponding <code>x-phabricator-request</code> attachments on the bug in Bugzilla. | ||
=== Requesting a | === Requesting and leaving a review on a revision is successful === | ||
====Test Plan==== | ====Test Plan==== | ||
| Line 147: | Line 147: | ||
* Input the title, summary, test plan, and bug id of a public bug. | * Input the title, summary, test plan, and bug id of a public bug. | ||
* For the "Reviewers" field enter the Phabricator user name of the other account. | * For the "Reviewers" field enter the Phabricator user name of the other account. | ||
* Log into Phabricator as the reviewer account. | |||
* Add the "Accept Revision" action at the bottom. | |||
====Results==== | ====Results==== | ||
| Line 152: | Line 154: | ||
* The Phabricator attachment on Bugzilla is present. | * The Phabricator attachment on Bugzilla is present. | ||
* The "Reviewers" field in the "Details" panel on the Phabricator revision lists the reviewer. | * The "Reviewers" field in the "Details" panel on the Phabricator revision lists the reviewer. | ||
* The attachment on the bug in Bugzilla should have an r+ flag from the Reviewer. | * The attachment on the bug in Bugzilla should have an r+ flag from the Reviewer. | ||
* The bug should have a comment of the form "Reviewer [:reviewer] has approved the revision." with a link to the timeline item showing that the revision was accepted. | |||
Please contact a developer within the #conduit IRC channel with further questions. | Please contact a developer within the #conduit IRC channel with further questions. | ||