715
edits
WebDriver/RemoteProtocol/Meetings/2019/03/18: Difference between revisions
WebDriver/RemoteProtocol/Meetings/2019/03/18 (view source)
Revision as of 10:18, 18 March 2019
, 18 March 2019→Status update: correct some mistakes
(→Minutes: fill out) |
(→Status update: correct some mistakes) |
||
| Line 17: | Line 17: | ||
=== Status update === | === Status update === | ||
* Landed couple fixes, | * Landed a couple of fixes for incorrect constants, lints, &c. | ||
* Only major change was that we hooked the remote agent up to the build system | * Only major change was that we hooked the remote agent up to the build system | ||
* Google meeting | * Google meeting | ||
| Line 23: | Line 23: | ||
** Next meeting on Monday 15 April | ** Next meeting on Monday 15 April | ||
* Progress in next two weeks is going to be limited, as both yulia and ato are away | * Progress in next two weeks is going to be limited, as both yulia and ato are away | ||
* '' | * '''Q:''' What’s the blocker to get rid of the build flag? Security review? | ||
** Security review is indeed a blocker, but we can prepare the patch | ** Security review is indeed a blocker, but we can prepare the patch | ||
** We need the remote agent to be part of the default builds to enable testing, although you might get around this with custom artifact builds | ** We need the remote agent to be part of the default builds to enable testing, although you might get around this with custom artifact builds | ||
** Long time since Alex did it, but should be possible | ** Long time since Alex did it, but should be possible | ||
** On the other hand, last time we did security review for Marionette it was very quick, so let’s see how soon we can get it done | |||
** A hunch we’re initialising some things too early, Andreas might need to submit a patch | ** A hunch we’re initialising some things too early, Andreas might need to submit a patch | ||
*** Alex advises submitting review and then seeing what they say | *** Alex advises submitting review and then seeing what they say | ||
* Alex didn’t expect | *** Let’s point out the problem with <code>RemoteAgent#constructor</code> in the security review | ||
* Alex didn’t expect his patches from two weeks ago to land as they were, but can iterate on what is there now | |||
** ato didn’t expect every patch to be perfect, but we should probably expect more tests in the future | ** ato didn’t expect every patch to be perfect, but we should probably expect more tests in the future | ||
** On the other hand it’s hard to reject changes if tests don’t run on try | ** On the other hand it’s hard to reject changes if tests don’t run on try | ||