WebDriver/RemoteProtocol/Meetings/2019/11/01: Difference between revisions

WebDriver/RemoteProtocol/Meetings/2019/11/01 (view source)

Revision as of 16:16, 1 November 2019

53 bytes added , 1 November 2019

→‎Update on Firefox support for Puppeteer?: some fixes

Ato

715

edits

@@ Line 84: / Line 84: @@
 === Update on Firefox support for Puppeteer? ===
-; maja
+; maja_zf
-: See https://github.com/andreastt/puppeteer/pull/1
+: https://github.com/andreastt/puppeteer/pull/1
-: I'm working on the code in Launcher.js, about 5% chrome specific, and doing some refactoring to be able to also use it for Firefox
+: I'm working on the code in Launcher.js, about 5% chrome specific, and doing some refactoring to be able to also use it for Firefox.
-: a use would set a PUPPETEER_PRODUCT environment variable to run it also with Firefox
+: A user would set the <code>PUPPETEER_PRODUCT</code> environment variable to select Firefox.
-: some more code for setting up the profile including preferences
+: Some more code for setting up the profile including preferences then gets run.
 ; ato
-: the way how Chrome is configured is different
+: The way how Chrome is configured is different?
-: with firefox we write a lot of preferences to the profile
+: With Firefox we write a lot of preferences to the profile.
-; maja
+; maja_zf
-: chrome use command line flags
+: Chrome just uses command-line flags.
-: maybe in the future we can have a mozprofile node.js library to allow users to configure the used profile
+: Maybe in the future we can have a mozprofile Node.js library to allow users to configure the used profile.
 ; ato
-: would it make sense to have such a library because in the future we might want to use a webdriver way of configuring a profile
+: Would it make sense to have such a library because in the future we might want to use a WebDriver-way of configuring a profile?
-; maja
+; maja_zf
-: the profile creation code is not exposed
+: The profile creation code is not exposed.
-: There’s a PUPPETEER_PRODUCT variable and we should be able to have some state so we can reference this throughout.
+: There’s a <code>PUPPETEER_PRODUCT</code> variable and we should be able to have some state so we can reference this throughout.
 ; whimboo
-: I assume that the code paths for juggler (puppeteer-firefox) are still kept in place?
+: I assume that the code paths for Juggler (puppeteer-firefox) are still kept in place?
 ; maja_zf
 : I’m pretending the Juggler code doesn’t exist and that it will go away at some point.