Changes

'''Code Review Policy for WeaveMozilla Services Code'''

Code review prior to landing is now required for _all_ changes to all production-oriented Weave Mozilla Services code. This includes the Weave Firefox Sync client code, the Sync various pieces of server code, and the user registration codeanything else living in [http://hg.mozilla.org/services http://hg.mozilla. Future parts of the Weave client will fall under this policy once they move past the experimental phaseorg/services].

=== Reviewers =Code Areas ==

{| cellpadding="5" cellspacing="0" border="1"|-|[http://hg.mozilla.org/labs/weave/ Firefox Sync Client]|[mailto:edilee@mozilla.com Ed Lee], [mailto:mconnor@mozilla.com Mike Connor]|(add-|[http://hg.mozilla.org/labs/weaveserver-sync/ Sync Server]|[mailto:telliott@mozilla.com Toby Elliott], [mailto:lmorchard@mozilla.com Les Orchard], [mailto:mhanson@mozilla.com Mike Hanson]|-|[http://hg.mozilla.org/labs/weaveserver-registration/ User Registration Server]|[mailto:telliott@mozilla.com Toby Elliott], [mailto:lmorchard@mozilla.com Les Orchard], [mailto:mhanson@mozilla.com Mike Hanson]|}on and library code) ===

=== System'''Repositories'''[http://hg.mozilla.org/services/fx-review ===sync/ Sync Client]

System-review (similar to super-review in core Mozilla code) is designed to ensure the overall coherence and stability of the Weave ecosystem'''Reviewers'''* [mailto:philipp@weitershausen. Changes to any Weave code covered under this policy that impacts APIs, scalability, or client performance must receive system-review, in addition to primary reviewde Philipp von Weitershausen]* [mailto:mconnor@mozilla. This review will generally not cover the details of the code, but will focus on the overall system performance aspects of the patchescom Mike Connor]* [mailto:edilee@mozilla.com Ed Lee]

=== Server Code (PHP) === '''Repositories'''* [http://hg.mozilla.org/services/sync-server/ Sync Server]* [http://hg.mozilla.org/services/reg-server/ Registration Server] * [http://hg.mozilla.org/services/reg-server-secure/ Registration Server (Secure)] '''Reviewers'''* [mailto:telliott@mozilla.com Toby Elliott]* [mailto:tarek@mozilla.com Tarek Ziade]* [mailto:mconnor@mozilla.com Mike Connor] === Primary Server Code (Python) === '''Repositories'''* [http://hg.mozilla.org/services/server-core/ Core Functions (Shared)]* [http://hg.mozilla.org/services/server-reg/ Registration Code] * [http://hg.mozilla.org/services/server-storage/ Storage API Code]* [http://hg.mozilla.org/services/server-full/ Full Server] ''server-full is a meta-package that pulls in all components needed for a standalone server'' '''Reviewers'''* [mailto:tarek@mozilla.com Tarek Ziade]* [mailto:telliott@mozilla.com Toby Elliott]* [mailto:ianb@mozilla.com Ian Bicking]  === Key Exchange Server (Python) === '''Repositories'''* [http://hg.mozilla.org/services/server-key-exchange/ Key Exchange] '''Reviewers'''* [mailto:tarek@mozilla.com Tarek Ziade]* [mailto:ianb@mozilla.com Ian Bicking] = System-review = System-review (similar to super-review in core Mozilla code) is designed to ensure the overall coherence and stability of the Weave ecosystem. Changes to any Weave code covered under this policy that impacts APIs, scalability, or client performance may require system-review, in addition to primary review. This review will generally not cover the details of the code, but will focus on the overall system performance aspects of the patches. Mike Hanson Connor (mhansonmconnor@mozilla.com) is the only current system-reviewer