Services/Process/Code Review: Difference between revisions

Services/Process/Code Review (view source)

Revision as of 17:56, 1 November 2010

874 bytes added , 1 November 2010

no edit summary

Mconnor

Confirmed users, Bureaucrats and Sysops emeriti

812

edits

@@ Line 1: / Line 1: @@
-'''Code Review Policy for Weave'''
+'''Code Review Policy for Mozilla Services Code'''
-Code review prior to landing is now required for _all_ changes to all  production-oriented Weave code.  This includes the Weave Sync client  code, the Sync server code, and the user registration code.  Future  parts of the Weave client will fall under this policy once they move  past the experimental phase.
+Code review prior to landing is now required for _all_ changes to all  production-oriented Mozilla Services code.  This includes the Firefox Sync client  code, the various pieces of server code, and anything else living in [http://hg.mozilla.org/services http://hg.mozilla.org/services].
-=== Reviewers ===
+== Code Areas ==
-{| cellpadding="5" cellspacing="0" border="1"
+=== Firefox Sync (add-on and library code) ===
-|-
-|[http://hg.mozilla.org/labs/weave/ Sync Client]
-|[mailto:edilee@mozilla.com Ed Lee], [mailto:mconnor@mozilla.com Mike Connor]
-|-
-|[http://hg.mozilla.org/labs/weaveserver-sync/ Sync Server]
-|[mailto:telliott@mozilla.com Toby Elliott], [mailto:lmorchard@mozilla.com Les Orchard], [mailto:mhanson@mozilla.com Mike Hanson]
-|-
-|[http://hg.mozilla.org/labs/weaveserver-registration/ User Registration Server]
-|[mailto:telliott@mozilla.com Toby Elliott], [mailto:lmorchard@mozilla.com Les Orchard], [mailto:mhanson@mozilla.com Mike Hanson]
-|}
-=== System-review ===
+'''Repositories'''
+[http://hg.mozilla.org/services/fx-sync/ Sync Client]
-System-review  (similar to super-review in core Mozilla code) is designed to ensure  the overall coherence and stability of the Weave ecosystem.  Changes to  any Weave code covered under this policy that impacts APIs, scalability,  or client performance must receive system-review, in addition to  primary review.  This review will generally not cover the details of the  code, but will focus on the overall system performance aspects of the  patches.
+'''Reviewers'''
+* [mailto:philipp@weitershausen.de Philipp von Weitershausen]
+* [mailto:mconnor@mozilla.com Mike Connor]
+* [mailto:edilee@mozilla.com Ed Lee]
-Mike Hanson (mhanson@mozilla.com) is  the only current system-reviewer
+=== Server Code (PHP) ===
+'''Repositories'''
+* [http://hg.mozilla.org/services/sync-server/ Sync Server]
+* [http://hg.mozilla.org/services/reg-server/ Registration Server]
+* [http://hg.mozilla.org/services/reg-server-secure/ Registration Server (Secure)]
+'''Reviewers'''
+* [mailto:telliott@mozilla.com Toby Elliott]
+* [mailto:tarek@mozilla.com Tarek Ziade]
+* [mailto:mconnor@mozilla.com Mike Connor]
+=== Primary Server Code (Python) ===
+'''Repositories'''
+* [http://hg.mozilla.org/services/server-core/ Core Functions (Shared)]
+* [http://hg.mozilla.org/services/server-reg/ Registration Code]
+* [http://hg.mozilla.org/services/server-storage/ Storage API Code]
+* [http://hg.mozilla.org/services/server-full/ Full Server] ''server-full is a meta-package that pulls in all components needed for a standalone server''
+'''Reviewers'''
+* [mailto:tarek@mozilla.com Tarek Ziade]
+* [mailto:telliott@mozilla.com Toby Elliott]
+* [mailto:ianb@mozilla.com Ian Bicking]
+=== Key Exchange Server (Python) ===
+'''Repositories'''
+* [http://hg.mozilla.org/services/server-key-exchange/ Key Exchange]
+'''Reviewers'''
+* [mailto:tarek@mozilla.com Tarek Ziade]
+* [mailto:ianb@mozilla.com Ian Bicking]
+= System-review =
+System-review  (similar to super-review in core Mozilla code) is designed to ensure  the overall coherence and stability of the Weave ecosystem.  Changes to  any Weave code covered under this policy that impacts APIs, scalability,  or client performance may require system-review, in addition to  primary review.  This review will generally not cover the details of the  code, but will focus on the overall system performance aspects of the  patches.
+Mike Connor (mconnor@mozilla.com) is  the only current system-reviewer