canmove, Confirmed users
285
edits
SecurityEngineering/CodeReviewGuidelines: Difference between revisions
SecurityEngineering/CodeReviewGuidelines (view source)
Revision as of 22:17, 19 September 2013
, 19 September 2013no edit summary
No edit summary |
|||
| Line 8: | Line 8: | ||
* Don't ignore review requests. If you don't have time to do a review, help the reviewee find an alternate reviewer. | * Don't ignore review requests. If you don't have time to do a review, help the reviewee find an alternate reviewer. | ||
* Use r- instead of clearing the review flag so that it's clear the patch has been reviewed to anyone viewing the bug. | * Use r- instead of clearing the review flag so that it's clear the patch has been reviewed to anyone viewing the bug. | ||
* Respond in a reasonable amount of time with either a review or information on when you can do the review. You should not go longer than a week without any communication with the reviewee. | |||
=== For reviewees === | === For reviewees === | ||
* | * If you need a review in a specific timeframe, please ping the reviewer and let them know of the urgency/timeline. | ||
* For priority work, just saying r? is not enough, especially if the reviewer has a long request list. | * For priority work, just saying r? is not enough, especially if the reviewer has a long request list. | ||
* Don't take negative feedback personally. This includes getting an r-. | * Don't take negative feedback personally. This includes getting an r-. | ||
* Address all review comments. If you disagree with something, say why, don't ignore it. | * Address all review comments. If you disagree with something, say why, don't ignore it. | ||