View source for QA/Reading list

= Desktop Reading List =
== Ownership ==
Developer contacts: Justin Dolske, Blair McBride, Drew Willcoxon

QA Lead: [mailto:andrei.vaida@softvision.ro Andrei Vaida], :avaida on IRC

== Status ==
===Overview===
<small>'''<font color="green">[LANDED]</font>'''</small> Nightly 38: first landed, disabled by default

<small>'''<font color="green">[LANDED]</font>'''</small> Aurora 38: landed, disabled by default

{{ok|}} Beta 38: tbd

{{ok|}} Release 38: tbd

===Risk analysis===
{| class="wikitable"
|-
! Event !! Probability !! Impact !! Current situation !! Mitigation steps
|-
| Adding a website to Reading List fails to work. || tbd || high || tbd || Periodical regression testing covers this area.
|-
| Opening a website from the Reading List fails to work. || tbd || high || tbd || Periodical regression testing covers this area.
|-
| Removing a website from Reading List fails to work. || tbd || medium || tbd || Periodical regression testing covers this area.
|-
| The Reading List sidebar toggle button fails to work. || improbable || high || tbd || Periodical regression testing covers this area.
|-
| Local reading lists are not saved properly and some/all added items are missing. || tbd || high || tbd || Periodical regression testing covers this area.
|-
| Reading List items are not synced up with the Firefox Account. || tbd || medium || tbd || Periodical regression testing covers this area.
|-
| Reading List items are not synced down from the Firefox Account. ||  tbd || high || tbd || Periodical regression testing covers this area.
|}

== Summary ==
===Context===  
Reading List for Firefox Desktop is based on a cross-product set of features, scheduled for release with Firefox 38.  

The features planned for Reading List v1 are:
* a synced reading list for a user signed into a FxA
* a local only reading list for a user not signed into a FxA
* a Reader Mode that integrates with the Reading List for reading and saving

What will not be available in Reading List v1:
* offline reading support, currently available only on mobile
* web access independent of Firefox (cloud based access)

===Enabling the feature===
Reading List is available starting with Firefox 38 and it can be enabled by setting the following pref to true:
:<code>browser.readinglist.enabled</code>

== References ==
* The UX planned for Reading List is available [https://projects.invisionapp.com/share/NK1ZBQ6SY here].

== Test cases ==
===Overview===
* {{done|}} Draft test suite: '''[https://docs.google.com/spreadsheets/d/1PVhqSPcLNvIEY5SooAO81FAxN4j8MFo3Qb4WkZcONfQ/edit here]'''.
* {{todo|}} MozTrap test suite '''[[Template:incomplete|here]]'''.

===Targeted scenarios===
<big>'''Testing focused on basic functionality'''</big>
* Enable Reading List
* Disable reading List
* Check the pre-populated Reading List using a new profile
* Add a web page to local Reading List using the Location Bar
* Enable the Reading List sidebar
* Remove a web page from local Reading List using the sidebar
* Enable the Reading List sidebar from the Bookmarks Menu entry
* Sync down the Reading List from a Firefox Account
* Sync up local Reading List to a Firefox Account

<big>'''Testing focused on interoperability'''</big>
* Add web page to Reading List from Reader View's sidebar (non-pb & pb)
* Add web page to Reading List from Location Bar and restart Firefox (non-pb & pb)
* Add web page to Reading List from Library
** '''note''': since the websites from Reading List are in some way similar to bookmarks, it might be possible to add a new website to the Reading List from the Library; same goes for removing a website from the list
* Open a website from History and add it to Reading List (non-pb & pb)
* Restore a closed tab from History and add it to Reading List (non-pb & pb)
* Open a website, bookmark it and add it to Reading List (non-pb & pb)
* Open a bookmarked website and add it to Reading List (non-pb & pb)
* Bookmark a website from the Reading List (non-pb & pb)
* Import bookmarks and add one to Reading List
* Add a website to Reading List from context menu (non-pb & pb)
* Merge local Reading List with a second Reading List associated to a Firefox Account
* Merge two different Reading Lists associated to two different Firefox Accounts
* Disable Reading List syncing from about:preferences#sync
* Initiate manual sync after adding a website to Reading List
** '''note''': as in the case of Bookmarks, adding a website to Reading List might be designed to initiate up-syncing automatically
* Remove pre-populated Reading List websites (non-pb & pb)
* Open website from Reading List and display it in Reader View (non-pb & pb)
* Add several websites to Reading List subsequently (at least 15)
* Open several websites from the Reading List sidebar subsequently, in separate tabs (at least 15)
* Pin a tab where Reading List sidebar is enabled

<big>'''Testing based on recent bugs and regressions'''</big>
* TODO

<big>'''Testing Reading List with e10s'''</big>
* Reading List is currently NOT compatible with e10s.

== Bug work ==
====== Tracking bug ======
'''meta''': [https://bugzilla.mozilla.org/show_bug.cgi?id=1123529 Bug 1123529] - (desktop-readinglist) [meta] Reading List on desktop
* blocks: [https://bugzilla.mozilla.org/buglist.cgi?f1=dependson&list_id=11993272&o1=equals&query_format=advanced&v1=1123529 bugzilla query]
* depends on: [https://bugzilla.mozilla.org/buglist.cgi?f1=blocked&list_id=11993238&o1=equals&query_format=advanced&v1=1123529 bugzilla query]

<div class="toccolours mw-collapsible mw-collapsed" style="width:auto">
====== Bug triage +/- for verification ======
<div class="mw-collapsible-content">
<font color="green">'''[QE-VERIFY+]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1137231 Bug 1137231] - Double Separator In Bookmarks Menu
:↳ <small>'''2015-02-26'''</small>: most likely caused by [https://bugzilla.mozilla.org/show_bug.cgi?id=112440 Bug 112440]<br/>
<font color="green">'''[QE-VERIFY+]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1124647 Bug 1124647] - [ReadingList] Implement reading list controls in the reader mode control bar
:↳ <small>'''2015-03-06'''</small>: qe-verify+ granted by Florin Mezei
<font color="green">'''[QE-VERIFY+]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1142217 Bug 1142217] - Make the Add/Remove to Reading List toggle button of the reader view actually work<br/>
<font color="green">'''[QE-VERIFY+]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1134497 Bug 1134497] - Implement infopanels for in-product FTU Reading List/View tour<br/>
<font color="green">'''[QE-VERIFY+]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1134507 Bug 1134507] - Implement infopanels to promote Reader View / Reading List when first seen<br/>
</div>
</div>
<br/>

<div class="toccolours mw-collapsible mw-collapsed" style="width:auto">

====== Bug fix verification ======
<div class="mw-collapsible-content">
<font color="green">'''[VERI]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1124400 Bug 1124400] - [ReadingList] Add section to bookmarks popup for reading list items and actions
:↳ <small>'''2015-02-25'''</small>: verified fixed on 39.0a1, across platforms; follow ups to be made according to [https://bugzilla.mozilla.org/show_bug.cgi?id=1124400#c12 Comment 12]
:↳ <small>'''2015-03-02'''</small>: verified fixed on 38.0a1, across platforms
<font color="gray">'''[NEW]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1133611 Bug 1133611] - [ReadingList] Add promo blurb to ReadingList bookmarks menu<br/>
<font color="gray">'''[NEW]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1133610 Bug 1133610] - [ReadingList] Add promo blurb to ReadingList sidebar<br/>
<font color="gray">'''[NEW]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1133485 Bug 1133485] - Hook up "Add to ReadingList" button in desktop ReaderMode<br/>
<font color="gray">'''[NEW]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1131461 Bug 1131461] - [ReadingList] Show status text in the URLBar when interacting with the ReadingList button<br/>
<font color="gray">'''[NEW]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1131460 Bug 1131460] - [ReadingList] Add-to-readinglist button in the URLbar should have an animation similar to the bookmarking animation<br/>
<font color="gray">'''[NEW]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1131457 Bug 1131457] - [ReadingList] Add a button to the URLBar that allows adding the current page to the Reading List<br/>
<font color="green">'''[VERI]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1123517 Bug 1123517] - [ReadingList] Implement basic sidebar that lists unread ReadingList items
:↳ <small>'''2015-02-25'''</small>: verified fixed on 39.0a1 and 38.0a2, across platforms; potential issues reported
<font color="gray">'''[NEW]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1133662 Bug 1133662] - [ReadingList] Show something useful in the sidebar when the Reading List is empty<br/>
<font color="gray">'''[NEW]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1124153 Bug 1124153] - [ReadingList] Make the list of items in the Reading List sidebar scale well<br/>
<font color="gray">'''[NEW]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1123525 Bug 1123525] - [ReadingList] Allow deleting items via the Reading List sidebar<br/>
<font color="gray">'''[NEW]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1123519 Bug 1123519] - [ReadingList] Allow adding items to the Reading List via the sidebar<br/>
<font color="gray">'''[NEW]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1123518 Bug 1123518] - [ReadingList] Add thumbnails/favicons to items in the Reading List sidebar<br/>
<font color="green">'''[VERI]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1137231 Bug 1137231] - Double Separator In Bookmarks Menu when ReadingList is disabled<br/>
:↳ <small>'''2015-03-02'''</small>: verified fixed on 39.0a1 and 38.0a2, across platforms
<font color="green">'''[VERI]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1124647 Bug 1124647] - [ReadingList] Implement reading list controls in the reader mode control bar<br/>
:↳ <small>'''2015-03-09'''</small>: verified fixed on 39.0a1 and 38.0a2, across platforms
<font color="green">'''[VERI]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1133489 Bug 1133489] - Hook up "Open ReadingList" button in desktop ReaderMode<br/>
:↳ <small>'''2015-03-09'''</small>: verified fixed on 39.0a1 and 38.0a2, across platforms
<font color="green">'''[VERI]'''</font> [https://bugzilla.mozilla.org/show_bug.cgi?id=1142217 Bug 1142217] - Hook up "Open ReadingList" button in desktop ReaderMode<br/>
:↳ <small>'''2015-03-16'''</small>: verified fixed on 39.0a1, across platforms
</div>
</div>
<br/>
<div class="toccolours mw-collapsible mw-collapsed" style="width:auto">

====== Logged bugs ======
<div class="mw-collapsible-content">
[https://bugzilla.mozilla.org/show_bug.cgi?id=1137089 Bug 1137089] - The Reading List sidebar header is white on the developer edition theme
:↳ <small>'''2015-02-26'''</small>: found while verifying the fix pushed for [https://bugzilla.mozilla.org/show_bug.cgi?id=1123517 Bug 1123517]
:↳ <small>'''2015-02-27'''</small>: this is actually an issue affecting all sidebars on the Developer Edition theme, so it's not strictly related to the Reading List feature
[https://bugzilla.mozilla.org/show_bug.cgi?id=1143689 Bug 1143689] - Longer item titles from the Reading List are displayed as cutoff in the sidebar
:↳ <small>'''2015-03-16'''</small>: found while verifying the fix pushed for [https://bugzilla.mozilla.org/show_bug.cgi?id=1142217 Bug 1142217]

</div>
</div>
<br/>

== Sign off ==
===Criteria===
* All the test cases were executed.
* All the blocker, critical, major bugs have been fixed.

===Results===
'''Merge to Aurora Sign-off''' 
* {{done|}} Aurora 38 ''(2015-02-27)''.
** There were no blockers found while testing this feature.
** Manual testing covered Windows 7 (x64), Windows 8.1 (x86), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.

'''Merge to Beta Sign-off''' ''(date)''
* {{ok|}} Beta 38 ''(date)''.

'''Merge to Release Sign-off''' ''(date)''
* {{ok|}} RC 38.0 ''(date)''.