View source for Firefox/Meeting/19-Sept-2023

== General Topics / Roundtable ==

<ul>
<li><p>[mconley] [https://bugzilla.mozilla.org/show_bug.cgi?id=1821199 ''Test manifest transition from bespoke .ini to TOML continues'']</p>
<ul>
<li><blockquote><p>[tgiles] [https://groups.google.com/a/mozilla.org/g/dev-platform/c/9lYNm7A-ma0/m/iYIeiHoKAAAJ?pli=1 ''Intent to Implement''] with some background</p></blockquote></li></ul>
</li></ul>

== Friends of the Firefox team ==

=== [https://bugzilla.mozilla.org/buglist.cgi?title=Resolved%20bugs%20%28excluding%20employees%29&quicksearch=1851325%2C1849192%2C1849255%2C1851001%2C1764897%2C1695150%2C1852298%2C1842175%2C1849235%2C1851596%2C1844071%2C1849129%2C1851937%2C1643843%2C1850631%2C1646638%2C1851759%2C1834258%2C1852881&list_id=16726626 ''Resolved bugs (excluding employees)''] ===

[https://github.com/niklasbaumgardner/NewContributorScraper ''Script to find new contributors from bug list'']

=== Volunteers that fixed more than one bug ===

* Masatoshi Kimura [:emk] 
* Sebastian Zartner [:sebo] 
* Zac Svoboda :zacnomore

=== New contributors (🌟 = first patch) ===

* Krishna Ravishankar fixed incorrect removal of non-expr-stmt when top-level-await is present
* LyScott123 updated ObjectInspector to show wrapped primitive

=== General triage ===

* mak, dimi, tgiles, hjones are [https://docs.google.com/document/d/1_r8lKtJg1FXeY9R3mufsQKI3ylXiIrrLgsb3DqC0EoA/edit ''this month’s Firefox / Toolkit :: General triagers'']

== Project Updates ==

=== Add-ons / Web Extensions ===

WebExtensions Framework

* In [https://bugzilla.mozilla.org/show_bug.cgi?id=1851373 ''Bug 1851373''], we fixed a regression ([https://bugzilla.mozilla.org/show_bug.cgi?id=1830767 ''Bug 1830767'']) related to event pages being terminated while still running. This is a short-term workaround that we also uplifted to both Beta and Release. The longer term fix is now tracked by [https://bugzilla.mozilla.org/show_bug.cgi?id=1844041 ''Bug 1844041''].

WebExtension APIs

<ul>
<li><p>Fixed a bug that was making the scripting API method getRegisteredContentScripts to be returning scripts registered using the contentScripts API by the same extension - [https://bugzilla.mozilla.org/show_bug.cgi?id=1851173 ''Bug 1851173''].</p>
<ul>
<li><blockquote><p>NOTE: only manifest_version 2 extensions may have been able to hit this bug, and only if they are using both APIs (e.g. as part of transitioning to scripting API from contentScripts API but keeping the use of the contentScripts API for cases where the scripting API couldn’t be still used for). We don’t expect this bug to have been hit that often.</p></blockquote></li></ul>
</li>
<li>As part of migrating WebCompat built-in to the scripting API, we ran into [https://bugzilla.mozilla.org/show_bug.cgi?id=1853409 ''Bug 1853409''] because the scripting API matchAboutBlank is unconditionally set internally and we do not expose it in the API (See [https://bugzilla.mozilla.org/show_bug.cgi?id=1853013#c6 ''Bug 1853013 comment 6'']). As a short term workaround, we agreed with the WebCompat team to special-case the WebCompat extension ID in [https://bugzilla.mozilla.org/show_bug.cgi?id=1853412 ''Bug 1853412''] until the underlying [https://bugzilla.mozilla.org/show_bug.cgi?id=1853409 ''Bug 1853409''] has been fixed.</li></ul>

=== Developer Tools ===

=== DevTools ===

<ul>
<li><p>Contributors</p>
<ul>
<li><blockquote><p>Sebastian Zartner (:sebo) added inactive CSS warnings for ignored properties on</p></blockquote>
<ul>
<li>::placeholder pseudo-elements ([https://bugzilla.mozilla.org/show_bug.cgi?id=1849255 ''bug''])</li>
<li>::first-letter pseudo-elements ([https://bugzilla.mozilla.org/show_bug.cgi?id=1842175 ''bug''])</li>
<li>::cue pseudo-elements ([https://bugzilla.mozilla.org/show_bug.cgi?id=1849235 ''bug''])</li></ul>
</li>
<li><blockquote><p>Zac Svoboda (:zacnomore) made a lot of contributions in the last 2 weeks</p></blockquote>
<ul>
<li>Switch to Data view when JSON is broken ([https://bugzilla.mozilla.org/show_bug.cgi?id=1764897 ''bug''])</li>
<li>Fixed color contrast for Layout flexbox highlight toggle ([https://bugzilla.mozilla.org/show_bug.cgi?id=1844071 ''bug''])</li>
<li>Tweaked spacing on compatibility panel elements ([https://bugzilla.mozilla.org/show_bug.cgi?id=1643843 ''bug''])</li>
<li>Fixed a typo in a property name ([https://bugzilla.mozilla.org/show_bug.cgi?id=1646638 ''bug''])</li></ul>
</li>
<li><blockquote><p>LyScott123 made wrapped primitive value visible in console/debugger ([https://bugzilla.mozilla.org/show_bug.cgi?id=1695150 ''bug''])</p></blockquote>
<ul>
<li>[https://snipboard.io/n1fbSs.jpg ''screenshot'']</li></ul>
</li>
<li><blockquote><p>krishna.ravi732 fixed a bug in top-level await console evaluation and for loops ([https://bugzilla.mozilla.org/show_bug.cgi?id=1851759 ''bug''])</p></blockquote></li></ul>
</li>
<li>Arai added column source notes to binary operator and function call arguments so the debugger can underline the right expression for Uncaught TypeError ([https://bugzilla.mozilla.org/show_bug.cgi?id=1845865 ''bug''])</li>
<li>Alex improved the debugger performance (e.g. opening a big file is 20% faster) keeping data in a worker and then querying the worker, instead of transfering the data from the worker to the main thread ([https://bugzilla.mozilla.org/show_bug.cgi?id=1851522 ''bug''], [https://bugzilla.mozilla.org/show_bug.cgi?id=1851566 ''bug''])</li>
<li>Bomsy fixed an issue that would lead to debugger crashes ([https://bugzilla.mozilla.org/show_bug.cgi?id=1849946 ''bug''])</li>
<li><p>Nicolas made the Computed panel show custom properties value ([https://bugzilla.mozilla.org/show_bug.cgi?id=1834690 ''bug''])</p>
<ul>
<li><blockquote><p>[https://snipboard.io/FhlpHM.jpg ''screenshot'']</p></blockquote></li></ul>
</li>
<li>Nicolas made the Rule view refresh when a stylesheet is added to the page ([https://bugzilla.mozilla.org/show_bug.cgi?id=1776831 ''bug''])</li></ul>

=== WebDriver BiDi ===

* Sasha implemented the script.realmDestroyed event which lets clients know when the realm is not available anymore for script evaluation ([https://bugzilla.mozilla.org/show_bug.cgi?id=1788659 ''bug''])
* Sasha implemented the browsingContext.userPromptClosed event ([https://bugzilla.mozilla.org/show_bug.cgi?id=1824221 ''bug''])
* Henrik implemented the browsingContext.reload, which provides a simple API to reload a given browsing context ([https://bugzilla.mozilla.org/show_bug.cgi?id=1830859 ''bug''])
* Julian updated our vendored version of puppeteer to v21.2.0, with almost 100 new tests passing with the BiDi implementation (close to the 50% mark, see [https://puppeteer.github.io/ispuppeteerwebdriverbidiready/ ''https://puppeteer.github.io/ispuppeteerwebdriverbidiready/''] ) ([https://bugzilla.mozilla.org/show_bug.cgi?id=1851438 ''bug''])

=== ESMification status ===

<ul>
<li>(no voice update)</li>
<li>No changes this time.</li>
<li><p>[https://spidermonkey.dev/areweesmifiedyet/ ''ESMified status'']:</p>
<ul>
<li><blockquote><p>browser: 86%</p></blockquote></li>
<li><blockquote><p>toolkit: 99%</p></blockquote></li>
<li><blockquote><p>Total: 95.55%</p></blockquote></li></ul>
</li>
<li>#esmification on Matrix</li></ul>

=== Information Management ===

<ul>
<li><p>QA has given us the green light on our session restore work (and most has been in Nightly behind a pref for a while), so we’ll be shipping that in 119 with prefs on by default.</p>
<ul>
<li><blockquote><p>[https://bugzilla.mozilla.org/show_bug.cgi?id=1820660 ''Persisting closed tabs between sessions'']</p></blockquote></li>
<li><blockquote><p>[https://bugzilla.mozilla.org/show_bug.cgi?id=1819675 ''Expand recently closed tabs to all windows'']</p></blockquote></li>
<li><blockquote><p>[https://bugzilla.mozilla.org/show_bug.cgi?id=1833522 ''Include closed tabs from closed windows'']</p></blockquote></li></ul>
</li>
<li>Firefox View is shipping in 119</li></ul>

=== Lint, Docs and Workflow ===

* (no voice update)
* The ESLint rule react-hooks/exhaustive-deps will now [https://bugzilla.mozilla.org/show_bug.cgi?id=1851452 ''raise errors rather than warnings'']. The previous warnings for this rule have been fixed.
* Additionally, all the rules enabled in devtools/client/debugger will now [https://bugzilla.mozilla.org/show_bug.cgi?id=1851794 ''all raise errors rather than warnings''].
* With some other improvements, we're now down to about 13 ESLint warnings left in mozilla-central.
* This all helps to ensure that we're fixing issues where we intend for them to be fixed. It also means that using warnings as part of a roll-out mechanism will help highlight that the warnings are something that we need to fix.

=== Migration Improvements ===

<ul>
<li>Extension migration support has started to roll out on the release channel! Note that this only supports a limited number of Chrome extensions at this point.</li>
<li><p>Improvements importing when Firefox is installed as a Snap</p>
<ul>
<li><blockquote><p>Thanks to mstriemer and Ani Movsesian from CalState, we’ve got a good sense of a way forward here.</p></blockquote></li>
<li><blockquote><p>In newer versions of Ubuntu, it seems like we can use a native file picker in folder picking mode to get access to the other browser’s data directories, like we do on macOS for Safari.</p></blockquote>
<ul>
<li>mconley is [https://bugzilla.mozilla.org/show_bug.cgi?id=1852839 ''adding run-time feature detection to make sure folder selection is possible''] given the systems version of xdg-desktop-portal</li>
<li>Then there’s some glue to add instructions for reaching that folder. That work will take place in [https://bugzilla.mozilla.org/show_bug.cgi?id=1818237 ''this bug.'']</li></ul>
</li>
<li><blockquote><p>mconley [https://forum.snapcraft.io/t/making-it-easier-to-migrate-data-from-other-browsers-into-firefox/36721 ''started a conversation on the snapcraft.io forums''] to see if there are ways to improve the experience further.</p></blockquote></li></ul>
</li>
<li><p>We’re doing a small experiment to see if adding some adorable illustrations to [https://support.mozilla.org/1/firefox/119.0a1/Darwin/en-US/switching-devices?utm_content=switch-to-new-device&utm_source=help-menu&utm_medium=firefox-desktop&utm_campaign=migration ''the device migration wizard''] improves the number of people going through it.</p>
</li></ul>

=== New Tab Page ===

* [mconley] I have a patch to [https://bugzilla.mozilla.org/show_bug.cgi?id=1812135 ''replace the bespoke toggle in the customization panel with moz-toggle'']. MozLitElement will work on about:newtab!

=== Performance ===

* [mconley] [https://hacks.mozilla.org/2023/09/faster-vue-js-execution-in-firefox/ ''Some more great work from our performance team''] means that sites using Vue.js 3.0 will run better in Firefox!

=== Search and Navigation ===

<ul>
<li>Daisuke has fixed a bug where [https://bugzilla.mozilla.org/show_bug.cgi?id=1637408 ''copying an autofilled URL doesn’t include protocol'']</li>
<li>Mandy has implemented [https://bugzilla.mozilla.org/show_bug.cgi?id=1688019 ''deduping redirect links (e.g. from Google search result pages) in address bar results'']</li>
<li>Karandeep has [https://bugzilla.mozilla.org/show_bug.cgi?id=1842247 ''implemented telemetry for the upcoming clipboard result feature'']</li>
<li><p>Search engine result page telemetry:</p>
<ul>
<li><blockquote><p>James has [https://bugzilla.mozilla.org/show_bug.cgi?id=1842554 ''enabled SERP telemetry on Release'']</p></blockquote></li>
<li><blockquote><p>Stephanie has made it so that we [https://bugzilla.mozilla.org/show_bug.cgi?id=1846357 ''extract domains for basic SERP links'']</p></blockquote></li>
<li><blockquote><p>James has fixed a bug where [https://bugzilla.mozilla.org/show_bug.cgi?id=1849728 ''clicking certain sponsored links was registered as a &quot;non_ads_link&quot;'']</p></blockquote></li>
<li><blockquote><p>James [https://bugzilla.mozilla.org/show_bug.cgi?id=1850000 ''added a listener and store for the Search Categorization collection'']</p></blockquote></li></ul>
</li>
<li>Stephanie has fixed [https://bugzilla.mozilla.org/show_bug.cgi?id=1847794 ''Search component's browser mochitests and XPCShell tests use add_setup correctly'']</li>
<li><p>CSS nesting:</p>
<ul>
<li><blockquote><p>[mandy] [https://bugzilla.mozilla.org/show_bug.cgi?id=1848302 ''Bug 1848302 - Use CSS nesting for weather result rules'']</p></blockquote></li>
<li><blockquote><p>[marc] [https://bugzilla.mozilla.org/show_bug.cgi?id=1847969 ''Bug 1847969 - Use CSS nesting for .urlbarView-type-icon rules'']</p></blockquote></li>
<li><blockquote><p>[dao] [https://bugzilla.mozilla.org/show_bug.cgi?id=1847973 ''Bug 1847973 - Use CSS nesting for .urlbarView-favicon rules'']</p></blockquote></li>
<li><blockquote><p>[dao] [https://bugzilla.mozilla.org/show_bug.cgi?id=1847975 ''Bug 1847975 - Use CSS nesting for .urlbarView-results[wrap] rules'']</p></blockquote></li>
<li><blockquote><p>[dao] [https://bugzilla.mozilla.org/show_bug.cgi?id=1847979 ''Bug 1847979 - Use CSS nesting for .urlbarView-body-inner, .urlbarView-results, .urlbarView-row, .urlbarView-row-inner, and .urlbarView-no-wrap rules'']</p></blockquote></li>
<li><blockquote><p>[dao] [https://bugzilla.mozilla.org/show_bug.cgi?id=1853121 ''Bug 1853121 - Use CSS nesting for Tab To Search onboarding'']</p></blockquote></li>
<li><blockquote><p>[dao] [https://bugzilla.mozilla.org/show_bug.cgi?id=1853125 ''Bug 1853125 - Use CSS nesting for .urlbarView-dynamic-calculator-action'']</p></blockquote></li>
<li><blockquote><p>[dao] [https://bugzilla.mozilla.org/show_bug.cgi?id=1853127 ''Bug 1853127 - Use CSS nesting for Unit Conversion results'']</p></blockquote></li>
<li><blockquote><p>[dao] [https://bugzilla.mozilla.org/show_bug.cgi?id=1853145 ''Bug 1853145 - Use CSS nesting for add-on suggestions'']</p></blockquote></li></ul>
</li>
<li>Dale has fixed a bug where address bar results show an [https://bugzilla.mozilla.org/show_bug.cgi?id=1848737 ''incorrect link when moving to search engines using the keyboard'']</li>
<li>Pier from the Tor project has [https://bugzilla.mozilla.org/show_bug.cgi?id=1849129 ''hardened SearchService initialization so that exceptions from extensions won’t make it fail anymore'']</li>
<li>Marc [https://bugzilla.mozilla.org/show_bug.cgi?id=1850492 ''removed the security.insecure_connection_icon.enabled and security.insecure_connection_icon.pbmode.enabled prefs'']</li>
<li>Daisuke [https://bugzilla.mozilla.org/show_bug.cgi?id=1850902 ''removed the browser.fixup.alternate.enabled pref'']</li>
<li>Dale has fixed the [https://bugzilla.mozilla.org/show_bug.cgi?id=1851449 ''trending searches checkbox in about:preferences not getting disabled when all search engine suggestions are turned off'']</li>
<li><p>Add-on suggestions for Firefox Suggest users</p>
<ul>
<li><blockquote><p>Drew has [https://bugzilla.mozilla.org/show_bug.cgi?id=1851940 ''enabled addon suggestions by default with treatment B (no rating stars)'']</p></blockquote></li>
<li><blockquote><p>Drew has [https://bugzilla.mozilla.org/show_bug.cgi?id=1851941 ''added UTM params to addon suggestion URLs'']</p></blockquote></li>
<li><blockquote><p>Drew has [https://bugzilla.mozilla.org/show_bug.cgi?id=1851942 ''updated the &quot;Not relevant&quot; command for addon suggestions to block individual suggestions'']</p></blockquote></li>
<li><blockquote><p>[drew] [https://bugzilla.mozilla.org/show_bug.cgi?id=1852300 ''Bug 1852300 - Address Bar result menu glitches after an Add-on recommendation is dismissed'']</p></blockquote></li>
<li><blockquote><p>[drew] [https://bugzilla.mozilla.org/show_bug.cgi?id=1852353 ''Bug 1852353 - Minimum keyword length/character count is not capped for addon suggestions'']</p></blockquote></li>
<li><blockquote><p>[drew] [https://bugzilla.mozilla.org/show_bug.cgi?id=1852354 ''Bug 1852354 - For addon and Pocket suggestions, the “Show less frequently” option is not removed from the Feedback menu if the Address Bar panel is not closed after reaching the frequency cap'']</p></blockquote></li></ul>
</li>
<li>Daisuke [https://bugzilla.mozilla.org/show_bug.cgi?id=1852187 ''moved sponsored suggestions higher in the results list'']</li>
<li><p>Marco fixed [https://bugzilla.mozilla.org/show_bug.cgi?id=1852963 ''Bug 1852963 - Some tests await on BrowserTestUtils.loadURIString, that doesn't wait for load'']</p>
<ul>
<li><blockquote><p>Notably, this rename BrowserTestUtils.loadURIString to .startLoadingURIString</p></blockquote></li></ul>
</li></ul>

=== Storybook/Reusable Components ===

<ul>
<li><p>Jules update our [https://bugzilla.mozilla.org/show_bug.cgi?id=1838939 ''Typography support in design tokens''] - Look for the text-and-typography.css file for some class helpers - [https://bugzilla.mozilla.org/show_bug.cgi?id=1838939 ''Bug 1838939'']</p>
</li>
<li>sclements updated panel-list to add submenu support this week - [https://bugzilla.mozilla.org/show_bug.cgi?id=1845333 ''Bug 1845333'']</li>
</ul>

== This week I learned == 

<ul>
<li><p>[mandy] resources on css nesting that I found helpful</p>
<ul>
<li><p>[https://drafts.csswg.org/css-nesting-1/ ''https://drafts.csswg.org/css-nesting-1/'']</p></li>
<li><p>[https://developer.chrome.com/articles/css-nesting/ ''https://developer.chrome.com/articles/css-nesting/'']</p></li>
</ul>
</li></ul>