Tree Rules/comm-central: Difference between revisions

← Older edit

Tree Rules/comm-central (view source)

Revision as of 07:44, 6 October 2014

2,161 bytes added , 6 October 2014

→‎Thunderbird: Add outline of current tree closure reasons/rules

Standard8

canmove, Confirmed users, Bureaucrats and Sysops emeriti

3,628

edits

@@ Line 1: / Line 1: @@
 Due to multiple applications using comm-central different parts of comm-central can have different rules at different times. We try to keep these as simple as possible, if in doubt, please ask on irc.
-== comm-central ==
+== Owned Areas ==
+These are the directories and areas which are seen as "owned" by a particular comm-central application. The tree rules for each app apply to these directories and files.
 === Thunderbird ===
-==== Affected Areas ====
 Thunderbird Rules affect these directories & areas in comm-central:
 * Build Config (e.g. configure.in, build/, config/)
-* directory/
+* ldap/
 * editor/
 * mailnews/
@@ Line 16: / Line 16: @@
 * other-licenses/*/thunderbird/
-==== Current Rules ====
+==== When does the tree get closed or changed to approval required? =====
-'''When open: <font color="green">OPEN</font>''' to all checkins following the [https://developer.mozilla.org/en/comm-central#comm-central_tree_rules checkin rules]
+The tree is closed when:
+* When there is multi-platform bustage
+* If there are too many test failures per suite, that makes it impossible to star accurately.
+** e.g. 10 or more xpcshell failures happening at the same time.
-Please ask on #maildev if you have questions.
+The tree is approval required when:
+* There is perma-red or perma-orange on one or more platforms.
+* Approval is then generally required for landing patches, except bustage-fixes.
+* Approval is required because
+** Historically, people have been seen not to star oranges before and after landing, hence this needs checking and validating
+** Sometimes bustage is starred incorrectly
+* Approval should check:
+** The tree is starred
+** The patch is unlikely to affect the bustage areas (unless it is fixing them!)
+*** e.g. if Mac is busted, then landing a Mac-only patch isn't a good idea. A patch that doesn't have Mac specific parts is probably fine.
 === SeaMonkey ===
-==== Affected Areas ====
 * suite/
 * other-licenses/*/seamonkey/
-==== Current Rules ====
+=== Lightning ===
-'''When open: <font color="green">OPEN</font>''' to all checkins following the [https://developer.mozilla.org/en/comm-central#comm-central_tree_rules checkin rules]
-Please ask on #seamonkey if you have questions.
-=== Calendar ===
-==== Affected Areas ====
 * calendar/
-* other-licenses/*/sunbird/
-==== Current Rules ====
-* Calendar strings are frozen for the 1.0 beta 1 release.
-** No changes to strings are allowed.
-Please ask on #calendar if you have questions.
-== comm-1.9.1 ==
-=== Thunderbird ===
-==== Affected Areas ====
-Thunderbird Rules affect these directories & areas in comm-central:
-* Build Config (e.g. configure.in, build/, config/)
+== comm-central (Nightly channel) ==
-* directory/
-* editor/
-* mailnews/
-* mail/
-* other-licenses/*/thunderbird/
-==== Current Rules ====
+* '''All changes''' must meet the [https://developer.mozilla.org/En/Developer_Guide/Committing_Rules_and_Responsibilities general checkin rules]. You must check the tree before pushing, and watch the tree for failures after pushing.
+* Set the ''Target Milestone'' field in Bugzilla to the current Nightly version after landing a bug fix on comm-central.
+* Please ask the sheriff channel (typically, #maildev, #seamonkey or #calendar depending on the application you are landing to) on [[IRC]] if you have questions.
-* Thunderbird is code frozen in preparation for the 3.0 release candidates.
+== comm-aurora ==
-* Checkins are allowed only if:
-** Strings in mail/locales and editor/ui are '''not''' affected.
-** The patch has ''approval-thunderbird3.0+''
-** The patch is on a bug marked as ''blocking-thunderbird3.0+''
-Note: ''wanted-thunderbird3.0+'' does '''not''' approve a patch for check in.
+'''<font color="orange">APPROVAL REQUIRED</font>'''
-When requesting approval, please state the (stability) risk this patch poses and the reason we need to take it for the 3.0 release.
+* '''All changes''' must meet the [https://developer.mozilla.org/En/Developer_Guide/Committing_Rules_and_Responsibilities general checkin rules]. You must check the tree before pushing, and watch the tree for failures after pushing.
+* Patches must have the '''approval-comm-aurora+''' flag in Bugzilla. To request approval, set the approval-comm-aurora? flag on the patch you wish to check in.
+* Patches nominated for aurora should:
+** have tests, or a strong statement of what can be done in the absence of tests.
+** have landed in comm-central to bake on the nightly channel for a few days.
+** have a comment in Bugzilla assessing performance impact, risk, and reasons the patch is needed on aurora.
+* Approval requests are processed regularly.
+* Set the appropriate ''status-thunderbirdN'', ''status-seamonkeyN'' flag to "fixed" after landing a fix on the Aurora branch.
-Patches that are tidy up only or high risk will most likely be rejected.
+== comm-beta ==
-Please ask on #maildev if you have questions.
+'''<font color="orange">APPROVAL REQUIRED</font>'''
-=== SeaMonkey ===
+* '''All changes''' must meet the [https://developer.mozilla.org/En/Developer_Guide/Committing_Rules_and_Responsibilities general checkin rules]. You must check the tree before pushing, and watch the tree for failures after pushing.
+* Patches must have the '''approval-comm-beta+''' flag in Bugzilla. To request approval, set the approval-comm-beta? flag on the patch you wish to check in.
+* Patches nominated for beta should:
+** have tests, or a strong statement of what can be done in the absence of tests.
+** have landed in mozilla-central to bake on the nightly channel for a few days.
+** have a comment in Bugzilla assessing performance impact, risk, and reasons the patch is needed on beta.
+** not change binary interfaces or otherwise break add-on compatibility.
+* Approval requests are processed regularly.
+* Set the appropriate ''status-thunderbirdN'', ''status-seamonkeyN'' flag to "fixed" after landing a fix on the Beta branch.
-==== Affected Areas ====
+== comm-release ==
-* suite/
+'''<font color="orange">APPROVAL REQUIRED</font>'''
-* other-licenses/*/seamonkey/
-==== Current Rules ====
+* Patches must have the '''approval-comm-release+''' flag in Bugzilla. To request approval, set the approval-comm-release? flag on the patch you wish to check in.
+* In the normal development process, no changes will land on comm-release except [[RapidRelease/Calendar|regular merges from comm-beta]] every six weeks.
-* SeaMonkey is feature frozen in preparation for the 2.0 release. No new features allowed.
+* Changes to the release branch are limited to urgent "chemspills" like zero-day security vulnerabilities and other unplanned emergencies.  Any changes to this branch will be directly overseen by the [Releases/Drivers release drivers for the appropriate product].
-* Checkins are allowed only if:
-** The patch has ''approval-seamonkey2.0+'' (blocking/wanted are not enough).
-When requesting approval, please state the (stability) risk this patch poses and the reason we need to take it for the 2.0 release.
-Please ask on #seamonkey if you have questions.
-=== Calendar ===
-==== Affected Areas ====
-* calendar/
-* other-licenses/*/sunbird/
-==== Current Rules ====
+== comm-esr17 (Thunderbird 17.0.x ESR) ==
-* Calendar strings are frozen for the 1.0 beta 1 release.
+'''<font color="orange">APPROVAL REQUIRED</font>'''
-** No changes to strings are allowed.
-Please ask on #calendar if you have questions.
+* We use the same process as the Firefox [[Release Management/ESR Landing Process]].
+** Use the tracking-thunderbird-esr17 and status-thunderbird-esr17 flags instead of the Firefox ones.