TPE-Layout/2017-03-28

Weekly Sharing

• CJ Ku
  • Why we need imgIContainer::FLAG_SYNC_DECODE flag?
  • http://searchfox.org/mozilla-central/rev/7419b368156a6efa24777b21b0e5706be89a9c2f/layout/painting/nsDisplayList.cpp#3533

• Shing
  • Intro to buiding a Python interpreter in Rust

• Jeremy
  • couple CSS properties I've learned recently
    • text-justify
    • text-size-adjust
    • font-language-override

Weekly Status

Astley Chen

Firefox Manager Workweek

• 3/20 ~ 3/24, Philadelphia, USA.

Boris Chiou

stylo animations

• bug 1332633 - stylo: Implement ComputeDistance for AnimationValues
  • wip
• bug 1343153 - stylo: use servo css-parser for ParseEasing
  • land
• bug 1349834 - stylo: Remove eRestyle_SVGAttrAnimations declartion.
  • land
• bug 1336769 - stylo: 1272475-1.html and 1272475-2.html fails with Assertion failure: !mozilla::IsNaN(mValue.mFloat)
  • r-

Animation

• bug 1349808 - Add telemetry for cases when we can't run async animations due to layer size being too large
  • r?

Reviews

• bug 1351145 - Enable reftest for CSS animation on pseudo element.
• bug 1318223 - Unify NonOwningAnimationTarget and OwningElementRef

Cameron McCormack

Stylo

• bug 1301258 - mask off generated change hints for an element when only some have been subsumed by change hints on ancestors
  • land
• bug 1349134 - stylo: TraversalRootBehavior::UnstyledChildrenOnly doesn't work when <xbl:children> distributes the new children further down the tree
  • r+ | land
• bug 1349457 - stylo: eagerly style generated content just after it is created
  • r+ | land
• bug 1349487 - stylo: eagerly style content appended in a ShadowRoot
  • r+ | land
• bug 1350671 - stylo: PresShell::RecreateFramesFor is sometimes called when there are pending restyles
  • r+

Other

• bug 1350789 - Possible error in CSSStyleSheet::SizeOfIncludingThis
  • r+ | land

Stylo reviews

• bug 1349815 - stylo: Gecko_GetLookAndFeelSystemColor mutates static data
• bug 1346256 - stylo: Expose computed style list to dev tools
• bug 1349553 - stylo: Fix a few dynamic state change handling bugs.
• bug 1341775 - stylo: need to do the right thing with "font-family: monospace" in terms of font size
• bug 1349885 - stylo: Simplify computation of float and position.
• bug 1350115 - stylo: StyleNewSubtree triggers animation restyle and requests a post-traversal we aren't set up to do
• bug 1350140 - stylo: Implement all the pending state pseudo-classes.
• bug 1344966 - stylo: Implement eRestyle_CSSAnimations and eRestyle_CSSTransitions to avoid triggering CSS transitions due to style changes caused by animations
• bug 1350441 - stylo: fix a few restyle state coherency bugs
• bug 1350754 - stylo: Call EffectCompositor::UpdateEffectProperties()
• bug 1350244 - stylo: Hit MOZ_CRASH(Array not threadsafe) in layout/reftests/bugs/652301-1b.html
• servo/servo#16144 - style: Make numbers keep track of whether they were specified as calc().

Other reviews

• bug 1318542 - [webvtt] support ::cue pseudoelement from document.
• bug 1349462 - Rename nsIFrame::IsSVGText() to nsSVGUtils::IsInSVGTextSubtree()
• bug 1350734 - Load xul.css lazily in the content process

CJ Ku

• bug 1350793 - [META] Trace all reftest capture failure in svg module
  • filed.

Farmer Tseng

Mortar Printing

• bug 1345710 - [Mortar] [Windows] Implement Emf, PDFEngineExports and PdfPrintHelperWin
  • r? Bug 1345710 - part1: implement a WindowsEMF class to support Windows Enhance Metafile
  • r? Bug 1345710 - part2: implement a PDFiumEngineShim class to link to PDFium symbols
  • r? Bug 1345710 - part3: implement PdfPrintHelperWin to convert PDF to EMF
  • r? Bug 1345710 - fix nsWindowsGfx.cpp build break
  • r? Bug 1345710 - fix nsWindowDbg build break
  • r? Bug 1345710 - fix redefinition warning in Unified_cpp_widget_windows3

Label Printing

• bug 1342872 - Label runnables in layout/printing/
  • r+ Bug 1342872 - part1: Label the runnable dispatched by NS_DispatchToCurrentThread in nsPrintEngine
  • r+ Bug 1342872 - part2: Name the nsPagePrintTimer runnable and associate its nsITimers with a DocGroup

Jeremy Chen

Quantum DOM

• bug 1349114 - label CallPrintCallback for HTMLCanvasElement
  • file | land
• bug 1342870 - Label runnables in layout/generic/
  • resolve

Quantum Layout (stylo)

• bug 1347819 - Change nsFont::languageOverride to store uint32_t directly
  • r+ | land
• bug 1347821 - stylo: Implement gecko glue for font-language-override
  • r+

other

• Correct the MDN page for font-language-override property
  • the example for the default value should be "normal", not "none"
  • see https://developer.mozilla.org/en-US/docs/Web/CSS/font-language-override$history

Shing Lyu

Stylo

• Analyzing reftest failures

Evangelism

• NCTU student project mentoring
• Project Quantum talk at MozTW community

Tingyu Lin

stylo

• bug 1322570 - stylo: assert against calling GetParent for stylo-backed style contexts
  • land

Tommy Kuo

Quantum DOM

• bug 1342867 - Label the runnable of ScrollOnFocusEvent in nsTextControlFrame.cpp
  • land
• bug 1342863 - Label runnables in layout/base/
  • land
• bug 1342874 - Label runnables in layout/xul/
  • r?dholbert
• bug 1348738 - Labeling timer callback using nsRepeatService
  • r?dholbert

XPCOM

• bug 1348900 - Deprecate NewTimerCallback
  • land

Rule of Thumb

Status code:

• OOAD: In analysis or design phase.
• WIP: working on WIP patch.
• feedback(f): feedback a patch
• feedback?(f?): WIP is ready for feedback grant.
• feedback+(f+): Get positive feedback.
• feedback-(f-): Get negative feedback.
• review(r): review a patch.
• review?(r?): patch is under review
• review+(r+): get review+ and ready to check-in
• review-(r-): get negative review feedback. Fix problems and switch back to r? again.
• land: patch check in.
• debug: Figure out the root cause of a bug/ try to repro that bug, etc...
• file: file a bug
• PTO: take personal leave
• interview(I)
• study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
• presentation
  • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
  • WIKI/ MDN article writing.
  • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
  • Do a presentation of technical topics