TPE-Layout/2017-08-22: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
 
(→‎Eric Tsai: 20170822 status update)
 
(3 intermediate revisions by 3 users not shown)
Line 5: Line 5:
==Weekly Status==
==Weekly Status==
===Astley Chen===
===Astley Chen===
* {{bug|1294490}} ASSIGNED:: Implement experimental WebP image support
** Bug 1294490 - adding webcompat label as visual differences on youtube.com
* {{bug|895096}} NEW:: border-collapsed table borders have inconsistent widths when device pixel scale is not 1 (zoom)
** Bug 895096 - triaged
* {{bug|1389286}} NEW:: Ruby layout doesn't play nice with ::first-line
** Bug 1389286 - triaged


===Boris Chiou===
===Boris Chiou===
* {{bug|1387951}} RESOLVED::FIXED stylo: Make interpolation behavior of -moz-image-region with 'auto' value match with gecko
** Reviewed bug 1387951 - stylo: Make interpolation behavior of -moz-image-region with 'auto' value match with gecko
* {{bug|1387939}} RESOLVED::FIXED stylo: Interpolation of "Integer or Auto" is incorrect in test_transitions_per_property.html
** Reviewed bug 1387939 - stylo: Interpolation of "Integer or Auto" is incorrect in test_transitions_per_property.html
* {{bug|1387990}} ASSIGNED:: stylo: Many interpolations of transform are failed in test_transitions_per_property.html
** Debugged and wrote some patches for bug 1387990 - stylo: Many interpolations of transform are failed in test_transitions_per_property.html
** Wrote a stylo-only version of 2d matrix decomposition for Bug 1387990 - stylo: Many interpolations of transform are failed in test_transitions_per_property.html
** Wrote a stylo-only version of 2d matrix decomposition for bug 1387990 - stylo: Many interpolations of transform are failed in test_transitions_per_property.html
* {{bug|1389023}} RESOLVED::FIXED stylo: The interpolation of perspective transform is not correct
** Landed bug 1389023 - stylo: The interpolation of perspective transform is not correct
* {{bug|1387973}} RESOLVED::FIXED stylo: Some distance calculation and interpolated results are not correct for {box|text}-shadow in test_transitions_per_property.html
** Reviewed bug 1387973 - Implement distance for shadow list.
* {{bug|1389429}} RESOLVED::FIXED stylo: The interpolations of rotatex and rotatey are not correct.
** Landed bug 1389429 - stylo: The interpolations of rotatex and rotatey are not correct.
* {{bug|1362896}} RESOLVED::FIXED stylo: Implement compute_distance for TransformList
** Landed bug 1362896 - stylo: Implement compute_distance for TransformList


===Cameron McCormack===
===Cameron McCormack===
* {{bug|1389300}} RESOLVED::FIXED stylo: Crash in nsRuleNode::nsRuleNode
** Reviewed bug 1389300
* {{bug|1390255}} RESOLVED::FIXED stylo: A few stylist-related cleanups.
** Reviewed bug 1390255
* {{bug|1385745}} RESOLVED::FIXED Only first line is visible in inline element with filter and box-decoration-break:clone
** Reviewed bug 1385745
* {{bug|1373343}} RESOLVED::FIXED stylo: Only do parallel traversals when the tab is foreground
** Reviewed bug 1373343
* {{bug|1367635}} NEW:: stylo: consider caching style structs in the rule tree
** Continuing to look at bug 1367635
** Still working on bug 1367635; memory leak solved, still a few test failures left


===CJ Ku===
===CJ Ku===
* {{bug|1385745}} RESOLVED::FIXED Only first line is visible in inline element with filter and box-decoration-break:clone
** Bug  1385745 review test cases
* {{bug|1389712}} NEW:: switching to a Google Slides tab is slow (long repaint)
** Bug 1389712 look into profile data
* {{bug|1390088}} ASSIGNED:: SVG within SVG (embedded) not displaying correctly in 56.0b2.
** Bug 1390088 WIP
** Bug 1390088 upload patches
* {{bug|577824}} RESOLVED::FIXED HTML element attached is not rendered if an SVG filter is applied to it
** Bug 577824 landed
* {{bug|1388985}} ASSIGNED:: css clip-path with basic-shape rendering should respect box-decoration-break
** Bug 1388985 patch reviewed
* {{bug|1318266}} RESOLVED::FIXED Draw trivial clip-path onto mask layer
** Bug 1318266 fix reftest failure and reland
* {{bug|852100}} UNCONFIRMED:: SVG filters may shift and blur elements in embedded image
** Bug 852100 upload patch


===Eric Tsai===
===Eric Tsai===
* Issue triage/diagnosis
** No 3DES in Nightly cause secure connection error: https://bugzilla.mozilla.org/show_bug.cgi?id=1386908
** Google font load error: https://bugzilla.mozilla.org/show_bug.cgi?id=1331797
** Animated GIF in Firefox for android distorted: https://bugzilla.mozilla.org/show_bug.cgi?id=1391430
** Animated PNG in Firefox for android distorted: https://bugzilla.mozilla.org/show_bug.cgi?id=1383499
* Webcompat to bugzilla extension: fetch product/component from bugzilla


===Farmer Tseng===
===Farmer Tseng===
* {{bug|1388951}} RESOLVED::FIXED [PDF gtest] Compare EMF contents with reference
** Landed, Bug 1388951
** Uploaded patch and  r? on Bug 1388951
* {{bug|1382509}} ASSIGNED:: Build PDFium as a separate library instead of linking it into libxul
** Limit the exporting symbols, uploaded patch and r? on Bug 1382509


===Jeremy Chen===
===Jeremy Chen===
* {{bug|1391178}} NEW:: Scrolling in a popup should not cause scrolling in its underlying content
** Filed Bug 1391178
* {{bug|1375332}} ASSIGNED:: stylo: font-size doesn't always respond to language-specific minimum size when using charset-derived language
** Updated debug progress [Bug 1375332]
** Updated patches to fix couple try failures [Bug 1375332]
** Uploaded patches for review [Bug 1375332]
* {{bug|1387982}} RESOLVED::FIXED stylo: The interpolation between drop-shadow functions without specified color is wrong
** Landed Bug 1387982
** Uploaded patch for review [Bug 1387982]


===Louis Chang===
===Louis Chang===
* {{bug|1352238}} - Implement a native theme for checkbox/radio form controls on Android
** WIP
* {{bug|1385745}} - Only first line is visible in inline element with filter and box-decoration-break:clone
** r+ | land
* {{bug|1290782}} - SVG border-image without viewport size and viewBox is broken when changing the opacity
** r?
* {{bug|1388985}} - css clip-path with basic-shape rendering should respect box-decoration-break
** WIP(suspend)


===Shing Lyu===
===Shing Lyu===


===Ting-Yu Lin===
===Ting-Yu Lin===
* {{bug|1382102}} RESOLVED::FIXED stylo: :nth-child() shouldn't match element inside XBL anonymous subtree
** Landed bug 1382102.
** Uploaded patches for bug 1382102.
* {{bug|1383845}} RESOLVED::FIXED Stylo: Windows debug reftests / crashtests fail with "Assertion failure: cachedBinding == aProtoBinding"
** Reviewed bug 1383845.
* {{bug|1390773}} RESOLVED::FIXED stylo: Move functions related to anonymous element to GeckoElement
** Filed bug 1390773, and uploaded a patch.


===Tommy Kuo===
===Tommy Kuo===
* {{bug|1384802}} RESOLVED::FIXED Stylo: Empty rules should still be returned by inIDOMUtils.getCSSStyleRules
** Landed (Bug 1384802)
* {{bug|1391198}} NEW:: stylo: The order of rules in DevTools on stylo are different to gecko.
** Analyze the root cause of the failure of browser_rules_custom.js and file bug (Bug 1391198)


===Ya-Chieh Wu===
===Ya-Chieh Wu===
* {{bug|1379038}} ASSIGNED:: Border Collapse causing 1px off
** Bug 1379038 f?
** Trace bug 1379038


==Rule of Thumb==
==Rule of Thumb==

Latest revision as of 06:18, 22 August 2017

Weekly Announcement

Weekly Sharing

Weekly Status

Astley Chen

  • bug 1294490 ASSIGNED:: Implement experimental WebP image support
    • Bug 1294490 - adding webcompat label as visual differences on youtube.com
  • bug 895096 NEW:: border-collapsed table borders have inconsistent widths when device pixel scale is not 1 (zoom)
    • Bug 895096 - triaged
  • bug 1389286 NEW:: Ruby layout doesn't play nice with ::first-line
    • Bug 1389286 - triaged

Boris Chiou

  • bug 1387951 RESOLVED::FIXED stylo: Make interpolation behavior of -moz-image-region with 'auto' value match with gecko
    • Reviewed bug 1387951 - stylo: Make interpolation behavior of -moz-image-region with 'auto' value match with gecko
  • bug 1387939 RESOLVED::FIXED stylo: Interpolation of "Integer or Auto" is incorrect in test_transitions_per_property.html
    • Reviewed bug 1387939 - stylo: Interpolation of "Integer or Auto" is incorrect in test_transitions_per_property.html
  • bug 1387990 ASSIGNED:: stylo: Many interpolations of transform are failed in test_transitions_per_property.html
    • Debugged and wrote some patches for bug 1387990 - stylo: Many interpolations of transform are failed in test_transitions_per_property.html
    • Wrote a stylo-only version of 2d matrix decomposition for Bug 1387990 - stylo: Many interpolations of transform are failed in test_transitions_per_property.html
    • Wrote a stylo-only version of 2d matrix decomposition for bug 1387990 - stylo: Many interpolations of transform are failed in test_transitions_per_property.html
  • bug 1389023 RESOLVED::FIXED stylo: The interpolation of perspective transform is not correct
    • Landed bug 1389023 - stylo: The interpolation of perspective transform is not correct
  • bug 1387973 RESOLVED::FIXED stylo: Some distance calculation and interpolated results are not correct for {box|text}-shadow in test_transitions_per_property.html
    • Reviewed bug 1387973 - Implement distance for shadow list.
  • bug 1389429 RESOLVED::FIXED stylo: The interpolations of rotatex and rotatey are not correct.
    • Landed bug 1389429 - stylo: The interpolations of rotatex and rotatey are not correct.
  • bug 1362896 RESOLVED::FIXED stylo: Implement compute_distance for TransformList
    • Landed bug 1362896 - stylo: Implement compute_distance for TransformList

Cameron McCormack

  • bug 1389300 RESOLVED::FIXED stylo: Crash in nsRuleNode::nsRuleNode
    • Reviewed bug 1389300
  • bug 1390255 RESOLVED::FIXED stylo: A few stylist-related cleanups.
    • Reviewed bug 1390255
  • bug 1385745 RESOLVED::FIXED Only first line is visible in inline element with filter and box-decoration-break:clone
    • Reviewed bug 1385745
  • bug 1373343 RESOLVED::FIXED stylo: Only do parallel traversals when the tab is foreground
    • Reviewed bug 1373343
  • bug 1367635 NEW:: stylo: consider caching style structs in the rule tree
    • Continuing to look at bug 1367635
    • Still working on bug 1367635; memory leak solved, still a few test failures left

CJ Ku

  • bug 1385745 RESOLVED::FIXED Only first line is visible in inline element with filter and box-decoration-break:clone
    • Bug 1385745 review test cases
  • bug 1389712 NEW:: switching to a Google Slides tab is slow (long repaint)
    • Bug 1389712 look into profile data
  • bug 1390088 ASSIGNED:: SVG within SVG (embedded) not displaying correctly in 56.0b2.
    • Bug 1390088 WIP
    • Bug 1390088 upload patches
  • bug 577824 RESOLVED::FIXED HTML element attached is not rendered if an SVG filter is applied to it
    • Bug 577824 landed
  • bug 1388985 ASSIGNED:: css clip-path with basic-shape rendering should respect box-decoration-break
    • Bug 1388985 patch reviewed
  • bug 1318266 RESOLVED::FIXED Draw trivial clip-path onto mask layer
    • Bug 1318266 fix reftest failure and reland
  • bug 852100 UNCONFIRMED:: SVG filters may shift and blur elements in embedded image
    • Bug 852100 upload patch

Eric Tsai

Farmer Tseng

  • bug 1388951 RESOLVED::FIXED [PDF gtest] Compare EMF contents with reference
    • Landed, Bug 1388951
    • Uploaded patch and r? on Bug 1388951
  • bug 1382509 ASSIGNED:: Build PDFium as a separate library instead of linking it into libxul
    • Limit the exporting symbols, uploaded patch and r? on Bug 1382509

Jeremy Chen

  • bug 1391178 NEW:: Scrolling in a popup should not cause scrolling in its underlying content
    • Filed Bug 1391178
  • bug 1375332 ASSIGNED:: stylo: font-size doesn't always respond to language-specific minimum size when using charset-derived language
    • Updated debug progress [Bug 1375332]
    • Updated patches to fix couple try failures [Bug 1375332]
    • Uploaded patches for review [Bug 1375332]
  • bug 1387982 RESOLVED::FIXED stylo: The interpolation between drop-shadow functions without specified color is wrong
    • Landed Bug 1387982
    • Uploaded patch for review [Bug 1387982]

Louis Chang

  • bug 1352238 - Implement a native theme for checkbox/radio form controls on Android
    • WIP
  • bug 1385745 - Only first line is visible in inline element with filter and box-decoration-break:clone
    • r+ | land
  • bug 1290782 - SVG border-image without viewport size and viewBox is broken when changing the opacity
    • r?
  • bug 1388985 - css clip-path with basic-shape rendering should respect box-decoration-break
    • WIP(suspend)

Shing Lyu

Ting-Yu Lin

  • bug 1382102 RESOLVED::FIXED stylo: :nth-child() shouldn't match element inside XBL anonymous subtree
    • Landed bug 1382102.
    • Uploaded patches for bug 1382102.
  • bug 1383845 RESOLVED::FIXED Stylo: Windows debug reftests / crashtests fail with "Assertion failure: cachedBinding == aProtoBinding"
    • Reviewed bug 1383845.
  • bug 1390773 RESOLVED::FIXED stylo: Move functions related to anonymous element to GeckoElement
    • Filed bug 1390773, and uploaded a patch.

Tommy Kuo

  • bug 1384802 RESOLVED::FIXED Stylo: Empty rules should still be returned by inIDOMUtils.getCSSStyleRules
    • Landed (Bug 1384802)
  • bug 1391198 NEW:: stylo: The order of rules in DevTools on stylo are different to gecko.
    • Analyze the root cause of the failure of browser_rules_custom.js and file bug (Bug 1391198)

Ya-Chieh Wu

  • bug 1379038 ASSIGNED:: Border Collapse causing 1px off
    • Bug 1379038 f?
    • Trace bug 1379038

Rule of Thumb

Status code:

  • OOAD: In analysis or design phase.
  • WIP: working on WIP patch.
  • feedback(f): feedback a patch
  • feedback?(f?): WIP is ready for feedback grant.
  • feedback+(f+): Get positive feedback.
  • feedback-(f-): Get negative feedback.
  • review(r): review a patch.
  • review?(r?): patch is under review
  • review+(r+): get review+ and ready to check-in
  • review-(r-): get negative review feedback. Fix problems and switch back to r? again.
  • land: patch check in.
  • debug: Figure out the root cause of a bug/ try to repro that bug, etc...
  • file: file a bug
  • PTO: take personal leave
  • interview(I)
  • study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
  • presentation
    • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
    • WIKI/ MDN article writing.
    • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
    • Do a presentation of technical topics