|
|
| (11 intermediate revisions by the same user not shown) |
| Line 1: |
Line 1: |
| '''Oxidation''' is a project to integrate [https://www.rust-lang.org/ Rust] code in and around Firefox.
| | Please see [[Oxidation]]. |
| | |
| Rust support has been required on all platforms since Firefox 54, and the first major Rust components were shipped in Firefox 56 (encoding_rs) and 57 (Stylo). Moving forward, the goal of Oxidation is to make it easier and more pleasant to use Rust in Firefox, and correspondingly to increase the amount of Rust code in Firefox.
| |
| | |
| This page is intended to serve as the starting point for all matters relating to Rust code in Firefox -- the what, the why, and the how.
| |
| | |
| = Guidelines =
| |
| | |
| The goal of this section is to provide some high-level guidelines about Rust usage. Choice of language is an engineering decision, with corresponding trade-offs, and is best decided by individual teams.
| |
| | |
| == Summary ==
| |
| | |
| When should Rust be used in Firefox? In summary:
| |
| * For new components and completely rewritten components there should be a strong bias towards using Rust, especially for code around Firefox but not within Firefox.
| |
| * For existing components it's more complicated!
| |
| | |
| == Rust Strengths ==
| |
| | |
| Rust has the following strengths.
| |
| * Memory safety, which prevents crashes and security vulnerabilities.
| |
| * Thread safety, which enables parallel performance.
| |
| * High expressiveness.
| |
| * A great community.
| |
| | |
| == Rust Weaknesses ==
| |
| | |
| One major issue with Rust relates to personnel. There is a wide variety of experience levels within Mozilla, for both coding and reviewing. Also, Rust's learning curve is steep at the start, which can be intimidating.
| |
| | |
| There are also technical challenges.
| |
| * Compile times are currently slow.
| |
| * Crossing the C++/Rust boundary layer can be difficult, and is relatively slow due to no inlining.
| |
| ** Bindgen can be tricky, especially working around clang bugs in different versions and on different platforms
| |
| * Android is currently [https://forge.rust-lang.org/platform-support.html not a Tier 1 platform].
| |
| ** rillian: "As I understand it, the problem is no one has set up tests on a cloud service, so there's no way for upstream to gate work on Android regressions. Qemu emulation is too slow. There aren't many services with arm support, but there are a couple of new options. If someone does the work of setting something up we should be able to get the Rust team to adopt it."
| |
| * Integration with Gecko often requires adding wrapper/glue code. Such code is typically valuable and reusable, however.
| |
| * Sharing components between Gecko and Servo is difficult.
| |
| ** The workflow is annoying and inefficient. Furthermore, permission to land directly on autoland is sometimes needed to fix problems, but few people have that.
| |
| *** vcs-sync/Phabricator/Lando will hopefully fix this.
| |
| ** There are continuous integration mismatches.
| |
| ** Servo CI is potentially under-resourced.
| |
| ** This is not relevant for Gecko-only Rust components, however.
| |
| | |
| == Recommendations ==
| |
| | |
| Therefore, Rust is most suitable in the following situations.
| |
| * For components that are relatively standalone, with small and simple APIs.
| |
| ** This minimizes the C++/Rust boundary layer issues.
| |
| ** Infrastructure tools that are standalone programs are ideal.
| |
| ** Note that it's good sofware engineering practice to write loosely-coupled components anyway.
| |
| * For components that process untrusted input, e.g. parsers.
| |
| ** Rust's memory safety is a big help here.
| |
| ** See the [http://spw17.langsec.org/papers/chifflier-parsing-in-2017.pdf "Writing parsers like it is 2017"] paper for lots of good details.
| |
| * For components where parallelism can provide big performance wins.
| |
| * For components where Servo has demonstrated success.
| |
| | |
| In terms of structuring Rust crates, there are three options, from most-coupled to least-coupled.
| |
| * Put the crate in mozilla-central or in Servo's repository.
| |
| ** For binding code, the decision to put it into Gecko or Servo can be difficult. The best choice depend on the details of the binding code in question.
| |
| * Put the crate somewhere else (e.g. a separate GitHub repository), and regularly vendor it into mozilla-central.
| |
| ** This works well if relatively few people are working on the crate, and the API isn't too complex.
| |
| ** Can be useful if useful development can be done using just that crate, without the rest of Gecko or Servo.
| |
| ** This is done by WebRender, for example.
| |
| * Put the crate somewhere else (e.g. [https://crates.io crates.io]), and use Cargo to access it at build-time.
| |
| ** This is only suitable for the most general of crates.
| |
| | |
| In general, erring on the side of tighter coupling is advisable. For example, the <tt>heapsize</tt> crate used in memory reporting was moved to crates.io, and then other crates came to depend on it. Later on it needed major API changes, and we ended up replacing it with a new crate called <tt>malloc_size_of</tt> (stored in Servo's repository) because that was easier than modifying <tt>heapsize</tt>.
| |
| | |
| = Documentation and Education =
| |
| | |
| == Rust in general ==
| |
| | |
| * The [https://www.rust-lang.org/en-US/documentation.html Rust Documentation] page is the best place to start. In particular, the [https://doc.rust-lang.org/book/ The Rust Programming Language] provides a good overview.
| |
| * [https://www.rust-lang.org/en-US/community.html The Rust Community] page lists IRC channels, forums, and other places where Rust assistance can be obtained.
| |
| * [http://shop.oreilly.com/product/0636920040385.do Programming Rust: Fast, Safe Systems Development], by Jim Blandy & Jason Orendorff, is a detailed guide to the language.
| |
| | |
| == Rust in Firefox ==
| |
| | |
| * [https://developer.mozilla.org/en-US/Firefox/Building_Firefox_with_Rust_code Developer Documentation]
| |
| * [https://firefox-source-docs.mozilla.org/build/buildsystem/rust.html Build System Documentation]
| |
| * [https://public.etherpad-mozilla.org/p/stylo Stylo workflow] (applies to any changes that straddle Gecko and Servo)
| |
| | |
| = Supported Rust versions for Firefox builds =
| |
| | |
| Below are [[Rust Update Policy for Firefox|our expectations]] if everything goes smoothly; we may need newer toolchains to address specific issues. Our ultimate policy is just that release Firefox will not require unstable or beta Rust to build.
| |
| | |
| * Firefox 56 (released 2017 September 26) requires Rust 1.17.0 or later.
| |
| ** Official builds will use Rust 1.19.0.
| |
| * Firefox 57 (released 2017 November 14) requires Rust 1.20.0.
| |
| ** Mozilla-central can start using Rust 1.19.0 language features 2017 August 3.
| |
| ** Mozilla-central can start using Rust 1.20.0 features 2017 September 14.
| |
| * Firefox 58 (released 2018 January 16) requires Rust 1.21.0.
| |
| ** Mozilla-central can use Rust 1.21.0 language features 2017 October 26.
| |
| * Firefox 59 (released 2018 March 6) requires Rust 1.22.0.
| |
| ** Mozilla-central can use Rust 1.22.0 features 2017 December 7.
| |
| ** Firefox 59 ESR is expected to continue to work with Rust 1.22 throughout its support lifetime.
| |
| * Firefox 60 (released 2018 May 1) requires Rust 1.23.0.
| |
| ** Mozilla-central can use Rust 1.23.0 features 2018 January 18.
| |
| * Firefox 61 (released 2018 June 26) requires Rust 1.25.0.
| |
| ** Mozilla-central can use Rust 1.24.0 features 2018 March 6.
| |
| ** Mozilla-central can use Rust 1.25.0 features 2018 April 12.
| |
| | |
| = Rust components in Firefox =
| |
| | |
| XXX: include rationales where appropriate
| |
| | |
| == Completed ==
| |
| | |
| * MP4 metadata parser: {{bug|1161350}} (shipped for desktop in Firefox 48)
| |
| ** Parses untrusted input, replaces libstagefright, a 3rd-party library with a history of security vulnerabilities
| |
| * Replace uconv with encoding-rs: {{bug|1261841}} (shipped in Firefox 56)
| |
| * CSS style calculation (from Servo): {{bug|stylo}} (shipped in Firefox 57)
| |
| ** Code taken from Servo, uses parallel algorithms
| |
| * U2F HID backend: {{bug|1388843}} (shipped in Firefox 57)
| |
| | |
| == In progress ==
| |
| | |
| * URL parser: {{bug|url-oxidation}}
| |
| * WebM demuxer: {{bug|1267492}}
| |
| * WebRender: {{bug|webrender}}
| |
| ** Code taken from Servo, has high performance; Rust's memory and thread safety provides protection against complexity
| |
| * Audio remoting for Linux: {{bug|1362220}}
| |
| * SDP parsing in WebRTC: {{bug|1365792}} (aiming for Firefox 59)
| |
| * Linebreaking with xi-unicode: {{bug|1290022}}
| |
| * Optimizing WebVM compiler backend: [https://github.com/stoklund/cretonne/ cretonne]
| |
| ** Well-separated component with a clear interface
| |
| | |
| == Proposed ==
| |
| | |
| * Parallel layout
| |
| ** Code from Servo
| |
| * Replace the XML parser
| |
| ** Parses untrusted input, replaces expat, a 3rd-party library with a history of security vulnerabilities
| |
| * WebMIDI: {{bug|1201593}}, {{bug|1201596}}, {{bug|1201598}}
| |
| * Gamepad code: {{bug|1286699}}
| |
| * Replace the telemetry module(?)
| |
| ** The existing C++ code has a history of threading problems
| |
| * Share media playback stack with Servo(?)
| |
| * Replace DOM serializers (XML, HTML for Save As.., plain text)
| |
| * Image decoders?
| |
| | |
| = Rust components outside Firefox =
| |
| | |
| == Completed ==
| |
| | |
| * GeckoDriver - WebDriver implementation for Firefox integrated via marionette protocol ({{bug|1340637}}) released as a standalone binary ([https://github.com/mozilla/geckodriver/releases releases])
| |
| | |
| = Blockers and obstacles =
| |
| | |
| - Identify and fix pain points that affect Rust integration.
| |
| | |
| == Raw Rust code (lives in m-c) blockers ==
| |
| | |
| * {{done|}} Top-level metabug: {{bug|oxidation}}
| |
| * {{done|}} Android support: {{bug|1220307}}
| |
| ** Though Android still not a Tier-1 Rust platform: https://forge.rust-lang.org/platform-support.html
| |
| * Linux distro support for Rust: [https://internals.rust-lang.org/t/perfecting-rust-packaging/2623]
| |
| * {{done|}} Need to improve call stacks: {{bug|1268328 }}
| |
| | |
| == Rust / Cargo nice-to-haves ==
| |
| | |
| * Tracking bug: Make the developer experience for Firefox + Rust great: {{Bug|rust-great}}
| |
| * Artifact caching [https://github.com/rust-lang/cargo/issues/1997]
| |
| * Shared Gecko/Servo components are painful
| |
| ** Landing/merging process
| |
| | |
| * Any remaining crash report issues? {{bug|1348896}}
| |
| * Debugging?
| |
| ** Tom Tromey is working on improving gdb and lldb support for Rust. The first step is to establish Rust language support in dwarf that is distinct from the C++ support we're currently using.
| |
| * IDE/symbol lookup support?
| |
| * Code coverage?
| |
| * Profiling?
| |
| ** Especially for parallel code
| |
| * Test integration?
| |
| | |
| == Things blocking new components from being written in Rust ==
| |
| | |
| * Bindings/interop
| |
| ** No IPDL binding generator
| |
| ** No WebIDL binding generator for dom components (Servo must have something here?)
| |
| ** No XPIDL binding generator ({{bug|1293362}}
| |
| ** Immature rust-bindgen and cheddar/cbindgen tools for general cross-language support.
| |
| * Slow compile times
| |
| ** Incremental compilation (XXX: tracking issue?)
| |
| ** [https://github.com/rust-lang/rust/pull/44841 ThinLTO]
| |
| ** [https://users.rust-lang.org/t/contract-opportunity-mozilla-distributed-compilation-cache-written-in-rust/13898 Distributed compilation cache]
| |
| * debugging stuff (ttromey)
| |
| | |
| = People =
| |
| | |
| * rillian: build system, other misc. stuff
| |
| * ttromey: debugging
| |
| * bz: everything
| |
| * froydnj: build system, integration
| |
| * ted: build system, crash reporting, releng
| |
| * emilio: Stylo
| |
| * Manishearth: Stylo
| |
| * jrmuizel or kats: gfx
| |
| * bholley: Stylo
| |
| * njn: high-level stuff
| |
| * fitzgen?: bindgen
| |
| * mystor?: bindings
| |
| * qdot?: webauthn integration
| |
| * rust compiler folks? acrichto, mwoerister
| |
| | |
| = Meetings =
| |
| | |
| * Mozlando [https://github.com/servo/servo/wiki/Mozlando-Oxidation]
| |
| * Oxidation Nov. 2015 [https://github.com/servo/servo/wiki/Oxidation-2015-11-05]
| |
| * Mozlandia [https://github.com/servo/servo/wiki/Mozlandia-Rust-In-Gecko]
| |
| * Whistler [https://github.com/servo/servo/wiki/Whistler-GFX#servo-in-gecko]
| |