canmove, Confirmed users, Bureaucrats and Sysops emeriti
4,747
edits
WebDriver/Meetings/2018-06-25: Difference between revisions
Henriks updates
(→Minutes: meeting structure discussion) |
(Henriks updates) |
||
| (7 intermediate revisions by one other user not shown) | |||
| Line 3: | Line 3: | ||
* Discussion | * Discussion | ||
** Meeting structure | ** Meeting structure | ||
** HTTP/1.1 Keep-Alive | ** HTTP/1.1 <code>Keep-Alive</code> connections | ||
** Building geckodriver offline | ** Building geckodriver offline | ||
** Building geckodriver on Windows/macOS | ** Building geckodriver on Windows/macOS | ||
* Status updates | * Status updates | ||
== | == Discussion == | ||
=== Meeting structure discussion === | === Meeting structure discussion === | ||
| Line 21: | Line 21: | ||
; ato | ; ato | ||
: | : Not sure what’s going on, but we have three fresh issues on GitHub that could be affected by the <code>Keep-Alive</code> change. | ||
: | ; whimboo | ||
: Not happy this landed before 0.21.0, we might have to revert it and release a patch. | |||
: Maybe gate it on a capability? | |||
; ato | |||
: Need to be set as HTTPD starts, so capability not a possibility. | |||
; whimboo | |||
: Where does the wait happen? In client or in server? | |||
; ato | |||
: My impression was that it happened in the client. They wait for ''N'' seconds, then after that the next command fails. | |||
: Question is, do we think this is caused by <code>Keep-Alive</code>? | |||
; whimboo | |||
: I would say so. | |||
; ato | |||
: Do we then back the change out and do a patch release? | |||
; whimboo | |||
: How many use this by default? | |||
; ato | |||
: If the client asks for it, the server provides I believe. There is a negotiation between the client and the server about capabilities. | |||
: It’s interesting that this only appears to happen in the Python client? | |||
; whimboo | |||
: From the trace-log I don’t see that the connection was closed. | |||
: Which versino of Python? Maybe only Python 3 related? | |||
; ato | |||
: There’s a lot of things to debug here. | |||
: Do we back out of leave it to stir another couple of days? | |||
; whimboo | |||
: Maybe leave it a little while longer. | |||
; ato | |||
: Yes, I suppose we don’t want to have to do a lot of work if it only impacts small number of people. | |||
; whimboo | |||
: Yes, let’s leave it and discuss with David via email | |||
Conclusions: | |||
* Leave patch in for the moment, observe how it affects users | |||
* Discuss with AutomatedTester | |||
* Triage on geckodriver issues, possibly dupe against old <code>Keep-Alive</code> request | |||
=== Building geckodriver offline === | |||
; whimboo | |||
: Unable to build geckodriver when changing dependencies. | |||
: But I was using "cargo build", I should be using "./mach build testing/geckodriver" | |||
: … but then that does not work with artifact builds | |||
=== Building geckodriver on macOS/Windows === | |||
; whimboo | |||
: Building on macOS in try still fails. I’ve needinfo’ed ted but he is on PTO. | |||
: I would like to have it in CI, but blocked by the linker not working. | |||
;ato | |||
: This is because of cross-compilation on macOS. | |||
: We are compiling it on Windows? | |||
; whimboo | |||
: Yes, but wdspec tests not working. | |||
: We are not transferring structured logs between processes? | |||
; ato | |||
: Is this something jgraham is aware of? | |||
; whimboo | |||
: Yes, and he replied to me. | |||
; ato | ; ato | ||
: '''Mentoring of jgraham’s interns while he is on PTO''' | : There’s also a bug on digitally signing Windows binaries. | ||
== Status updates == | |||
(Spoken status updates in bold.) | |||
* ato | |||
** '''Mentoring of jgraham’s interns while he is on PTO''' | |||
** '''Continued work on [https://bugzilla.mozilla.org/show_bug.cgi?id=marionette-window-tracking marionette-window-tracking]''' | |||
** Recognise WebWindow, ChromeElement, and WebFrame references in clients ([https://bugzilla.mozilla.org/show_bug.cgi?id=1408509 bug 1408509]) | |||
** Released geckodriver 0.21.0 ([https://bugzilla.mozilla.org/show_bug.cgi?id=1441204 bug 1441204]) | |||
** Making Marionette return recommended values for <code>platformName</code> ([https://bugzilla.mozilla.org/show_bug.cgi?id=1470646 bug 1470646]) | |||
** Prefix log messages from frame scripts with <code>outerWindowID</code> ([https://bugzilla.mozilla.org/show_bug.cgi?id=1464469 bug 1464469]) | |||
** Pretty-printing <code>[object Attr]</code> ([https://bugzilla.mozilla.org/show_bug.cgi?id=1469307 bug 1469307]) | |||
** Drop <code>ContentWebElement.LegacyIdentifier</code> ([https://bugzilla.mozilla.org/show_bug.cgi?id=1400233 bug 14002339]) | |||
= | * henrik | ||
** '''Made <code>input type=file</code> webdriver spec conforming''' | |||
** '''Disabled the download of the OpenH264 and Widevine video codec plugins by default for Marionette and geckodriver''' | |||
** '''Started to add user prompt wdspec tests for all commands including parametrization of tests to save hundreds of lines of just duplicated code. For now this is blocked on the refactoring of the 'new_session' fixture, which shouldn't start Firefox that often.''' | |||
** Backout of a focus regression since Firefox 25 which didn't let users change the browser window if "focusmanager.testmode" is enabled | |||
** Limited the numbers of preferences in prefs.rs to those which need a restart of Firefox | |||
== PTO/travel (🏖) == | |||
* ato away Wednesday 27th and Friday 29th | * ato away Wednesday 27th and Friday 29th | ||
* Henrik away from July 9th - July 20th | |||