Confirmed users
1,989
edits
Firefox/Python 3 Migration: Difference between revisions
m
→Port a Mach Command
(Added PSF statement about why upgrading is important) |
|||
| (3 intermediate revisions by the same user not shown) | |||
| Line 42: | Line 42: | ||
==== Remove more of the "excluded" paths from the py2 and py3 linters ==== | ==== Remove more of the "excluded" paths from the py2 and py3 linters ==== | ||
See [https://pad.mozilla.org/p/py3 this Etherpad] for instructions. | See [https://pad.mozilla.org/p/py3 this Etherpad] for instructions. (Etherpad is blank, needs to be fixed) | ||
Roughly: | Roughly: | ||
* Pick a directory [https://pad.mozilla.org/p/py3 from the list], and put your name beside it so we know it's ported | * Pick a directory [https://pad.mozilla.org/p/py3 from the list], and put your name beside it so we know it's ported (this etherpad is now blank, ask in #py3 for details) | ||
* Edit py2.yml and/or py3.yml and remove that directory from the exclusion list | * Edit py2.yml and/or py3.yml and remove that directory from the exclusion list (from tools/lint/py2.yml and tools/lint/py3.yml in https://hg.mozilla.org/mozilla-central/) | ||
* Run `./mach lint -l py2 -l py3 <your directory name>` to get a list of errors | * Run `./mach lint -l py2 -l py3 <your directory name>` to get a list of errors | ||
* To get a list of files that need fixing: | * To get a list of files that need fixing: | ||
| Line 76: | Line 76: | ||
==== Port a Mach Command ==== | ==== Port a Mach Command ==== | ||
The mach driver (toplevel `mach` file) contains a whitelist of commands that still run with Python 2. | The mach driver (toplevel `mach` file) contains a whitelist of commands that still run with Python 2. | ||
The whitelist contained in the mach command is py2commands | |||
py2commands=" | |||
addtest | |||
analyze | |||
android | |||
android-emulator | |||
artifact | |||
awsy-test | |||
bootstrap..." | |||
Pick the command that you'd like to convert and then: | |||
# Remove it from the whitelist | # Remove it from the whitelist | ||
# Run: ./mach <command> | # Run: ./mach <command> | ||