Features/Thunderbird/BigFiles: Difference between revisions

no edit summary
No edit summary
No edit summary
 
(40 intermediate revisions by 3 users not shown)
Line 1: Line 1:
{{FeatureStatus
{{FeatureStatus
|Feature name=Big Files
|Feature name=Big Files
|Feature stage=Planning
|Feature stage=Shipped
|Feature status=In progress
|Feature status=In progress
|Feature version=Thunderbird 13
|Feature version=Thunderbird 13
Line 62: Line 62:


We are also not, for this iteration, supporting the creation of multiple accounts with the same service provider. This will be addressed in a later version.
We are also not, for this iteration, supporting the creation of multiple accounts with the same service provider. This will be addressed in a later version.
|Feature security review=[https://wiki.mozilla.org/Security/Reviews/Thunderbird/BigFiles]
|Feature privacy review=[https://wiki.mozilla.org/Privacy/Reviews/ThunderbirdBigFiles]
|Feature implementation notes=The bug # for this feature is [https://bugzilla.mozilla.org/show_bug.cgi?id=698925 bug 698925]
Work is being done on [https://hg.mozilla.org/users/bienvenu_nventure.com/big-files this feature branch].
}}
}}
{{FeatureInfo
{{FeatureInfo
Line 74: Line 79:
''Milestone 1:''  (Feb 15th - Done [https://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/mconley@mozilla.com-60e014150094/ Feb 13th].)
''Milestone 1:''  (Feb 15th - Done [https://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/mconley@mozilla.com-60e014150094/ Feb 13th].)
(Includes Thunderlympics week.)
(Includes Thunderlympics week.)
* Go over wording.  (Jan 26th - Done Jan 26th)
* <strike>Go over wording.</strike> (Jan 26th - Done Jan 26th)
* Fix remove account dialog string (Feb 3rd - Done Feb 1st)
* <strike>Fix remove account dialog string</strike> (Feb 3rd - Done Feb 1st)
* Enable YouSendIt account registration (Done Feb 1st)
* <strike>Enable YouSendIt account registration</strike> (Done Feb 1st)
* Decide what happens if we've maxed out the available accounts, and try to add another one? (Feb 3 - Done Feb 1st)
* <strike>Decide what happens if we've maxed out the available accounts, and try to add another one?</strike> (Feb 3 - Done Feb 1st)
* Account Management.  (Feb 3rd - Done Feb 3rd)
* <strike>Account Management.</strike> (Feb 3rd - Done Feb 3rd)
** Spinner while waiting to authenticate. (Feb 3rd - Done Feb 3rd)
** <strike>Spinner while waiting to authenticate.</strike> (Feb 3rd - Done Feb 3rd)
** Fix quota numbers in management view for DropBox accounts (Feb 3rd - Done Feb 3rd)
** <strike>Fix quota numbers in management view for DropBox accounts</strike> (Feb 3rd - Done Feb 3rd)
** Go over add/remove button enabled states. (Feb 3rd - Done Feb 2nd.)
** <strike>Go over add/remove button enabled states.</strike> (Feb 3rd - Done Feb 2nd.)
** Add UI for authorizing an account after a failed auth attempt. (Feb 3rd)
** <strike>Add UI for authorizing an account after a failed auth attempt.</strike> (Feb 3rd)
* Add Account Dialog needs title on OS X and more explanation. (Feb 3rd - Done Feb 3rd)
* <strike>Add Account Dialog needs title on OS X and more explanation.</strike> (Feb 3rd - Done Feb 3rd)
* When suggesting to attach a big file, the notification bar says "Cancel". This should probably be something else, since "Cancel" suggests that it will revert the adding of the attachment, as opposed to opt-ing out of big-filing. (Done Feb 8th)  
* <strike>When suggesting to attach a big file, the notification bar says "Cancel". This should probably be something else, since "Cancel" suggests that it will revert the adding of the attachment, as opposed to opt-ing out of big-filing.</strike> (Done Feb 8th)  
* Some theming, and making it pretty.  (ongoing)
* <strike>Some theming, and making it pretty.</strike> (ongoing)
* Remove the "Need an Account?" link from the Add an Account dialog for Dropbox, since this option already exists in the OAuth window that Dropbox operates. (Feb 10th - done Feb 9th)
* <strike>Remove the "Need an Account?" link from the Add an Account dialog for Dropbox, since this option already exists in the OAuth window that Dropbox operates.</strike> (Feb 10th - done Feb 9th)
* Put the What's This text into the Add An Account dialog, and just get rid of the What's This button altogether. (Feb 10th - done Feb 9th)
* <strike>Put the What's This text into the Add An Account dialog, and just get rid of the What's This button altogether.</strike> (Feb 10th - done Feb 9th)
* "Use my Dropbox account", vs, just "Dropbox" in the dropdown menu. (Feb 10th - done Feb 10th)
* <strike>"Use my Dropbox account", vs, just "Dropbox" in the dropdown menu.</strike> (Feb 10th - done Feb 10th)
* How come my Dropbox oauth window is so small?  Why do I have to scroll? Let's just make it bigger for now. (Feb 10th - done Feb 10th)
* <strike>How come my Dropbox oauth window is so small?  Why do I have to scroll? Let's just make it bigger for now.</strike> (Feb 10th - done Feb 10th)
* Make sure the provider icon not stretch in the richlist (done Feb 10)
* <strike>Make sure the provider icon not stretch in the richlist</strike> (done Feb 10)


''Milestone 2:''  (Feb 29th - we're going to be cutting this close...may go over)
''Milestone 2:''  (Feb 29th - we're going to be slipping to Friday.)
* Replace all usage of "DropBox" with "Dropbox" as per branding guidelines. (done Feb 14th)
* <strike>Replace all usage of "DropBox" with "Dropbox" as per branding guidelines.</strike> (done Feb 14th)
* Make "Outgoing" the default tab in the Attachments pane in the Preferences dialog. (done Feb 14th)
* <strike>Make "Outgoing" the default tab in the Attachments pane in the Preferences dialog.</strike> (done Feb 14th)
* Make links in management panels open up in the default browser (done Feb 15th)
* <strike>Make links in management panels open up in the default browser</strike> (done Feb 15th)
* Make it so that when adding a YouSendIt account, we don't have to reauth to view settings (done Feb 16th)
* <strike>Make it so that when adding a YouSendIt account, we don't have to reauth to view settings</strike> (done Feb 16th)
* We need a YouSendIt PNG icon. (done Feb 27th)
* <strike>We need a YouSendIt PNG icon.</strike> (done Feb 27th)
* Need to add Jb and Anne Marie to the DropBox testing group (done Feb 27th)
* <strike>Need to add Jb and Anne Marie to the DropBox testing group</strike> (done Feb 27th)
* We need UI for changing the file-size threshold for notifying about BigFiles. (done Feb 27th)
* <strike>We need UI for changing the file-size threshold for notifying about BigFiles.</strike> (done Feb 27th)
* Language corrections to the Add Account dialog (done Feb 27)
* <strike>Language corrections to the Add Account dialog</strike> (done Feb 27)
** Window title should be "Setup a new file sharing service" (done Feb 27)
** <strike>Window title should be "Setup a new file sharing service"</strike> (done Feb 27)
** Text should emphasize "share" over "attach" (done Feb 27)
** <strike>Text should emphasize "share" over "attach"</strike> (done Feb 27)
** Text should not explicitly mention storage providers (done Feb 27)
** <strike>Text should not explicitly mention storage providers</strike> (done Feb 27)
** "Select an account type" should be "Select a file sharing service" (done Feb 27)
** <strike>"Select an account type" should be "Select a file sharing service"</strike> (done Feb 27)
** "Add Account" button should be "Setup Account" (done Feb 27)
** <strike>"Add Account" button should be "Setup Account"</strike> (done Feb 27)
* OAuth Dialog Fixes (done Feb 27)
* <strike>OAuth Dialog Fixes</strike> (done Feb 27)
** Remove the header, and use an uneditable URL bar instead (to prevent phishing)
** Remove the header, and use an uneditable URL bar instead (to prevent phishing)
* The language of the notification bar should emphasize "share" over "attach" (done Feb 27)
* <strike>The language of the notification bar should emphasize "share" over "attach"</strike> (done Feb 27)
** Update the buttons to be "Share it", or "Attach it"?
** Update the buttons to be "Share it", or "Attach it"?
* Test creating a Dropbox account from the OAuth dialog (done Feb 27th - works)
* <strike>Test creating a Dropbox account from the OAuth dialog</strike> (done Feb 27th - works)
* Attachment URL Insertion (squib)
* <strike>We need a link to create YouSendIt accounts</strike> (done Feb 28th)
** We want to insert URLs at attachment upload completion time (done Feb 27th)
* <strike>Change URL insertion header "I've shared 3 attachments" to "I've shared 3 files with you"</strike> (done Feb 28th)
** We can wedge images in there via data-urls. (done Feb 27th)
* <strike>Attachment URL Insertion</strike> (Done Feb 29th)
** Add the feature advertisement text below the last item (done Feb 27th)
** <strike>We want to insert URLs at attachment upload completion time</strike> (done Feb 27th)
** We need to annotate the inserted URL with the filename, the storage service, etc, to make it clear that it's a link to a file on a cloud file provider. (See Google Docs file send/share emails for examples...or YouSendIt e-mails). (done Feb 27th)
** <strike>We can wedge images in there via data-urls</strike>. (done Feb 27th)
** Removing the cloud file attachment should remove the URL from the message. (done Feb 27th)
** <strike>Add the feature advertisement text below the last item</strike> (done Feb 27th)
* We need a link to create YouSendIt accounts (done Feb 28th)
** <strike>We need to annotate the inserted URL with the filename, the storage service, etc, to make it clear that it's a link to a file on a cloud file provider. (See Google Docs file send/share emails for examples...or YouSendIt e-mails).</strike> (done Feb 27th)
* Change URL insertion header "I've shared 3 attachments" to "I've shared 3 files with you" (done Feb 28th)
** <strike>Removing the cloud file attachment should remove the URL from the message.</strike> (done Feb 27th)
* Failure cases.  (Feb 29th)
* Failure cases.  (Feb 29th)
** Delete the cloud attachment when converting from cloud storage (done Feb 15th)
** <strike>Delete the cloud attachment when converting from cloud storage</strike> (done Feb 15th)
** Disallow conversion while an upload is happening (done Feb 4th)
** <strike>Disallow conversion while an upload is happening</strike> (done Feb 4th)
** Add a "stop upload" command? (done Feb 19th)
** <strike>Add a "stop upload" command?</strike> (done Feb 19th)
** Disallow drag-and-drop between compose windows (done Feb 16th)
** <strike>Disallow drag-and-drop between compose windows</strike> (done Feb 16th)
** Disallow send while upload is still in progress (done Feb 15th)
** <strike>Disallow send while upload is still in progress</strike> (done Feb 15th)
** Alert the user if deletion of a cloud attachment failed (done Feb 19th)
** <strike>Alert the user if deletion of a cloud attachment failed</strike> (done Feb 19th)
** External service starts sending garbage.
* <strike>More theming, and making it pretty.</strike> (ongoing)
** We can't log in for some reason
* <strike>When YSI tokens are stale, if we have remembered the password, we should try reauthenticating with it before prompting the user. </strike>(mconley)
* More theming, and making it pretty.  (ongoing)
** <strike>When getting user data</strike> (done Feb 28th)
* Canceling a message with cloud file attachments should delete the uploaded files from the server (may need to special case drafts and templates)
* Need to handle saving as draft and reloading drafts when there are cloud attachments. (bienvenu)
* When YSI tokens are stale, if we have remembered the password, we should try reauthenticating with it before prompting the user. (mconley)
** When getting user data (done Feb 28th)
** <del>When uploading a file</del> (Not needed, since user data is updated each time before a file is uploaded)
** <del>When uploading a file</del> (Not needed, since user data is updated each time before a file is uploaded)
** When deleting a file (delayed due to broken YSI API - might offload to milestone 3)
 


''Milestone 3:'' (Mar 9th)
''Milestone 3:'' (Mar 9th)
* <strike>Fix attachment URL insertion on replies to BigFiles mail. (mconley)</strike> (Done March 5th)
* <strike>Allow each provider to provide a homepage link (mconley)</strike> (Done March 5th)
* <strike>Move account prefs from mail.cloud_files.* to mail.cloud_files.accounts.* (mconley)</strike> (Done March 5th)
* <strike>Make feature pref-offable. (mconley)</strike> (Done March 5th)
* <strike>Find a better place to store oauth tokens than prefs (mconley)</strike> (Done March 5th)
* <strike>When YSI tokens are stale, if we have remembered the password, try reauthenticating the user automatically before prompting</strike>
** <strike>When deleting a file (mconley)</strike> (Done March 6th)
* <strike>Make footer link in HTML email URL attachments point to somewhere (mconley)</strike> (Done March 6th)
* <strike>Link underlines in HTML email don't match link colour (mconley)</strike>(Done March 6th)
* <strike>Fix YouSendIt recipients (currently pointing to dbienvenu) (mconley)</strike> (Done March 6th)
* <strike>Need to put Dropbox API key into production mode to increase testing exposure (bienvenu)</strike>
* <strike>Need to handle saving as draft and reloading drafts when there are cloud attachments. (bienvenu)</strike>
* <strike>Saving as Drafts bugs</strike>
** <strike>Attachment not listed in bucket on attach and save on draft (bienvenu)</strike>
*** <strike>Create a new message, and attach a cloud file</strike>
*** <strike>Save as a draft and close the compose window</strike>
*** <strike>Reopen the message, and attach another cloud file.</strike>
*** <strike>Save as a draft and close the compose window</strike>
*** <strike>Reopen the message - the second file is not listed in the bucket. Icon in inserted HTML URL might be broken.</strike>
* <strike>Improve activity feedback after manually authorizing in preferences dialog (mconley)</strike>
* <strike>Investigate weird behaviour with mixed attachment types</strike>
** <strike>Observed weird behaviour is the normal attachments being renamed on the receiver end</strike>
* <strike>Switch from global attachment nsIObserver events to window-specific DOM events (squib)</strike>
''Post-Landing:''
* Security and Privacy Reviews (Feb 29th-ish)  
* Security and Privacy Reviews (Feb 29th-ish)  
* Part of the notification text could be a link to an external "What's this" page.
* Spinner doesn't give enough information.  (Mar 9th)
** We can't determine upload progress using nsIRequestObserver, so satisfying this requirement would likely involve changing the nsIMsgCloudFileProvider interface, along with a bunch of our code. [https://bugzilla.mozilla.org/show_bug.cgi?id=736169 bug 736169]
* Part of the notification text could be a link to an external "What's this" page. [https://bugzilla.mozilla.org/show_bug.cgi?id=737348 bug 737348]
* Test that URL insertions happen in expected locations [https://bugzilla.mozilla.org/show_bug.cgi?id=736055 bug 736055]
* Fix layout for management panes on OSX [https://bugzilla.mozilla.org/show_bug.cgi?id=736155 bug 736155]
* Convert between different cloud providers  (mostly done)
* Convert between different cloud providers  (mostly done)
** Need to remove the old html link before adding the new one.
** Need to remove the old html link before adding the new one.
* More theming, and making it pretty.  (ongoing)
* More theming, and making it pretty.  (ongoing)
* Spinner doesn't give enough information.  (Mar 9th)
* Support drag-and-drop of cloud attachments between compose windows?
* Support drag-and-drop of cloud attachments between compose windows?
* Some tests are missing.  (As many as we can write before the deadline.)
** A lot of the UI tests.
** No fake provider.
** Testing with accounts other than mconley's.
* Whatever comes up from Anne-Marie's Milestone 2 User Testing.  (Unknown until we get more data.)
* Whatever comes up from Anne-Marie's Milestone 2 User Testing.  (Unknown until we get more data.)
* Find a better place to store oauth tokens than prefs
* I10n sweep (in particular, the Dropbox and YouSendIt management / settings iframe documents)
* I10n sweep (in particular, the Dropbox and YouSendIt management / settings iframe documents)
* TODO / XXX / FIXME sweep
* Make footer link in HTML email URL attachments point to somewhere
* Make each provider provide a homepage link
* Revisit themeing / colours for inserted attachments in HTML mail
* Revisit themeing / colours for inserted attachments in HTML mail
* Make feature pref-offable.
* Handle stale tokens for YouSendIt for uploading and deleting files
* Improve activity feedback after manually authorizing in preferences dialog
* Investigate using something other than the modal alert box on uploading/delete errors in the compose window
* Investigate using something other than the modal alert box on uploading/delete errors in the compose window
* Fix YouSendIt recipients (currently pointing to dbienvenu)
* Canceling a message with cloud file attachments should delete the uploaded files from the server (may need to special case drafts and templates)
* Use a better graphic to indicate "loading" in the main selected item panel in the preferences dialog when loading account information.
* Some tests are missing.  (As many as we can write before the deadline.)
** A lot of the UI tests.
** No fake provider.
** <strike>Testing with accounts other than mconley's.</strike>
** External service starts sending garbage.
** We can't log in for some reason
|Feature security status=sec-review-complete
|Feature security status=sec-review-complete
|Feature security health=OK
|Feature security health=OK
|Feature security notes=[[Security/Reviews/Thunderbird/BigFiles|Notes]]
|Feature security notes=[[Security/Reviews/Thunderbird/BigFiles|Notes]]
|Feature privacy notes=[[Privacy/Reviews/ThunderbirdBigFiles|Privacy/Reviews/ThunderbirdBigFiles]]
}}
}}
<div style="margin: 5px 0px 5px 0px; width: 300px; border: 1px solid green; padding: 5px; background-color: #CFC; text-align: center;">[[Talk:Features/Thunderbird/BigFiles | Contribute to this feature. ]]</div>
<div style="margin: 5px 0px 5px 0px; width: 300px; border: 1px solid green; padding: 5px; background-color: #CFC; text-align: center;">[[Talk:Features/Thunderbird/BigFiles | Contribute to this feature. ]]</div>
canmove, Confirmed users, Bureaucrats and Sysops emeriti
3,628

edits