Pancake Release 2012-07-04

Staging Release

Changes

• Merge
• Bumped version to force build
• fix spec files for build
• merge with default
• fix spec fiels for logstash and statsd. add optional dependencies for redis stats in pancake-common
• Add to wipe data messaging to indicate that you'll also be logged out. Fixes: https://bugzilla.mozilla.org/show_bug.cgi?id=768728
• #770634. Added basic fades to PostListView. Still needs a spinner, though.
• #770634. Added a fade build-in transition for drawer.
• Finished with branch.
• #766293. Merging branch retina-for-landing. Retina images for setup screens. Fixes #766293.
• #766293. Retina images for social icons and checkbox/+ icon. Side-note: we really need to replace the checkbox/+ icons.
• #766293. Added Retina image for Persona logo.
• #766293. Added Mozilla Labs logo image replacement with Retina counterpart.
• #766293. ImageOptim. Images are a fair bit smaller now.
• #766293. Added image replacement for the Mozilla Labs lockup.
• #766293. Instead of using an image tag, go retina with image replacement. This is the simplest possible thing that can work for now. Added image replacements for Pancake logo on/off
• Just some formatting cleanup.
• Merged latest from default
• Finished with branch
• Merged fix from show-viewer-for-already-open-stacks.
• #750836. Removed showViewer code from promise chain that is kicked off for toStackAndPlace. While this is a nice bottleneck to place it in, it is not always fired. If a navigate is issued for a route that is already active, nothing will happen (and rightly so). The problem is that showViewer is a side-effect that we want to happen regardless. Composed showViewer with router event handlers. For navigation triggered by click handlers, added call to showViewer.
• merge with default
• metlog-logstash distro does not depend on logstash
• Don't try to merge jquery in during the r.js build process
• Missing $ to jquery change
• Merge from default
• Support for Windows 8 Metro
• metlog-logstash bump
• merge with default
• metlog-logstash supervisor script
• metlog-logstash and petef-statsd supervisor scripts
• social cache control: private
• Updated all revisions to r160 to force building RPMs
• Explicitly assign the stacks as the collection property of the stack in augmentStacksWithStack, rather than leaving it as a side-effect of addTo. This heads off a logic problem where a stack can be stored without an associated collection ref, which leads to later issues. Refs: https://bugzilla.mozilla.org/show_bug.cgi?id=769418
• Clean up some console.log statements
• Make the whole list-item clickable for the logout and wipe buttons, as if you missed the <a> before you got no feedback and maybe it looked like it hung? Refs: https://bugzilla.mozilla.org/show_bug.cgi?id=769260
• Trim the traceback to exclude the ExportableError and friends
• Better serialization of error objects in objectTools.serializeObject, should avoid the double-stringified output
• merge with default
• updated default app configs for metlog
• Add a timeout to the account menu's logout handler, and ensure logged errors include the status (which might be 'timeout')
• Merge jquery branch to default
• #769498. Attempt to improve animation hiccups with large numbers of places by setting a short timeout.
• Oops again. Committed commented-out showViewer code. My sincere apologies.
• #769498. Removed fancy-pants z-index stuff in favor of a simple "add z-index, then remove it after animation complete" approach. This resolves a compositing issue with the shadow images in the accordion (at least for Chrome). I anticipate it will be generally faster, since all the elements have the same z-index.
• #768910. Actually, we're going to want to always scroll to a perfect 0.
• #768910. Added initial implementation for scrolling drawer to top.
• #769498. Merged design work from accordion-drawer-design. It is likely further rendering performance work will be necessary.
• Merged in latest from default. Resolved conflict in drawer.app.js.
• #769498. Re-enabled showViewer. Oops.
• #769498. Visuals for drawer are in place. Using pseudo-elements for top and bottom shadows on drawer items. This allows us to put opaque backgrounds on the elements themselves so we don't get overlapping text. The result performs OK in Chrome. May need to make performance adjustments for iOS.
• #769498. Improved drawer shadow for items.
• #769498. Getting close to matching tweaked comp. Updated sprite graphics, partial CSS.
• #769498. Updated background texture for drawer to darker variant. In practice, it turns out that we need more contrast to see the drawer animation happen against the sibling elements.
• #769498. Wait until stack closes before changing color back.
• #769498. Re-worked promise chain to separate open state from selected state in drawer.
• #769498. Decoupling open state from selected state. This allows us to give the drawer a selected state the moment you tap it. Good visual feedback. It also will allow us to give the stack a special treatment so you can actually see it move against the other items.
• #769498. Using new opaque images and sprite tiles.
• #769498. Added a couple of smaller paper images as a sprite. These images have recognizable flecks scrubbed out of them so they can tile at smaller sizes. They are also opaque so the browser isn't doing png 24 compositing. We use it for stacks and places to allow them to be opaque while animating.
• Image optim
• #769498. Changing out panels in this sprite for opaque graphics that have been composited in Photoshop. This avoids a lot of visual hiccups caused by the browser trying to composite and animate at the same time.
• #769498. Resolved style issue that was forcing us to use the 2px top offset.
• move pyzmq to optional install
• stats logging fix in social app
• merge with default
• actually capturing elapsed time in social
• Merge again
• Merge
• Just run the PromiseSpec in the dev spec runner
• Added a test to explore how chained handlers are treated when a promise is rejected.
• social app a singleton
• fix social not booting
• merge with default
• add statsd logging to social and search apps
• Re-throw a parse/process error on collections as a temp. measure, as rejecting the promise is not being handled as expected right now.
• Better fix for args handling in the assertion's orThrow method, unit tests pass again
• test for existence of stack.collection before calling reduce on it. Refs: https://bugzilla.mozilla.org/show_bug.cgi?id=769418
• Merge
• Catch collection processing errors and reject the fetch's promise
• Fix args we pass into the error constructor, should get us slightly better error logs
• merge with default
• add ability to obtain a user list
• Provide a default place_title as lattice rejects link requests without
• #769498. Initial work on drawer designs. Added sprite for drawer containing background images for drawer dividers. Background color fade for open drawer.
• #769498. Added js-open class to accordion groups when open. this will allow us to change the drawer style while opening.
• bug 747906, Newer TOS revision
• Fixing typo
• Merge from default
• bug 747906. Updating Terms of Service
• change copy to reflect that dates can change
• fix loading animation getting prematurely hidden away
• merge with default
• added ability to go back in time in admin dashboard
• Missed openssl-devel
• Add pydot
• fix packaging problem
• Bug 768569 - Please upgrade PhantomJS to 1.6
• Branch merged default; no longer in use
• Add in missing css rules for the empty search results message
• Merge empty-search-results branch: adds handling for empty search results with an EmptySearchResult view; makes the searchcollections' fetchDebounced return promises and handles not-found StackController fetches as success with empty results
• Ditch window.error listener for the browser - it obscures troubleshooting in the browser's dev tools
• Wire up the empty result view's 'goto' event handler to set the right state on the searchbar, and navigate as appropriate
• Fix incoming for the navigate issue, so revert to the 'Home' button targeting the #main route
• Added clear and focus methods to the searchbar's view
• Hook up the empty view button clicks: main-bb doesn't want to reload #main (hrm, we should be at #search/{terms} no?) so navigating to #topsites for now
• Merge latest from default
• Work in progress on handling empty search results. Implements a debounced fetch that returns a promise - and cancels pending fetches (or their promises anyhow)
• Simple view for empty search results
• Implement an ajax adapter to intercept lattice's stack/search 404 not-found responses and treat them as successful-but-empty results
• Add a container to the SearchTabsView for an empty results message
• Add a CancelledError class, for use in cancelled promises and other expected 'errors'
• Restore styles for the non-content container--pages (which include root/signin)
• Finished with branch
• #687508. Merged changes from social-no-title. Fixes #687508.
• Merged latest from default.
• #687508. Since we're using a different style for suggestions now, added a different classname for url match lists.
• #687508. Switched from separate templates to separate view objects for Posts and Status Updates. This is generally cleaner, and makes it easy to change the view used based on the service.
• #687508. Added service property to Twitter search results. This allows us to change the view used for this data.
• #687508. Added by-convention @ to Twitter usernames for search API.
• Use $.ajax instead of text
• jQuery's toggle function requires a boolean
• Switch to using jQuery by default
• bug 747906. Updating privacy policy
• #687508. Make username optional. If they don't have one, don't render the wrappers for it.
• #687508. Add service to the list of properties retained on the model.
• #687508. Better truncation. Check what character is at limit - 3 (for ellipsis), and keep walking back until we find a character that is not a space. Truncate there.
• #687508. So it turns out not returning a title for Twitter results causes some down-the-line problems, like needing a title for posting to Lattice. Since we're going to have to create a title via truncating the content at some point, it makes sense to do this on the server-side and pass it as place_title. This avoids a special code path for posting to Lattice w/o title. We'll just change the way Twitter items are displayed by switching view templates based on the 'service' parameter passed for each social item.
• nicer graphs in admin dashboard
• #687508. Added CSS for username. Slightly darker than in comp.
• #687508. Added basic username support to view.
• #687508. Parse the username field from JSON.
• #687508. Added styles for content--p2 (priority 2). It's a large-text varient of .post .content.
• #687508. Include Twitter username in JSON results. Append an @, since it's Twitter convention.
• search results fetched in admin dashboard when user comes back to the page
• #687508. PostView now has 2 different templates -- one for social items with titles, one for items without.
• #687508. Tweak to avatars for vertical alignment.
• #687508. Make posts a proper subcollection.
• #687508. Don't sub in URL for social item title. We want to know if we don't have a real title to work with.
• #758781. Limit number of suggestions to 5. Added associated tests for custom add method.
• #758781. Moved suggestions into right-hand column, per updated comp.
• #758781. Force urls to be single line. Use text-overflow-ellipsis to get nice text truncation when necessary.
• Merged in latest changes from default.
• admin dashboard user finder name change
• user graph finder in lattice admin dashboard
• merge with default
• nicer labels in /lattice/admin charts
• Fix for 766934 - Move feedback button to header on main page. Removed code to expose config as window.config as that is already setup.
• remove endOnTick for admin dashboard
• merge with default
• attributions for lua code, added hourly visit data for stats dashboard, and other dashboard improvements
• Add lib/logger and remoteexceptions logger to the common layer, so they'll be loaded always
• Comment fix
• Merge stackframe and filename/culprit fix from error-logging
• Fix stackframe defaults, use the first frame's filename if no filename can be retreived from the exception object
• Merge stack-frame defaults fix from error-logging
• Use a defaults object for all stack frames to ensure they get the required properties
• Merge of error-logging branch, which includes new logger architecture with logging observers, a remotelogger observer which sends errors+stacktraces to the server, a web.json is_debug -enabled toolbar to load the spec runners into the app. More work needed on stack trace collection
• Add test to ensure stack frames have a 'vars' property which is required at the serverside
• Merge latest from default
• Turns out lattice wants the linenos to be strings? Ok
• Don't re-stringify stringified objects when alerting errors
• Add a debug toolbar with links to the spec runners. It'll only show up if you have debug: true in your web.json settings file. Added error logging spec to SpecRunner
• Add logger as a common dependency. Note this requires we do the environment switches in the build config so the right version gets baked in
• Ensure logger and other core dependencies are loaded before attempting to load main-bb
• Coerce lineno in stack frames to be a number; fix test to accomodate variations in ReferenceError messages
• Fix for 766934 - Move feedback button to header on main page
• Fix for 766934 - Move feedback button to header on main page
• #748270. Change .media--ico-stack to avoid adding the icon class to places.
• Branch desperately out of date.
• Finished with branch
• #748270. Add people class when subtype is social. ImageOptim on icon sprite. Added CSS for person icon.
• #748270. Save subtype property to StackModel. It will allow us to customize the stack icon.
• Added missing ; Bring on the trolling.
• Fix case where getFilenameFromError sometimes can't find any kind of filename/url with a default <unknown> string so later indexOf checks don't error
• Merge latest from default
• logger plugin loading is via the module dependencies, so the environment-switched logger module has the plugins we want to load for that env. listenForUncaughtExceptions is now in the core logger class
• Fix orThrow method on assertion objects to create error class instances using the 'new' keyword- ensures we get the right instanceof behavior with the classes we have set up
• Add a check for the .d (results) property
• Add the logger instance as the .target property on logging events. Add listenForUncaughtExceptions as a method on the core logger
• Provide the window location as a default filename for the culprit (culprit is required on the server-side)
• Refactor noisy logger as a logging observer component; Rename raven logger component to remoteexceptions.
• Merge latest from default
• merge with default
• send timestamp of stats captured via metlog. this is moot for statsd since it does not record data in the past.
• Fix for 767982 - Twitter items showing up in chronological (rather than reverse chronological) order
• Ensure exceptions requests have site and timestamp fields. Add spec with ajax-spy to validate requests for logged exceptions using ported logic from ExceptionMessages' validate method
• Add type handling for null and undefined
• merge with default
• add logstash-metlog to dependencies
• Refactor to create an ExportableError class with all the traceback/stacktrace stuff bundled up in it. Fix bug in Firefox stack parsing where it was dealing with multiline entries
• Add target param to Component onDetach method (not yet used)
• Fix error in error test, BadModel now loads and the raiseMissingIdException methods does (mostly) what it says on the tin
• Merge latest from default
• Device info is only appended to /lattice/stats and /lattice/exception requests; module renamed to reflect its new function. Fixes: https://bugzilla.mozilla.org/show_bug.cgi?id=754268
• Merged latest from drawer-icons
• #748270. Did the simplest possible thing for rendering favicons: check for a favicon.ico in the root.
• #748270. Added retina icon to sprite, along with CSS.
• Merged in latest from default>
• Merged latest from default
• Open the place in the viewer immediately. Then handle the stack move animation afterwards.
• Fixing example web.json config file
• #748270. Added icon sprite and basic styles for stack icon.
• version bumps
• Add the 'module' key to stack frames where possible
• Test model class that should throw an exception
• remote error logger plugin ('raven' .. will probably rename)
• Wire up the error+stacktrace handling and remote logging for the browser environment
• Refactor timestamp module to be a bit clearer
• Use /lattice/exceptions as the endpoint for logging exceptions
• milliseconds instead of seconds for timestamps in /lattice/exceptions
• merge with default
• lattice exceptions api now takes ints as timestamps instead of iso formatted strings
• Implement environent-specific loggers using the new logging infrastructure
• Refactor, moving Component implementation into its own module
• Refactored logger and Component class to be more Backbone-y
• #766765. Removed extra logging.
• #766765. If the user has no stacks, the request for stacks from the server-side will return a 404 or 500. Recover by using the in-memory stack collection. This case happens for new users. Fixes #766765.
• #758781. Updated .container width for landscape + portrait. Fixed address font-style.
• #758781. Tweaked .container widths to make the content area an even 600px when in portrait (per comp). Updated thumbnail size in portrait as well.
• #758781. Merged typography changes from search-readability.
• Merged latest from default
• #758781. Tweak to byline margins. Aligns avatar with bottom of image for posts that have 2 lines.
• #758781. Now using antialiased font-smoothing. Much better.
• #758781. Tweaks to vertical margins.
• #758781. Initial rework of .post typography.
• #758781. Added post--result class to search results as a hook for specialized CSS.
• Done with branch
• merge with default
• bump package & release numbers
• #766208. Merged thumbnail reset fix from branch thumbnail-fix. Resolves #766208.
• Merged in latest from default.
• #766208. Handle reset events on thumbnailJobCollection. At least partially fixes issue.
• tornado-redis version bump
• remove readme in tornado-redis spec file
• bumped tornado-redis to 0.0.4
• remove dependency links in lattice setup.py
• lattice now depends on tornado-redis 0.0.4
• merge with default
• remote error logging in lattice
• New core logger, using event emitter and attach/attachee plugin component architecture. Work-in-progress
• Fix IdMissingError and IdDoesNotExistError to stash the id-at-fault on the 'identifier' property
• Merge latest from default
• New implementations for the existing error subclasses, to ensure we preserve properties of the vanilla Error where possible, but be instanceof Error and our subclass. Also adds support for captureStackTrace where implemeted
• #766208. Merged fix for faulty thumbnail logging from thumbnail-fix. This should reduce confusion about what is actually being loaded.
• Merged in latest from default.
• upgrade bitarray to 0.8.0
• merge with default
• merge with default
• update lattice rpm dependencies
• Send response status code along with the connection:change message, to allow us to put up a more informative user-facing message if necessary
• Only treat 0, 503 and 503 response codes as connection errors. Refs: https://bugzilla.mozilla.org/show_bug.cgi?id=684329
• Merge default/tip
• Failing tests for the error classes and error logging
• #766208. Fixed logging to reflect actual number of thumbnails ready. The previous logger relied on the mutation of the collection, which sometimes did not happen before the onSuccess handler was called. Confusing logging resulted.
• bug 759846, add labs branding to landing pages
• version bump for release
• Fix for 766226 - Allow site status (open/closed) to be configured through web.json
• adding metlog-raven as a dependency
• merge with default
• overhauled /lattice/stats api to send errors when stats are malformed. added exception logging api
• Merged branch drawer-perf
• Merged latest changes from default.

iOS Changes

• Fix for 769023 - Create App Store build profile
• Fixed two memory leaks
• Fix for 768454 - Deal with connectivity errors at app startup
• Button on network error page now uses the same style as the feedback button
• Fix for 766934 - Move feedback button to header on main page. Use username part of email address as the display name for UserVoice.
• Fix for 766934 - Move feedback button to header on main page
• 766934 - Move feedback button to header on main page
• Fix for 768301 - Account view should not scroll or bounce
• Fix for 766656 - Improve gesture to switch between main/drawer/browser
• Fix for 766237 - BrowserID Randomly shows an error page.
• Fix for 767097 - Pull to refresh should be disabled on the login screen
• Fix for 759848 - Add Pancake branding to the app