canmove, Confirmed users
409
edits
Build config: Difference between revisions
m
→When to ask for review
mNo edit summary |
|||
| Line 15: | Line 15: | ||
===When to ask for review=== | ===When to ask for review=== | ||
Please ask for build peer review as early as possible in a patch lifecycle, especially if you will be doing something new with the build system (such as introducing a new script that needs to run as part of the build). This helps ensure build peers won't be the long pole in the review process. | Please ask for build peer review as early as possible in a patch lifecycle, especially if you will be doing something new with the build system (such as introducing a new script that needs to run as part of the build). This helps ensure build peers won't be the long pole in the review process. Also, chances are that build system integration doesn't change too often during patch development and a build peer review can be carried forward to subsequent patch versions. | ||
If you are not receiving a timely review, try pinging other build peers on the bug or requesting attention in #build. If all else fails, contact the build config module owner and/or their manager. | If you are not receiving a timely review, try pinging other build peers on the bug or requesting attention in #build. If all else fails, contact the build config module owner and/or their manager. | ||