canmove, Confirmed users
409
edits
Build config: Difference between revisions
Jump to navigation
Jump to search
m
no edit summary
mNo edit summary |
mNo edit summary |
||
| Line 12: | Line 12: | ||
Make files can be complex and hard to understand. Doing something wrong can mean regressing build times or introducing required clobber builds. History has taught us that a watchful eye is necessary to ensure bad make files aren't introduced into the build system. | Make files can be complex and hard to understand. Doing something wrong can mean regressing build times or introducing required clobber builds. History has taught us that a watchful eye is necessary to ensure bad make files aren't introduced into the build system. | ||
===When to ask for review=== | |||
Please ask for build peer review as early as possible in a patch lifecycle, especially if you will be doing something new with the build system (such as introducing a new script that needs to run as part of the build). This helps ensure build peers won't be the long pole in the review process. | |||
If you are not receiving a timely review, try pinging other build peers on the bug or requesting attention in #build. If all else fails, contact the build config module owner and/or their manager. | |||