TPE-Layout/2017-08-08

Weekly Announcement

• 2017 Job Family Architecture 1.0 Released.
  • JFA 1.0

Weekly Status

Astley Chen

• bug 1385911 NEW:: SVG mask is broken on scroll
  • Bug 1385911 - regression patch found and ni?cku.
  • Bug 1385911 - regression window needed.
• bug 1385419 NEW:: Parent element stretches to submit input's line-height, rather than its also-specified height.
  • Bug 1385419 - webcompat issue, regression range found and ni?dbaron.
• bug 1385517 NEW:: inline-block/floated parent of <picture> with a srcset/2x on HiDPI monitor is twice as wide as the image
  • Bug 1385517 - regression hunting now.

Boris Chiou

• bug 1387986 NEW:: stylo: Some distance calculation and interpolated results are not correct for stroke-dasharray in test_transitions_per_property.html
  • Filed bug 1292283, bug 1369614, bug 1387939, bug 1387941, bug 1387946, bug 1387948, bug 1387949, bug 1387951, bug 1387952, bug 1387973, bug 1387982, bug 1387986, bug 1387990 for bug 1387080 - stylo: Pass all test cases in test_transitions_per_property.html
• bug 1292283 ASSIGNED:: stylo: Enable test_transitions_per_property.html
  • Filed bug 1292283, bug 1369614, bug 1387939, bug 1387941, bug 1387946, bug 1387948, bug 1387949, bug 1387951, bug 1387952, bug 1387973, bug 1387982, bug 1387986, bug 1387990 for bug 1387080 - stylo: Pass all test cases in test_transitions_per_property.html
• bug 1387952 NEW:: stylo: Interpolation of clip-path (BasicShape) is not correct in test_transitions_per_property.html
  • Filed bug 1292283, bug 1369614, bug 1387939, bug 1387941, bug 1387946, bug 1387948, bug 1387949, bug 1387951, bug 1387952, bug 1387973, bug 1387982, bug 1387986, bug 1387990 for bug 1387080 - stylo: Pass all test cases in test_transitions_per_property.html
• bug 1386864 RESOLVED::FIXED stylo: Assertion failure: IsResolved() (Resolve() must be called first), at /home/ikezoe/autoland/layout/style/nsStyleStruct.h:355
  • Investigated bug 1386864 - stylo: Assertion failure: IsResolved() (Resolve() must be called first), at /home/ikezoe/autoland/layout/style/nsStyleStruct.h:355
• bug 1384656 RESOLVED::FIXED stylo: We use nsStyleTransformMatrix, which can enter in nsRuleNode and assume that we use a Gecko style context.
  • Landed bug 1384656 - stylo: We use nsStyleTransformMatrix, which can enter in nsRuleNode and assume that we use a Gecko style context.
• bug 1387910 RESOLVED::FIXED stylo: getAnimations may return null for pseudo-element
  • Reviewed bug 1387910 - stylo: getAnimations may return null for pseudo-element
• bug 1369614 ASSIGNED:: stylo: Support animating between stroke-widths that have units and those that don't
  • Filed bug 1292283, bug 1369614, bug 1387939, bug 1387941, bug 1387946, bug 1387948, bug 1387949, bug 1387951, bug 1387952, bug 1387973, bug 1387982, bug 1387986, bug 1387990 for bug 1387080 - stylo: Pass all test cases in test_transitions_per_property.html
• bug 1387982 NEW:: stylo: The serialization of filter has unit but the expected value is unitless in test_transitions_per_property.html
  • Filed bug 1292283, bug 1369614, bug 1387939, bug 1387941, bug 1387946, bug 1387948, bug 1387949, bug 1387951, bug 1387952, bug 1387973, bug 1387982, bug 1387986, bug 1387990 for bug 1387080 - stylo: Pass all test cases in test_transitions_per_property.html
• bug 1387973 NEW:: stylo: Some distance calculation and interpolated results are not correct for {box|text}-shadow in test_transitions_per_property.html
  • Filed bug 1292283, bug 1369614, bug 1387939, bug 1387941, bug 1387946, bug 1387948, bug 1387949, bug 1387951, bug 1387952, bug 1387973, bug 1387982, bug 1387986, bug 1387990 for bug 1387080 - stylo: Pass all test cases in test_transitions_per_property.html
• bug 1387941 NEW:: stylo: There are lots of failures of scroll-snap-{destination, coordinate} in test_transitions_per_property.html
  • Filed bug 1292283, bug 1369614, bug 1387939, bug 1387941, bug 1387946, bug 1387948, bug 1387949, bug 1387951, bug 1387952, bug 1387973, bug 1387982, bug 1387986, bug 1387990 for bug 1387080 - stylo: Pass all test cases in test_transitions_per_property.html
• bug 1387939 NEW:: stylo: Interpolation of "Integer or Auto" is incorrect in test_transitions_per_property.html
  • Filed bug 1292283, bug 1369614, bug 1387939, bug 1387941, bug 1387946, bug 1387948, bug 1387949, bug 1387951, bug 1387952, bug 1387973, bug 1387982, bug 1387986, bug 1387990 for bug 1387080 - stylo: Pass all test cases in test_transitions_per_property.html
• bug 1387946 NEW:: stylo: The calc() computed values of {backgournd|mask}-{position|size} are not correct in test_transitions_per_property.html
  • Filed bug 1292283, bug 1369614, bug 1387939, bug 1387941, bug 1387946, bug 1387948, bug 1387949, bug 1387951, bug 1387952, bug 1387973, bug 1387982, bug 1387986, bug 1387990 for bug 1387080 - stylo: Pass all test cases in test_transitions_per_property.html
• bug 1387080 NEW:: stylo: Pass all test cases in test_transitions_per_property.html
  • Filed bug 1292283, bug 1369614, bug 1387939, bug 1387941, bug 1387946, bug 1387948, bug 1387949, bug 1387951, bug 1387952, bug 1387973, bug 1387982, bug 1387986, bug 1387990 for bug 1387080 - stylo: Pass all test cases in test_transitions_per_property.html
• bug 1387948 NEW:: stylo: Interpolation of font-weight is not correct in test_transitions_per_property.html
  • Filed bug 1292283, bug 1369614, bug 1387939, bug 1387941, bug 1387946, bug 1387948, bug 1387949, bug 1387951, bug 1387952, bug 1387973, bug 1387982, bug 1387986, bug 1387990 for bug 1387080 - stylo: Pass all test cases in test_transitions_per_property.html
• bug 1387667 NEW:: stylo: Add the style backend flag to ProcessMatrixOperator
  • Filed bug 1387667 - stylo: Add the style backend flag to ProcessMatrixOperator
• bug 1387949 NEW:: stylo: Interpolation of "vertical-align" is not correct in test_transitions_per_property.html
  • Filed bug 1292283, bug 1369614, bug 1387939, bug 1387941, bug 1387946, bug 1387948, bug 1387949, bug 1387951, bug 1387952, bug 1387973, bug 1387982, bug 1387986, bug 1387990 for bug 1387080 - stylo: Pass all test cases in test_transitions_per_property.html
• bug 1387990 NEW:: stylo: Many interpolations of transform are failed in test_transitions_per_property.html
  • Filed bug 1292283, bug 1369614, bug 1387939, bug 1387941, bug 1387946, bug 1387948, bug 1387949, bug 1387951, bug 1387952, bug 1387973, bug 1387982, bug 1387986, bug 1387990 for bug 1387080 - stylo: Pass all test cases in test_transitions_per_property.html
• bug 1383998 RESOLVED::FIXED stylo: dom/animation/test/css-transitions/test_element-get-animations.html fails
  • Landed Bug 1383998 - stylo: dom/animation/test/css-transitions/test_element-get-animations.html fails
  • Landed bug 1383998 - stylo: dom/animation/test/css-transitions/test_element-get-animations.html fails
• bug 1387951 NEW:: stylo: Interpolation of ClipRectOrAuto or ColorOrAuto is not correct in test_transitions_per_property.html
  • Filed bug 1292283, bug 1369614, bug 1387939, bug 1387941, bug 1387946, bug 1387948, bug 1387949, bug 1387951, bug 1387952, bug 1387973, bug 1387982, bug 1387986, bug 1387990 for bug 1387080 - stylo: Pass all test cases in test_transitions_per_property.html
• bug 1385139 NEW:: stylo: CSS variables not resolved in values returned by getKeyframes()
  • Investigated bug 1385139 - stylo: CSS variables not resolved in values returned by getKeyframes()

Cameron McCormack

• Re-prioritized stylo bugs opened by me and TY
• bug 1387280 RESOLVED::INVALID stylo: Font metrics handling is killing us
  • Investigating bug 1387280
• bug 1386602 RESOLVED::FIXED stylo: We rebuild stylesheets most of the time when we don't need to when media query affecting values change.
  • Reviewed bug 1386602
• bug 1384824 RESOLVED::FIXED stylo: Crash in PLDHashTable::Add | mozilla::ArenaRefPtr<T>::assignFrom<T>
  • Uploaded WIP patch for bug 1384824
  • Uploaded patches for bug 1384824
  • Uploaded revised patches for bug 1384824
• bug 1381851 RESOLVED::FIXED Stylo: Flash click to play doesn't display on video elements when Stylo is enabled
  • Reviewed remaining parts of bug 1381851
• bug 1383998 RESOLVED::FIXED stylo: dom/animation/test/css-transitions/test_element-get-animations.html fails
  • Reviewed bug 1383998
• bug 1384741 ASSIGNED:: Stylo: incorrect CSP reports when layout.css.servo.enabled is true
  • Uploaded patches for bug 1384741
• bug 1386871 RESOLVED::FIXED stylo: May want to control font-display descriptor behind the pref
  • Reviewed bug 1386871
• bug 1384216 NEW:: stylo: Error messages for invalid selectors are really bad
  • Reviewed bug 1384216
• bug 1385896 RESOLVED::FIXED stylo: Move nsStyleContext::mParent to GeckoStyleContext.
  • Reviewed bug 1385896
• bug 1382925 ASSIGNED:: stylo: Keep the UA parts of the stylist across changes to document sheets
  • Submitted https://github.com/servo/servo/pull/17990 (first patch for bug 1382925)
• bug 1387481 RESOLVED::FIXED stylo: Assertion failure: MayTraverseFrom(const_cast<Element*>(aRoot))
  • Landed bug 1387481
• bug 1386865 RESOLVED::FIXED Stylo: DevTools test using XBL triggers "MOZ_ASSERT_UNREACHABLE: We should be able to map a raw rule to a rule"
  • Reviewed other patch in bug 1386865

CJ Ku

• bug 1385861 RESOLVED::FIXED Fine tune nsDisplaySVGText::Paint
  • Bug 1385861 landed
  • Bug 1385861 r?
• bug 1385929 NEW:: Find a way to prevent duplicate gfxContext::Save/Restore
  • Bug 1385929 WIP
  • Bug 1385929 r?
  • Bug 1385929 upload patches
• bug 1386218 ASSIGNED:: Remove gfxContext::HasComplexClip.
  • Bug 1386218 filed
  • Bug 1386218 upload patches
• bug 1386864 RESOLVED::FIXED stylo: Assertion failure: IsResolved() (Resolve() must be called first), at /home/ikezoe/autoland/layout/style/nsStyleStruct.h:355
  • Bug 1386864 landed
• bug 1386986 RESOLVED::FIXED Move nsDisplaySVGEffect::mEffectsBounds to nsDisplayFilter
  • Bug 1386986 file and upload a patch.
  • Bug 1386986 landed

Farmer Tseng

• bug 1382512 ASSIGNED:: [PDF gtest] convert EMF to bitmap and compare the bitmap content with reference
  • Refactor patch, uploaded to Bug 1382512
  • Uploaded patches, asked for feedback on Bug 1382512
• bug 1382509 ASSIGNED:: Pull out PDFium from xul
  • Uploaded patches, r? on Bug 1382509
• bug 1358076 ASSIGNED:: [PDF gtest] Implement unit test for PDFViaEMFPrintHelper
  • Uploaded patches, r? on Bug 1358076

Jeremy Chen

• bug 1367118 ASSIGNED:: stylo: investigate the disabled SVG related tests
  • Triaged, verified, and updated the status [Bug 1367118]
• bug 1375332 ASSIGNED:: stylo: font-size doesn't always respond to language-specific minimum size when using charset-derived language
  • Investigated Bug 1375332
  • Updated WIP and request for review [Bug 1375332]
  • Uploaded WIP and request for feedback [Bug 1375332]

Ting-Yu Lin

• bug 1381851 RESOLVED::FIXED Stylo: Flash click to play doesn't display on video elements when Stylo is enabled
  • Landed bug 1381851.
• bug 1386865 RESOLVED::FIXED Stylo: DevTools test using XBL triggers "MOZ_ASSERT_UNREACHABLE: We should be able to map a raw rule to a rule"
  • Reply needinfo for bug 1386865.
  • Reviewed bug 1386865.
• bug 1387926 RESOLVED::DUPLICATE The color refresh (loading) indicator is not obvious on light color theme (uses white instead of blue)
  • Filed bug 1387926.
• bug 1374902 NEW:: stylo: Have unprefixed :fullscreen pseudo-class guarded behind full-screen-api.unprefix.enabled
  • Reviewed bug 1374902.

Tommy Kuo

• bug 1377158 NEW:: stylo: Enable stylo for SVG-as-an-image.
  • Add new patch to reduce the cost of the assertion and ask to review (Bug 1377158)
  • Debug for the test failure of bc2 (bug 1377158)
  • Debug for the test failure of bc2 and update hash function and run a try (bug 1377158)
  • Test the patch from xidorn (bug 1377158)
  • Use hash table to store the change hint of content. (Bug 1377158)

Ya-Chieh Wu

• bug 1379306 ASSIGNED:: Position absolute not work as expected in table with border collapse
  • Bug 1379306 r?

Rule of Thumb

Status code:

• OOAD: In analysis or design phase.
• WIP: working on WIP patch.
• feedback(f): feedback a patch
• feedback?(f?): WIP is ready for feedback grant.
• feedback+(f+): Get positive feedback.
• feedback-(f-): Get negative feedback.
• review(r): review a patch.
• review?(r?): patch is under review
• review+(r+): get review+ and ready to check-in
• review-(r-): get negative review feedback. Fix problems and switch back to r? again.
• land: patch check in.
• debug: Figure out the root cause of a bug/ try to repro that bug, etc...
• file: file a bug
• PTO: take personal leave
• interview(I)
• study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
• presentation
  • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
  • WIKI/ MDN article writing.
  • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
  • Do a presentation of technical topics