Revision as of 20:54, 14 April 2010

Overview

Changes should follow the design guidelines for Jetpack
Changes must follow the code style guide for Jetpack
All changes must be accompanied by tests
In order to land, patches must have review from a core Jetpack developer
Patches should have additional API review when needed
Patches should have additional review from a Mozilla platform domain-expert when needed

If you have code that you'd like to contribute the Jetpack project, follow these steps:

Look for your issue in the bugs already filed
If no bug exists, file one here
Make your changes, per the Overview
Write a test (intro, API)
Attach your code changes and tests in a combined patch to the bug
Ask for code review by setting the "review" flag on your attachment to "?" and entering the email of one of the following:

For changes to the Jetpack core, ask Atul
For Mozilla platform usage, ask Drew, Myk or Dietrich (and they can find the domain expert)
For API and developer ergonomics review, ask Myk

@@ Line 14: / Line 14: @@
 # Look for your issue in the [https://bugzilla.mozilla.org/buglist.cgi?quicksearch=component%3Ajetpack bugs already filed]
 # If no bug exists, [https://bugzilla.mozilla.org/enter_bug.cgi?product=Mozilla%20Labs&component=Jetpack%20SDK file one here]
-# Make your changes, per the [https://wiki.mozilla.org/Labs/Jetpack/Design_Guidelines design guidelines]
+# Make your changes, per the [[Labs/Jetpack/Contribution#Overview|Overview]]
 # Write a test ([https://jetpack.mozillalabs.com/sdk/latest/docs/#guide/packaging intro], [https://jetpack.mozillalabs.com/sdk/latest/docs/#module/jetpack-core/unit-test API])
 # Attach your code changes and tests in a combined patch to the bug