canmove, Confirmed users, Bureaucrats and Sysops emeriti
3,628
edits
Tree Rules/comm-central: Difference between revisions
→Thunderbird: Add outline of current tree closure reasons/rules
(→Thunderbird: Add outline of current tree closure reasons/rules) |
|||
| Line 15: | Line 15: | ||
* mail/ | * mail/ | ||
* other-licenses/*/thunderbird/ | * other-licenses/*/thunderbird/ | ||
==== When does the tree get closed or changed to approval required? ===== | |||
The tree is closed when: | |||
* When there is multi-platform bustage | |||
* If there are too many test failures per suite, that makes it impossible to star accurately. | |||
** e.g. 10 or more xpcshell failures happening at the same time. | |||
The tree is approval required when: | |||
* There is perma-red or perma-orange on one or more platforms. | |||
* Approval is then generally required for landing patches, except bustage-fixes. | |||
* Approval is required because | |||
** Historically, people have been seen not to star oranges before and after landing, hence this needs checking and validating | |||
** Sometimes bustage is starred incorrectly | |||
* Approval should check: | |||
** The tree is starred | |||
** The patch is unlikely to affect the bustage areas (unless it is fixing them!) | |||
*** e.g. if Mac is busted, then landing a Mac-only patch isn't a good idea. A patch that doesn't have Mac specific parts is probably fine. | |||
=== SeaMonkey === | === SeaMonkey === | ||