139
edits
Media/WebRTC/Up-streaming Changes: Difference between revisions
Add Change-Id instructions
(Adding running tests, and skeleton) |
(Add Change-Id instructions) |
||
| Line 5: | Line 5: | ||
One can check that one has been successfully added [https://cla.developers.google.com/about/google-corporate here]. When you click "Manage your Agreements" at the bottom of the page should see that you have a Mozilla Corporate CLA listed. If you aren't already logged into a Google service, you will need to use [https://sso.mozilla.com Mozilla's SSO portal] to log in to gmail or any other google product. | One can check that one has been successfully added [https://cla.developers.google.com/about/google-corporate here]. When you click "Manage your Agreements" at the bottom of the page should see that you have a Mozilla Corporate CLA listed. If you aren't already logged into a Google service, you will need to use [https://sso.mozilla.com Mozilla's SSO portal] to log in to gmail or any other google product. | ||
===Installing Commit-Id Git Commit Hook Plugin=== | |||
In order to push patch stacks (instead of squashing), one needs to have a Git commit hook installed to correlate the stack patches using a Change-Id. | |||
* To install the commit hook follow the instructions [https://gerrit-review.googlesource.com/Documentation/cmd-hook-commit-msg.html here]. | |||
* The Change-Id Docs can be found [https://gerrit-review.googlesource.com/Documentation/user-changeid.html here]. | |||
* | |||
===Checking Out The Source=== | |||
* Use the instructions [https://webrtc.github.io/webrtc-org/native-code/development/#getting-the-code here] to checkout the upstream repo if you have not already. | * Use the instructions [https://webrtc.github.io/webrtc-org/native-code/development/#getting-the-code here] to checkout the upstream repo if you have not already. | ||
==Running Tests== | ==Running Tests== | ||
* While [https://www.chromium.org/developers/testing/running-tests/ these instructions] are for running Chromium tests, the same process applies for libwebrtc. There is no facility to help you run all the tests, you need to run all the test binaries that are produced. There are no facilities for helping you identify which tests you should be running. | * While [https://www.chromium.org/developers/testing/running-tests/ these instructions] are for running Chromium tests, the same process applies for libwebrtc. There is no facility to help you run all the tests, you need to run all the test binaries that are produced. There are no facilities for helping you identify which tests you should be running. | ||
==Submitting Code== | ==Submitting Code== | ||
==Opening An up-stream Bug=== | |||
* libwebrtc uses [http://webrtc-review.googlesource.com/ this Gerrit instance] to track bugs. | |||
===Submitting An up-stream Patch=== | ===Submitting An up-stream Patch=== | ||
===Requesting A Reviewer=== | ===Requesting A Reviewer=== | ||