Confirmed users
632
edits
Webrtc/checkin policy: Difference between revisions
no edit summary
No edit summary |
No edit summary |
||
| Line 6: | Line 6: | ||
1. Run mochitests/crashtests on your machine | == 1. Run mochitests/crashtests on your machine == | ||
You'll want to (clobber) rebuild Firefox with the following environment variable exported, e.g. in your mozconfig file: | You'll want to (clobber) rebuild Firefox with the following environment variable exported, e.g. in your mozconfig file: | ||
| Line 35: | Line 35: | ||
If you have no failures on your machine, then your code is probably fine to check in and you can skip to Step 3. If you want to have maximum confidence, then send it to Try as explained in Step 2. Try is your friend. :-) However, Step 2 (pushing to Try) could take a while (perhaps a couple of hours). | If you have no failures on your machine, then your code is probably fine to check in and you can skip to Step 3. If you want to have maximum confidence, then send it to Try as explained in Step 2. Try is your friend. :-) However, Step 2 (pushing to Try) could take a while (perhaps a couple of hours). | ||
2. Push to Try on Alder | == 2. Push to Try on Alder == | ||
If you're not in a hurry and pretty sure it will "just work", you can skip Step 1 and just push your patch to Try on Alder. Alder builds will always run the tests, and they have leak checks disabled for now. (Our tests are disabled on mozilla-central until all the leaks are plugged.) | If you're not in a hurry and pretty sure it will "just work", you can skip Step 1 and just push your patch to Try on Alder. Alder builds will always run the tests, and they have leak checks disabled for now. (Our tests are disabled on mozilla-central until all the leaks are plugged.) | ||
| Line 43: | Line 43: | ||
NOTE (same as note in Step 1): If your Try push fails, please investigate and fix the problems if you can or reach out for help in #media. Typically jesup or mreavy in #media can help or find someone to help. If neither of them is there (pretty rare!), just ask your question in the channel. Someone will help. Please don't commit if mochitests or crashtests fail; it is likely you'll just be asked to back out the patch. | NOTE (same as note in Step 1): If your Try push fails, please investigate and fix the problems if you can or reach out for help in #media. Typically jesup or mreavy in #media can help or find someone to help. If neither of them is there (pretty rare!), just ask your question in the channel. Someone will help. Please don't commit if mochitests or crashtests fail; it is likely you'll just be asked to back out the patch. | ||
3. If you have successfully completed Step 1 and/or Step 2 and your patch has gotten an r+ (successful review), you can land it on mozilla-inbound or directly on mozilla-central with confidence that it ''should'' work. ;-) | == 3. Land the Patch == | ||
If you have successfully completed Step 1 and/or Step 2 and your patch has gotten an r+ (successful review), you can land it on mozilla-inbound or directly on mozilla-central with confidence that it ''should'' work. ;-) | |||
'''Most importantly: Thanks so much for contributing to WebRTC! It is much appreciated!!''' | '''Most importantly: Thanks so much for contributing to WebRTC! It is much appreciated!!''' | ||