Confirmed users
291
edits
Gaia/SMS/Scrum/2.1S4: Difference between revisions
→Day 4: 5th September
Steveck324 (talk | contribs) |
Steveck324 (talk | contribs) |
||
| Line 147: | Line 147: | ||
=== Day 4: 5th September === | === Day 4: 5th September === | ||
====Steve==== | |||
* {{Bug|1048841}} - [Messages] investigate performance hit from IndexedDB at startup (eg: Contact lookup) | |||
** Waiting for the QC's reply. If they takes the gecko patch, we might need to provide the corresponding gaia patch to fix the profiling result | |||
* {{Bug|983172}} - Parsing jpeg header information for downsampling the image for thumbnail | |||
** Missing one image asset, and visual will update later. Trying to clean up the original hard-coded js styling as possible. | |||
**: (Oleg) yeah, that would be great! | |||
Bunch of review | |||
* Still on the reviews, has some concern in Eitan a11y's patch. Just thought that we create many element in JS runtime, and seems like we need to revisit this part in the future. | |||
Today: | |||
* Create patch for {{Bug|983172}} | |||
* I owe many reviews from Oleg, time to clean them up :p | |||
*: (Oleg) no worries! :) | |||
Next week: | |||
* Might take PTO for almost a week for some personal matter(you know that), I will still take review in the limited time, but might not able to send more patch :( | |||
====Oleg==== | |||
* {{Bug|1061710}} - [Flame][SMS] Unable to send sms | |||
** Looks like the patch that intended to fix this is landed, will check once it appears on pvt. | |||
* {{Bug|1061215}} - [Messages][Refactoring] Improve handling of remaining chars counter | |||
** Prepared patch and asked for low-priority review (in review). | |||
* {{Bug|1053964}} - [Messages][Tests] Add marionette JS test case to verify close\back button behaviour when app is in activity mode | |||
** Added last fix with contenteditable=true as Steve noted and landed (landed). | |||
* {{Bug|1063043}} - send button doesn't work when keyboard is open | |||
** It's actually true when we tap not in the button center, will try to find out what is the reason, keyboard or some sort of click fluffing problem maybe. | |||
*: (Steve) I remember we seems doing some preventDefault action in send button to prevent keyboard dismiss on click long time ago... it seems like a workaround but maybe I'm wrong | |||
*: (Oleg) Ok, thanks for pointer! Will look into that too | |||
*: (Steve) Maybe I'm just wrong. Is it really hard to tap the send button? Since our send button is a little bit smaller then before | |||
*: (Oleg) I guess it's just habit, I always tap in center, so it didn't bother me before and now :) | |||
*: (Steve) If Dietrich is tapping on the "button container" but not button, maybe we could enlarge the button size for usability, but we need to confirm it first. | |||
*: (Oleg) The only thing that is strange and I'd like to confirm with reporter is, if he taps on the same area when keyboard is visible and when it's not. I assume that he's talking about the same area, if it's not because keyboard's iframe then it's something wrong in SMS. If I tap on bottom right corner for example when keyboard is shown - keyboard just becomes hidden, when I tap on the same area when keyboard is not visible, then it works as expected. I made preliminary debugging and don't see that click is fired on our button at all, maybe keyboard is capturing it somehow. don't know :) Just ideas. It's fine for Email, because button isn't too close to keyboard. The same is for Add attachment button | |||
*: (Steve) Will talk to kb owner then. | |||
*: (Oleg) Oh, cool, is he also in Taipei? :) Also just for the record (maybe not useful at all :)) if you debug keyboard app with Web IDE and select row-0 - web inspector shows it's boundary that a bit overlap our buttons, maybe it doesn't matter | |||
Today: | |||
* Will handle review comments for the patches that currently in review; | |||
* Noticed that send button didn't work in browser - will take a look, I see exception from shared date helper about mozSettings, will check if it's related. | |||
====Julien==== | |||
* Absent/no report | |||
=== Day 5: 8th September === | === Day 5: 8th September === | ||