Confirmed users
291
edits
Gaia/SMS/Scrum/2.1S4: Difference between revisions
→Day 10: 15th September
Steveck324 (talk | contribs) |
Steveck324 (talk | contribs) |
||
| Line 362: | Line 362: | ||
=== Day 10: 15th September === | === Day 10: 15th September === | ||
====Steve==== | |||
* {{Bug|983172}} - Parsing jpeg header information for downsampling the image for thumbnail | |||
** Reviewed and landed. | |||
* {{Bug|1058459}} - [SMS] Data shared from other applications are not shown as Drafts until the app is killed and open again | |||
** Reviewing the SharedWorker patch(and it's brilliant!) will leave some comments later and give it a try | |||
* {{Bug|1059233}} - [SMS] User cannot view the cropped image in SMS application and ActivityCanceled error was shown when try to view | |||
** Reviewed and landed. create a follow up about the blob checking for the refinement. | |||
* {{Bug|1067232}} - [SMS] Avoid to make a private memory copy for file based blob | |||
** We should only make a copy for non-file based blob, but have no idea how to write a test for it :-/ | |||
**: (Julien) you can ask bent or baku on IRC maybe. (baku in european timezone, bent in US timezone) | |||
**: (Steve) Ok, maybe baku is more easier for me. | |||
* {{Bug|1061417}} - [SMS] We don't properly discard the draft in some occasions | |||
** Start to investigate it today. | |||
**: (Julien) I think we don't remove the "ThreadUI.draft" properly somewhere. That said if we have some time we might want to review the use of this property at all. | |||
**: (Steve) Yes, we just have another issue about ThreadUI.draft not removed properly at some moment, maybe it's a good chance to revisit it and remove this property | |||
Today: | |||
* Investigate {{Bug|1061417}} and {{Bug|1059233}} | |||
* Feedback for {{Bug|1058459}} and other reviews | |||
====Julien==== | |||
* will read the mails and try to update some bugs | |||
====Oleg==== | |||
* {{Bug|1067228}} - [Messages][Refactoring] Move subject management to a separate component | |||
** Analyzed what we need to make Composer as separate (web)component to share it between ThreadUI and Compose panels. Looks like just separating Subject from Thread UI deserves separate task - filed a non-critical bug. | |||
** Tried to use web components for that - basically it looks great in terms of granularity and encapsulation, but contenteditable doesn't work inside Shadow DOM currently (both subject and message input based on it), filed a bug for that. In the meantime we can separate without web components and migrate to it later if required - after separation it won't take much time. | |||
** + Wilson filed a bug to DevTools, so that we can inspect shadow DOM with DevTools, currently it's possible only with DOM Inspector plugin - well it's hard and not handy. | |||
**: (Julien) yeah, let's not push too hard on web components while it's not handy to use :/ but it's good to experiment to fix the bugs, so thanks for this :) | |||
* {{Bug|1063970}} - [Messages][Refresh] Update styles of phone and url links located inside messages | |||
** Landed (landed). | |||
Today: | |||
* Will handle review comments for the patches that currently in review; | |||
* Will pick up new bug | |||
== Demos == | == Demos == | ||
== Retrospective == | == Retrospective == | ||