234
edits
User:Sspitzer/GlobalFrecency: Difference between revisions
Jump to navigation
Jump to search
User:Sspitzer/GlobalFrecency (view source)
Revision as of 21:33, 29 December 2007
, 29 December 2007no edit summary
No edit summary |
No edit summary |
||
| Line 38: | Line 38: | ||
we recalc twice on idle, one for invalid and one for old frecencies. need marco's last_visit_date change to make old work right, or do a subquery until then. right now, we are going to recalc the same places over and over. (if we do a sub query, watch out for performance) | we recalc twice on idle, one for invalid and one for old frecencies. need marco's last_visit_date change to make old work right, or do a subquery until then. right now, we are going to recalc the same places over and over. (if we do a sub query, watch out for performance) | ||
recalculating for invalid (frecency == -1) is for firefox 2 / 3b2 -> b3 | |||
recalculating for old frecencies is for the ebay problem (https://bugzilla.mozilla.org/show_bug.cgi?id=394038#c19) | |||
to solve the ebay problem, we should also recalc the moz_places with high frecency and "old" last visit date. (In another patch, marco has added last visit date to moz_places, which will make the query we need more efficient as we don't have to join against moz_historyvisits) | |||
If something has a recent last visit date, then we recently recalculated | |||
frecency, so the frecency would be accurate. | |||
If something has a low frecency and an old last visit date, recalculating would only lower the frecency (and low frecency wouldn't be hurting our autocomplete results.) | |||
But if something has a high frecency and an old last visit date, recalculating the frecency would lower the frecency, which would solve the ebay problem. | |||
7) | 7) | ||
| Line 60: | Line 73: | ||
prefs->SetIntPref(PREF_BROWSER_LEFTPANEFOLDERID, -1);" | prefs->SetIntPref(PREF_BROWSER_LEFTPANEFOLDERID, -1);" | ||
covered by another bug, but we need to fix it before landing. | |||
x) | x) | ||