User:Sspitzer/GlobalFrecency: Difference between revisions

Jump to navigation Jump to search
no edit summary
No edit summary
No edit summary
Line 65: Line 65:


for new bookmarks, we will be calculating the frecency (and unhiding) when we call InsertBookmark()
for new bookmarks, we will be calculating the frecency (and unhiding) when we call InsertBookmark()
9)
I've made prefs for everything, so we can easily tune it.  note, for download, and redirect transitions, and 0 (undefined, see bug #xxxxxx) the weight is 0.  (will anything bad happen if we go negative?  I don't think so.)
10)
when do we recalc frecencies for places I don't revisit?  on expiration, but that could be a long time.  we also recalc on idle (after first bucket days), ordered by high frececeny.


'''todo'''
'''todo'''
Line 73: Line 82:
prefs->SetIntPref(PREF_BROWSER_LEFTPANEFOLDERID, -1);"
prefs->SetIntPref(PREF_BROWSER_LEFTPANEFOLDERID, -1);"


covered by another bug, but we need to fix it before landing.
covered by another bug, but we need to fix it before landing, otherwise going back and forth between versions will hork the organizer.


x)
x)


// when we created the moz_place entry for the new bookmarks, hidden was 1,
possible optimization, if not bookmark and no visit count, bail out early from frequency calculation?
// so frecency was 0.  now update the frecency for this item
// XXX unless this is a livemark?
printf("XXX %lld UpdateFrecencyAndHiddenForBookmark\n", childID);


x)


a) TRANSITION_BOOKMARK
make sure that we aren't doing too much work when a livemark gets updated, due to removing from hash
b) prefs to make the pig tunable
d) what weight should transistion download have?


x)
x)


optimization, if not bookmark and no visit count, bail out early from frequency calculation?
first time migration delay: from adding column with -1 to moz_places (acceptable, not much we can do)


x)
x)


make sure that we aren't doing too much work when a livemark gets updated, due to removing from hash
determine if we really need the index on frecency


x)
x)


first time migration delay: from adding column with -1
first time, all bogus (need to take the top <x> and recalc), on migration and import from fx 2


x)
x)


first time, all bogus (need to take the top <x> and recalc), on migration and import from fx 2
are there any undesirable side effects of clearing hidden?  I don't think so, as visiting a bm would unhide it.)   note, bm search now in open location and pref page autocompletes


x)
x)


impact of hidden for bmnote, bm search now in open location and pref page
verifyon any visit, recalc


x)
x)


on any visit, recalc
verify on any erase visit, recalc


x)
x)


on any erase visit, recalc
verify on partial expire, recalc


x)
x)


when do I reval places I don't revisit? (expiration might be a long time).  page with 10 visits in 1 day will have high frecenct
verify on clear all data, we set to -1 (or recalc? or leave alone?)
until I recalc


x)
x)


cpu usage
make sure not too much "on idle" cpu usage
 


x)
x)
Line 135: Line 138:
x)
x)


should drop down be frecency or visit date?
should url bar drop down be frecency or visit date?
 


x)
x)
234

edits

Navigation menu