234
edits
No edit summary |
No edit summary |
||
| Line 65: | Line 65: | ||
for new bookmarks, we will be calculating the frecency (and unhiding) when we call InsertBookmark() | for new bookmarks, we will be calculating the frecency (and unhiding) when we call InsertBookmark() | ||
9) | |||
I've made prefs for everything, so we can easily tune it. note, for download, and redirect transitions, and 0 (undefined, see bug #xxxxxx) the weight is 0. (will anything bad happen if we go negative? I don't think so.) | |||
10) | |||
when do we recalc frecencies for places I don't revisit? on expiration, but that could be a long time. we also recalc on idle (after first bucket days), ordered by high frececeny. | |||
'''todo''' | '''todo''' | ||
| Line 73: | Line 82: | ||
prefs->SetIntPref(PREF_BROWSER_LEFTPANEFOLDERID, -1);" | prefs->SetIntPref(PREF_BROWSER_LEFTPANEFOLDERID, -1);" | ||
covered by another bug, but we need to fix it before landing. | covered by another bug, but we need to fix it before landing, otherwise going back and forth between versions will hork the organizer. | ||
x) | x) | ||
possible optimization, if not bookmark and no visit count, bail out early from frequency calculation? | |||
x) | |||
a | make sure that we aren't doing too much work when a livemark gets updated, due to removing from hash | ||
x) | x) | ||
first time migration delay: from adding column with -1 to moz_places (acceptable, not much we can do) | |||
x) | x) | ||
determine if we really need the index on frecency | |||
x) | x) | ||
first time migration | first time, all bogus (need to take the top <x> and recalc), on migration and import from fx 2 | ||
x) | x) | ||
are there any undesirable side effects of clearing hidden? I don't think so, as visiting a bm would unhide it.) note, bm search now in open location and pref page autocompletes | |||
x) | x) | ||
verify: on any visit, recalc | |||
x) | x) | ||
on any visit, recalc | verify on any erase visit, recalc | ||
x) | x) | ||
on | verify on partial expire, recalc | ||
x) | x) | ||
verify on clear all data, we set to -1 (or recalc? or leave alone?) | |||
x) | x) | ||
cpu usage | make sure not too much "on idle" cpu usage | ||
x) | x) | ||
| Line 135: | Line 138: | ||
x) | x) | ||
should drop down be frecency or visit date? | should url bar drop down be frecency or visit date? | ||
x) | x) | ||
edits