234
edits
Changes
no edit summary
a) make sure on clearing / expiring, set frecency to -1
c) finish that marco related code on nonivalid on idle
d) need to clear visit counts, and last visit date (?) as they affect frecency
e) on expire / idle, re calc, to get bookmarks
x)
should we add "AND h.frecency > 0" to our autocomplete queries?"
yes, because take the following scenario:
a, livemark item get frecency of 0, since not a bookmark
b, visit livemark item, frecency of non 0, shows up in ac, no longer hidden
c) clear history, livemark item not hidden, would should up in ac, one we recalc, frecency gets 0.
d) but if we do this, what happens after migration or first run from b2?
Q: then do we still needed hidden <> 1?
everything gets frecency of -1, until we visit something or recalc on idle. for fx2 migration, when we import history, we can recalc (some?) at the end. for fx3b2 migration, we can recalc some at the end.
and then wait for idle?
on clear all data (and bm import or restore? should we do a quick recalc of bookmarks? what if they have a lot of bookmarks? should part of our work on idle be to recalc bookmarks?
x)
covered by another bug, but we need to fix it before landing, otherwise going back and forth between versions will hork the organizer.
marco's last_visit_date has the same issue.
x)
