234
edits
User:Sspitzer/GlobalFrecency: Difference between revisions
Jump to navigation
Jump to search
User:Sspitzer/GlobalFrecency (view source)
Revision as of 07:08, 31 December 2007
, 31 December 2007no edit summary
No edit summary |
No edit summary |
||
| Line 77: | Line 77: | ||
like unvisited livemark items, place: queries should not show up in autocomplete results. using IsQueryURI(), I check if the place url is place:..., and if so, pass in false for isBookmark to CalculateFrecency() so that they stay hidden until visited (or in the case of place: urls, always.) because the frecency is zero (passing in PR_TRUE for isBookmark would result in non-zero frecency), we will also no recalculate frecency on idle. only upon visit. | like unvisited livemark items, place: queries should not show up in autocomplete results. using IsQueryURI(), I check if the place url is place:..., and if so, pass in false for isBookmark to CalculateFrecency() so that they stay hidden until visited (or in the case of place: urls, always.) because the frecency is zero (passing in PR_TRUE for isBookmark would result in non-zero frecency), we will also no recalculate frecency on idle. only upon visit. | ||
12) on clear all data, resetting frecency and visit count to 0 (see bug #394133) | |||
'''todo''' | '''todo''' | ||
| Line 82: | Line 84: | ||
x) | x) | ||
a) | a) recalc frecency and visit_count on expiration / deletion of history | ||
b) recalc frecency for bookmarks after clearing all private data | |||
c) finish that marco related code on nonivalid on idle | c) finish that marco related code on nonivalid on idle | ||
x) | x) | ||
| Line 98: | Line 98: | ||
c) clear history, livemark item not hidden, would should up in ac, one we recalc, frecency gets 0. | c) clear history, livemark item not hidden, would should up in ac, one we recalc, frecency gets 0. | ||
d) but if we do this, what happens after migration or first run from b2? | d) but if we do this, what happens after migration or first run from b2? | ||
e) if we do this, we would need to recalc frecency of bookmarks after clear history, otherwise they would not show up | |||
Q: then do we still needed hidden <> 1? | Q: then do we still needed hidden <> 1? | ||