User:Manuel Bucher

From MozillaWiki
Jump to: navigation, search

I am a mozillian in the Necko-Team. I like improving docs when reading through them.

Resources to integrate somewhere into firefox-source-docs (or wiki)

My personal TODO-List for my outstanding documentation changes (where I don't have the time to do them immediately)/My non-trivially learned lessons about Firefox development:

ac_add_options --enable-debug
ac_add_options --enable-clang-plugin
#ac_add_options --disable-unified-build
ac_add_options --with-ccache=sccache
ac_add_options CCACHE=/home/user/.mozbuild/sccache/sccache

Fun code

  • Interesting workaround to have a public constructor, but not really [1]
class WorkerThread {
  // Using this struct we restrict access to the constructor while still being
  // able to use MakeSafeRefPtr.
  struct ConstructorKey {};

  explicit WorkerThread(ConstructorKey);
  • A long function name indicating that this function must not be called in non-test code[2]
 *  NOTE: This function is used only for testing!
 *  @param aDisable If true, disable all security check and make
 *                  hasMatchingOverride always return true.
void setDisableAllSecurityChecksAndLetAttackersInterceptMyData(in boolean aDisable);

Good documentation comments

DocumentChannel is a protocol agnostic placeholder nsIChannel implementation
that we use so that nsDocShell knows about a connecting load. It transfers
all data into a DocumentLoadListener (running in the parent process), which
will create the real channel for the connection, and decide which process to
load the resulting document in. If the document is to be loaded in the
current process, then we'll synthesize a redirect replacing this placeholder
channel with the real one, otherwise the originating docshell will be removed
during the process switch.

Will create the appropriate document channel:
Either a DocumentChannelChild if called from the content process or
a ParentProcessDocumentChannel if called from the parent process.
This operation is infallible.