Gaia/SMS/Scrum/2.2S11

From MozillaWiki
< Gaia‎ | SMS‎ | Scrum
Jump to: navigation, search

List of bugs

SMS issues handled by the SMS subteam (blocks the sprint bug 1156177)

Bugzilla link

ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Resolution
1084298 Steve Chung [:steveck] [Messages] Decoupling the all inputs query logic from DOM tree structure --- [p=1] FIXED
1152758 Julien Wajsberg [:julienw] [Messages] Empty report panel when opening it for an SMS that has been sent/received from a SIM that's not in the device anymore - [p=1] FIXED
1153808 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages] Thread is not marked as read (in UI only) when thread is opened from notification 2.2+ [p=1] FIXED
1154993 Julien Wajsberg [:julienw] [flame][3.0]Can't view SMS that has no phone number associated --- [p=1] FIXED
1155509 [Messages][NG] Separated views should be able to handle all required system messages --- [p(2.2S11)=5] WONTFIX
1155534 [Messages][NG] Extract NewMessage view from Conversation view --- [p(2.2S13)=1][p(2.2S11)=5] WONTFIX

6 Total; 0 Open (0%); 5 Resolved (83.33%); 1 Verified (16.67%);


Remaining points and burndown chart

google chart api url for Sprint 2.2S11

Burndown chart
Remaining points
Start 11
Day 2 11
Day 3 11
Day 4 8
Day 5 8
Day 6 8
Day 7 7
Day 8 7
Day 9 7
Day 10 7
Day 11 4
Day 12 4
Day 13 4
End 2


SMS issues handled by the SMS subteam outside of the sprint (contains whiteboard "sms-sprint-2.2S11")

ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Resolution
1010216 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages][Drafts] Improve consistency of the draft code in ThreadUI and ThreadListUI --- [sms-sprint-2.2S11][p=2] FIXED
1050823 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages][Refactoring] Revise "ThreadUI.updateHeaderData" call while retrieving threads --- [sms-sprint-2.2S11][p=1] FIXED
1148152 Oleg Zasypkin [:azasypkin][⏰UTC+1] Intermittent conversion_banner_test.js | Message Type Conversion Banner Message Type Conversion Banner for new threads MMS to email conversion and reminders --- [sms-sprint-2.2S11] FIXED
1155542 Steve Chung [:steveck] [Messages][New Gaia Architecture] Centralizing the global components/styling into a folder --- [sms-sprint-2.2S11] FIXED
1156625 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages] ThreadList&Thread separation: separate JS files --- [sms-sprint-2.2S11] FIXED
1156631 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages] ThreadList&Thread separation: separate CSS and image files --- [sms-sprint-2.2S11] FIXED
1156711 Steve Chung [:steveck] [Messages][New Gaia Architecture] remove static attachment menu markup and replace with shared widget --- [sms-sprint-2.2S11] FIXED

7 Total; 0 Open (0%); 7 Resolved (100%); 0 Verified (0%);


All SMS issues tracked for this sprint (target milestone)

Bugzilla link

ID Assigned to Summary Blocking b2g Feature b2g Resolution
1084298 Steve Chung [:steveck] [Messages] Decoupling the all inputs query logic from DOM tree structure --- --- FIXED
1148152 Oleg Zasypkin [:azasypkin][⏰UTC+1] Intermittent conversion_banner_test.js | Message Type Conversion Banner Message Type Conversion Banner for new threads MMS to email conversion and reminders --- --- FIXED
1153808 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages] Thread is not marked as read (in UI only) when thread is opened from notification 2.2+ --- FIXED
1156177 SMS sprint 2.2S11 --- --- WONTFIX
1156625 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages] ThreadList&Thread separation: separate JS files --- --- FIXED

5 Total; 0 Open (0%); 4 Resolved (80%); 1 Verified (20%);


Sprint planning

Minutes are on a separate page.

Daily meetings

Day 2: 17th April

Steve

  • bug 1113466 - [Network Alert] Support CDMA CMAS Alert
    • Still waiting Carol's feedback, will ping Ansul to see if it's still urgent or not.
  • bug 1084298 - Select all patch updated with draft issue fixing
    • Hope it's the final update for the patch :p
  • bug 1155088 - [Messages] FDN error warnning dialog will not be displayed while resending the message
    • Small bug for resend part and small patch provided for review.
  • bug 1155507 - [Meta][Messages][New Gaia Architecture] View panel separation for content wrapper part
    • Create meta bug and other related items for view separation task
  • bug 1155542 - [Messages][New Gaia Architecture] Centralizing the global components/styling into a folder
    • Per discussion yesterday we'll prefer to split views into different views and this first step should be doable for current master

Today:

  • Creation panel separation bugs and take some items.
  • Push for CDMA CMAS patch feedback
  • Refactor the css part if I have time on this.

Julien

  • Moved forward on bug 1142540 (contacts.js move to promises)
    • was landed (and already 1 regression ;) )
  • bug 1015194: started refactoring how recipients valid/invalid are handled. Moving a lot of code around
    • progressed and got feedback
  • reviewed Oleg's patch about integration tests: bug 1043903
  • continued the discussion with Bevis about retrying sending SMS (bug 1152730). This is one of the pain points for Alexandre Lissy (gerard-majax).
    • Gecko does not want to do any change...
  • reviewed bug 1084298 about decoupling select interfaces from DOM
  • reviewed bug 1126279 about separating the UI and the action parts of markThreadRead and deleteThread actions in thread_list_ui (for the "undo" work by Rishav)
  • gave feedback on bug 1127398 to display the correct thread when tapping a phone number in a message + good cleanup

Today: I want to:

If I have more time :

  • continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
  • move forward some background matters (organize group MMS bugs, and drafts handling issues started some weeks ago)
  • I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

  • bug 1043903 - [Messages][Tests] Add integration tests for the thread panel with a large number of messages
    • Got feedback/review, will fix review comments when I have some brain-switch time (in background).
  • bug 1151843 - [Messages][Refactoring] Use notification "data" attribute instead of icon URL query string parameters
    • Got r+ and landed (landed).
  • bug 1153808 - [Messages] Thread is not marked as read (in UI only) when thread is opened from notification
    • Prepared patch, tried to keep it simple (in review)
  • bug 1155509 - [Messages][New Gaia Architecture] Split ThreadList view from current structure
    • Started to work on this, more thinking than code yet (in progress)

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.

Day 3: 20th April

Steve

  • bug 1113466 - [Network Alert] Support CDMA CMAS Alert
    • Got some feedback from Carol , will update patch will unit test for review/feedback later.
  • bug 1084298 - Select all patch updated with draft issue fixing
    • Fix the last nits for landing

bug 1155088 - [Messages] FDN error warnning dialog will not be displayed while resending the message

    • Got r+ and apply the suggestion
  • bug 1155542 - [Messages][New Gaia Architecture] Centralizing the global components/styling into a folder
    • Create a WIP that move the global assets into another subfolder and with some polishing

Today:

  • App folder structure polish.
  • Update CDMA CMAS patch for review
  • Refactor the css part if I have time on this.

Julien

  • bug 1015194: started refactoring how recipients valid/invalid are handled. Moving a lot of code around
    • no progress -- will progress in background during the sprint but not at full speed
  • reviewed bug 1084298 about decoupling select interfaces from DOM
    • still one small issue: "function xxx(id = +id)" doesn't do what Steve thought :)
  • reviewed small bug 1153808 about marking a thread read when loading from the notification
  • gave feedback on bug 1144612 about refactoring CSS building blocks
    • I need to speak with Wilson about Web Components (trying to see if the work to refactor CSS will last or would be replaced soon). My opinion is that some part will last (we won't replace everything now) and anyway we'll learn useful things in the process.
  • tried to reproduce bug 1136211 before/after patch but I couldn't reproduce before... so I can't verify the bug. But I'm sure I could reproduce earlier on so I'll need to remember how I did :p

Others:

  • spent a good part of the day working on a lightsaber patch (took a lot more time than I wanted...).
  • created the sprint's bug and wiki page but haven't finished marking dependencies yet

Today: I want to:

If I have more time :

  • take a new bug in the sprint

If all this moves forward well, I could:

  • continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
  • move forward some background matters (organize group MMS bugs, and drafts handling issues started some weeks ago)
  • I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

  • bug 1043903 - [Messages][Tests] Add integration tests for the thread panel with a large number of messages
    • No progress (in background).
  • bug 1153808 - [Messages] Thread is not marked as read (in UI only) when thread is opened from notification
    • Got review, will fix review comment and ask for review today (in progress)
  • bug 1155654 - [Messages] Use bower to manage gaia web components dependencies
    • Thought it may be convenient to use bower in sms since both threads.js and little-browser are web components and in active development (+ switched gaia-header, gaia-theme, gaia-icons to bower as well), but looks like Julien doesn't like the idea :) Do you guys think we should manually update our own copy of threads.js and little-browser.js or put it into /shared?
      (Julien) I'd be fine with adding threads/little-browser.js to the bower components we already have in /shared. I think we could have our own bower components only when having a separate repository. Otherwise it's really a mess when the libs are updated, and we always stay on a old version... And these days the libs will be updated often.
      (Oleg) IIRC Wilson was eager to get rid of shared/elements, do you think we'll forget to update bower folder in time?
      (Steve) I think we'll need to use bower for management in long tern, and updating the bower folder is not really a good way IMO.
      (Julien) Yes I think this is just another task we'll need to do and remember :/
      (Oleg) Just question, is it possible to have pre-commit hook for one folder (apps/sms) only for example that can update bower components?
      (Julien) I don't think so.. and requesting network when committing is not really a good practice anyway :)
      (Julien) I really don't object for it longterm, but I think it's too soon. If Wilson really wants to kill /shared/elements then we can revisit for sure.
      (Oleg) Okay, let's leave it alone for now :) We need to ask Wilson then to maintain shared/threads and little-browser and keep it updated.
      (Julien) for gaia-header, usually we were updating /shared/ in the normal process of landing patches to gaia-header.
      (Oleg) Yeah, that's why dev who changes threads/little-browser should take care about it.
  • bug 1155509 - [Messages][New Gaia Architecture] Split ThreadList view from current structure
    • Hope to have smth ready for feedback today\tomorrow (in progress)
  • bug 1127398 - [Messages] Display existing thread when sending a message using phone-number-/email-link context menu
    • Got feedback, will handle feedback comments in the background (in background).

Other:

  • Reviewed Steve's "FDN error dialog" PR, looks good, r+'ed.

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.

Day 4: 21st April

Steve

  • bug 1113466 - [Network Alert] Support CDMA CMAS Alert
    • Patch submitted for review and some feedback return. Will apply the suggestion and request review again.
  • bug 1084298 - Select all patch updated with draft issue fixing
    • Landed, thanks for all the reviews
  • bug 1155088 - [Messages] FDN error warnning dialog will not be displayed while resending the message
    • Landed
  • bug 1155542 - [Messages][New Gaia Architecture] Centralizing the global components/styling into a folder
    • Create a WIP that move the global assets into another subfolder and with some polishing
  • Besides the existing panels, the remaining loading screen and attachment menu seems not necessary to have a static structure in document. Not sure why we don't migrate these into shared widget like action menu or something before. Maybe we could clean up these for panel separation.
    • One of the ideas about waiting screen I had in mind was: like have it only in the top level index.html that contains little-browser so that it can easily overlay any currently displayed iframe, but now I think it's a bad idea since CW will go away and every view should take care about loading screen :)
      (Steve) Having a view that could overlay any iframe seems not a allowed for the CW framework? But yes I think CW might provide a way to do so
      (Julien) FYI I think Vivien is thinking about how we could have a "standardized" way of having dialogs. I don't think we'll have it soon but at least thinking of it.
      (Oleg) Steve: yeah, I meant that we have main index.html (and main index.js file as well) that contains little-browser web component, and that main index.js potentially could handle such things and panel just asks "service.showLoadingScreen", but as I said - I don't think it's a good idea now :) Julien: yeah, that what we'll definitely need to avoid different dialog style across app as we have now. At least dialog-web-component will help to standardize a lot.
      (Oleg) On the side note, the current service-CW stuff sounds very similar to what I saw/tried/new in Angular js framework :)

Today:

  • App folder structure polish.
  • Update CDMA CMAS patch for review
  • Revisit current message app structure and create bug if necessary
  • Refactor the css part if I have time on this.

Julien

  • bug 1154993: can't view threads with a phone number that has only non-digit characters (coming from services)
    • I first started working in mozContacts but then I realized we should never break because of mozContacts issue, so we now catch all errors from mozContacts (but we log them). Landed.
  • Reviewed bug 1113466: display CDMA CMAS alerts in the Network Alerts app
    • small nits but this looks good. We can see having one event for both types of network is not really nice because they really don't have the same informations.
  • reviewed bug 1153808: mark threads as "read" even when it's not rendered yet.
  • reviewed bug 1043903: new integration tests and especially new method to handle test data
  • reviewed bug 1126279: split the "mark as read" and "delete" methods in ThreadListUI in 2 parts so that the "destructive" part could be done later when "undo" is implemented (from Rishav).
  • bug 1015194: started refactoring how recipients valid/invalid are handled. Moving a lot of code around
    • no progress -- will progress in background during the sprint but not at full speed

Others:

  • finished creating the sprint's bug and wiki page but haven't finished marking dependencies yet

Today: I want to:

If I have more time :

  • take a new bug in the sprint

If all this moves forward well, I could:

  • continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
  • move forward some background matters (organize group MMS bugs, and drafts handling issues started some weeks ago)
  • I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

  • bug 1043903 - [Messages][Tests] Add integration tests for the thread panel with a large number of messages
    • Got last review comments, fixed and landed (landed).
    • This bug unblocks some integration test ideas I had in mind previously - we can now create any (I hope :)) workload data for our tests.
    (Julien) Johan told me he will start migrating the Python tests to JavaScript so I told him about this patch. Currently they call functions like "appendThread" to add data to the DOM...
    (Oleg) Yeah we shouldn't use "appendThread" directly I think. Please let me know if something isn't very handy for him - I'll take care :)
    (Julien) sure !
  • bug 1153808 - [Messages] Thread is not marked as read (in UI only) when thread is opened from notification
    • Got last review and landed (landed).
  • bug 1155509 - [Messages][New Gaia Architecture] Split ThreadList view from current structure
    • PR started to grow, so split it into the bugs below (in progress).
  • bug 1156625 - [Messages] ThreadList&Thread separation: separate JS files
  • Prepared patch - will ask for your feedback (awaiting feedback).
  • The main question I wanted to ask is: I found it easier to move all shared Thread&Composer js/css (in the next bug) to views/thread/ first and then split it to "views/thread" and "views/composer" in the dedicated bugs. So first split thread&composer js/css from shared and thread-list and only then split it further. Does it work for you?
    (Julien) I don't mind :)
    (Steve) works for me
    (Oleg) Okay, good then
  • bug 1156631 - [Messages] ThreadList&Thread separation: separate CSS and image files
    • PR almost ready for feedback, now I want to split it into two commits - first with just "moves" and second with extraction of view specific styles from sms.css. (in progress)
  • bug 1127398 - [Messages] Display existing thread when sending a message using phone-number-/email-link context menu
    • No updates (in background).

Other:

  • Reviewed patch for "bug 1154993 - [flame][3.0]Can't view SMS that has no phone number associated".
  • Gave tiny feedback on "bug 1155542 - [Messages][New Gaia Architecture] Centralizing the global components/styling into a folder", just wanted to take some time to see how it correlates with my PR for ThreadList separation.

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.

Day 5: 22nd April

Steve

  • bug 1113466 - [Network Alert] Support CDMA CMAS Alert
    • Address the Bevis' suggestion and create another CB disabling bug since it might be more important than CDMA CMAS.
  • bug 1155542 - [Messages][New Gaia Architecture] Centralizing the global components/styling into a folder
    • Create a WIP that move the global assets into another subfolder and with some polishing
  • Create 2 more smaller bug for panel separation polishing
    • bug 1156711 - [Messages][New Gaia Architecture] remove static attachment menu markup and replace with shared widget
      • Will create a patch for removing the attachment menu use option menu instead.

Today:

  • App folder structure polish.
  • Update CDMA CMAS patch for review
  • Revisit current message app structure and create bug if necessary
  • Refactor the css part if I have time on this.

Julien

(Note: today we're doing a day of working on something other than our usual work)

  • Reviewed bug 1113466: display CDMA CMAS alerts in the Network Alerts app
    • small nits left
  • worked on bug 1152758: issue when showing the report panel for a message for a SIM that's not on the device
    • I ended up rewriting part of the method here. In review.
  • bug 1015194: started refactoring how recipients valid/invalid are handled. Moving a lot of code around
    • no progress -- will progress in background during the sprint but not at full speed
  • reviewed bug 1155610: move all integration tests to a "phone" subdirectory
    • not sure this is the right direction, but the harness people are on it.
  • tried to reproduce bug 1149457 but I could do it only rarely
    • asked QA
  • moved forward things for bug 1150449 about the Arabic fonts
  • reviewed bug 1112119 which removes PerformanceTestingHelper (which could bring us a very little performance benefit because it was loaded at startup)
  • investitaged bug 1156464: in some situations we don't display the notification. I _think_ this is happening because we don't register the system message handler, but I didn't try to register it inconditionally so I'm not certain. It's just an educated guess. I can try to investigate a little more but only tomorrow.
    • (Oleg) It's probably not related, but before the recent fix for the Contacts.js (where we return null instead of rejected promise) the notification hasn't been created if sender didn't have phone number associated.
      (Julien) yeah it's not related; here the notification is never created. I guessed the regressing bug too but when I tried with a Gaia before this bug, tapping the notification just didn't work at all :p Anyway it will likely be 2.2+ and we'll investigate a little more in next sprint, I don't think we need to rush now, it's an edge case.
  • started thinking about branching vs separate repo for the new generation architecture. I'm not sure of what is best yet, I'll write down the goals so that we can find solutions together and with other teams. I also saw that nearly nobody is registered on the dev-ng-gaia mailing list -- are you?
    • (Oleg) I've never heard about such list :) Maybe because I didn't attend gaia meetings, my bad
      (Julien) I thought Jacob sent a mail about this to dev-gaia but not sure :) it's https://groups.google.com/a/mozilla.com/forum/#!forum/dev-ng-gaia
      (Oleg) Okay, thanks! Mmm "This group is invite only, so you may not apply for membership."
      (Julien) OK; it should be moved to more "open" soon, I'll tell you.
      (Steve) Thanks!

Today:

  • I'll work on event fluffing (bug 946731) or another unrelated bug if this one is too difficult ;)

Tomorrow: I want to:

If I have more time :

  • take a new bug in the sprint

If all this moves forward well, I could:

  • continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
  • move forward some background matters (organize group MMS bugs, and drafts handling issues started some weeks ago)
  • I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

  • bug 1155509 - [Messages][New Gaia Architecture] Split ThreadList view from current structure
    • PR started to grow, so split it into the bugs below (in progress).
  • bug 1156625 - [Messages] ThreadList&Thread separation: separate JS files
  • Prepared patch and asked for feedback (awaiting feedback).
  • bug 1156631 - [Messages] ThreadList&Thread separation: separate CSS and image files
    • Prepared patch and asked for feedback (awaiting feedback).
  • bug 1127398 - [Messages] Display existing thread when sending a message using phone-number-/email-link context menu
    • Added support for mozContacts mock for our marionette js tests + 3 integration tests for the activity case (number lead to composer with "manual" recipient, number lead to composer with "contacts" recipient and number lead to existing Thread) + 3 similar integration tests for the "Send message" item from contact prompt. It's turned out we loose\don't use "activity.data.body" if we forward user to Thread, not sure if we can have cases for that, but suspect yes.

Today:

  • Today is the experimental "Europe Hack Day", so today I'm working on fxos-remote-manager app bundle :);

Day 6: 23rd April

Steve

  • bug 1113466 - [Network Alert] Support CDMA CMAS Alert
    • Patch updated for final review and created another bug for CB disabling
  • bug 1157190 - [System] User could receive cell broadcast notification even turn it off in settings
    • Seems like RIL didn't check the CB disabled option either. Maybe blocking from RIL would be more general but having another checking in gaia would be safer.
      (Julien) yeah I don't think this would be problematic to check at both places; but maybe leave a comment to say that the check should be done at RIL level too.
  • bug 1155542 - [Messages][New Gaia Architecture] Centralizing the global components/styling into a folder
    • Create a WIP that move the global assets into another subfolder and with some polishing
  • Create 2 more smaller bugs for panel separation polishing
    • bug 1156711 - [Messages][New Gaia Architecture] remove static attachment menu markup and replace with shared widget
      • Patch created for removing the attachment menu with option menu.
  • Some discussion about the css again. Since everyone thought gaia-component is our goal in long term, will try to push ux to see if someone can review the component and we can migrate the component once it gains ux approval.

Today:

  • App folder structure and attachment menu polishing.
  • Update CDMA CMAS/CB patch for review
  • Refactor the css part if I have time on this.

Julien

Note: yesterday we were doing a day of working on something other than our usual work, so very few things progressed in the sprint for me.

  • moved forward things for bug 1150449 about the Arabic fonts, discussed with Pavel to make it at last happen.

Today: I want to:

If I have more time :

  • start looking at little-browser

If all this moves forward well, I could:

  • continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
  • move forward some background matters (organize group MMS bugs, and drafts handling issues started some weeks ago)
  • I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

  • bug 1155509 - [Messages][New Gaia Architecture] Split ThreadList view from current structure
    • No progress yesterday (in progress).
  • bug 1156625 - [Messages] ThreadList&Thread separation: separate JS files
  • Received Steve's feedback, will reply/fix today (awaiting feedback).
  • bug 1156631 - [Messages] ThreadList&Thread separation: separate CSS and image files
    • Received Steve's feedback, will reply/fix today (awaiting feedback).
  • bug 1127398 - [Messages] Display existing thread when sending a message using phone-number-/email-link context menu
    • No progress here from yesterday (in background).

Today:

  • Will handle review/feedback/need-info requests; Steve's requests are in priority. Sorry for such a delay!
    (Steve) np, take your time :)
  • Will work on review comments and assigned bugs.
  • Will take a look at "bug 1148152 - Intermittent conversion_banner_test.js | Message Type Conversion Banner Message Type Conversion Banner for new threads MMS to email conversion and reminders"
  • Will double check that we need both UI and non UI fonts at "bug 1150449 - use Droid Naskh UI Arabic font for Arabic script to replace Droid Arabic Naskh".

Day 7: 24th April

Steve

  • bug 1113466 - [Network Alert] Support CDMA CMAS Alert
    • Landed
  • bug 1157190 - [System] User could receive cell broadcast notification even turn it off in settings
    • Bevis close as wont fix because he thought there's nothing to do with moz side... Not sure if it's correct way to do so because maybe someday partner might ship with moz RIL and we still need to fix it eventually :/
      (Julien) do you think mozRIL does not check this? I had the impression that the issue was that Carol used another environment than CAFRIL and so the check was not done at all in her environment.
      (Steve) Not sure which env is used per her testing(not moz RIL for sure), and looks we did some check in our RIL, will double-check with Bevis again later
      (Julien) okay; if we don't check in mozRIL then for sure we need to fix, but I understood we do :)
  • bug 1155542 - [Messages][New Gaia Architecture] Centralizing the global components/styling into a folder
    • Move the shared into views subfolder and finish the desktop mock build script change
    • bug 1156711 - [Messages][New Gaia Architecture] remove static attachment menu markup and replace with shared widget
      • Got some feedbacks, maybe it's a good time to complete the attachment option for contact and wrapped requestAttachment into promise
    • Waitscreen polishing: Importing external markup is depreciate :p Using the template might make the tree a little bit small but we still need to duplicate the template for each view.
      (Julien) not if we improve the template library to fetch the template using XHR as I proposed :)
  • Seems we got positive feedback from UX about the web component, will discuss with Fred about how to make web component migrate in reasonable peace and discuss with original BB UX Harly about the web component styling(if ux have no idea about the v3 design)
    (Julien) I think migrating to web components won't solve everything. Web components themselves need to be easily overridable, with several states, etc.
    (Oleg) The main benefit in using web components in gaia that I see is that it will force web components to be improved quicker :D (performance and all that stuff). + we need better architectural approach for web components used in gaia so that they can be easily extended
    (Julien) yep; no proper thinking will yield the same mess than we currently have. I'm not optimistic here.
    (Steve) I agree using web component will solve everything, but it will be easier to build up the clean/maintainable css. We still need to polish our own css anyway
    (Oleg) Even that web components don't solve everything and not really performant at the moment, I think we still need to move it forward and move forward with it :)
    (Steve) About the overridable, it's really interesting question: should we allow the widget been customized frequently? I agree that component should provide an interface to adjust the layout in reasonable way.
    (Oleg) I think it depends and will be different in every case, gaia-header should have been quite extensible, gaia-checkbox probably shouldn't be such extensible. I'm glad that we started to think and discuss about it.

Today:

  • App folder structure and attachment menu polishing.
  • web component stuff discussion.

Julien

  • Finished all my reviews/needinfo/feedbacks for the first time for.... I don't know :) \0/
  • Tried to reproduce bug 1149457 (wrong display when there are a lot of recipients in some situations) but I couldn't. I'll try again today now that QA put up a video.
  • reviewed bug 1113466 (CDMA network alerts). I thought over the night that we could have used nicer "CDMAMessage" and "GDMMessage" objects to handle the differences, but we can do that later if we really need it.
  • reviewed bug 1155421 (replace "discard" by "delete draft"), done by a contributor
  • gave feedback on bug 1156711 (replace attachment_menu by option_menu)
  • gave feedback on bug 1156719 (change how the WaitingScreen is loaded)
  • gave feedback on bug 1155542, bug 1156625, bug 1156631: add folders for views
  • landed bug 1152758: blank report for messages sent/received by a SIM that's not here anymore
  • moved forward things for bug 1150449 about the Arabic fonts, discussed with Pavel to make it at last happen.
  • tried to reproduce bug 1136211 again on an older build, but couldn't. But I did reproduce on v2.1. I assumed it was fixed anyway.
  • reordered the "group mms" bugs and made them depend on the meta bug 1106663
  • sent mail to UX and you about drafts handling.

Today: I want to:

If all this moves forward well, I could:

  • continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
  • move forward some background matters (organize group MMS bugs, and drafts handling issues started some weeks ago)
  • I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

  • bug 1156625 - [Messages] ThreadList&Thread separation: separate JS files
  • Received feedback from both Steve and Julien, working on comments (in progress).
  • Have question regarding unit tests: https://github.com/mozilla-b2g/gaia/pull/29607#issuecomment-95822412
  • bug 1156631 - [Messages] ThreadList&Thread separation: separate CSS and image files
  • Received feedback from both Steve and Julien, working on comments (in progress).
  • bug 1127398 - [Messages] Display existing thread when sending a message using phone-number-/email-link context menu
    • No progress here from yesterday (in background).
  • bug 1148152 - Intermittent conversion_banner_test.js | Message Type Conversion Banner Message Type Conversion Banner for new threads MMS to email conversion and reminders
    • Investigated intermittent failures here, I'd say with the latest source and b2g it's not intermittent - it's permanently red :) Everything looks good in test (in setup we create two threads manually), but when we tap on "send" button second time - nothing happens - don't see difference right now except that for the first thread I don't see keyboard suggestions, but for the second one they appear - will debug deeper in the background but in the meantime I migrated this test to TestStorage that resolved the issue (in review).
      (Julien) maybe it would help to see when it started to be permanently red.
      (Oleg) Do you have idea how to check this? I'm not really sure how to bisect this
      (Julien) looking at treeherder maybe :) I'll be looking.
      (Oleg) Thanks :)

Other:

  • Reviewed/left feedback for Steve's requests.
  • Checked that we actually don't need non-UI Naskh font in "bug 1150449 - use Droid Naskh UI Arabic font for Arabic script to replace Droid Arabic Naskh".

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.
  • Will try to understand what happened to notifications in "bug 1156464 - [Window Management] Accessing a message thread via notification after killing Messages app creates adverse effects on future notifications while in app". At the first look it happens because of the fact that when we run brand new Messages instance from notification we have ....#notification URL, but sms-received system message in tied to hash-less URL, but if it's the case then Gecko/System should have run a new instance to handle message - so will dig .....

Day 8: 27th April

Steve

  • bug 1155542 - [Messages][New Gaia Architecture] Centralizing the global components/styling into a folder
    • Still working on moving shared assets into views subfolder
  • bug 1156711 - [Messages][New Gaia Architecture] remove static attachment menu markup and replace with shared widget
    • working on the requestingAttachment into promise. Might create the attachment contact option to another bug
  • Reviewing the Oleg's patch about the separation

Today:

  • Finish the review
  • Feedback for branching/other possible solution for current status
  • App folder structure and attachment menu polishing.

Oleg

  • bug 1156625 - [Messages] ThreadList&Thread separation: separate JS files
  • Fixed comments and renamed ThreadListUI and ThreadUI to InboxView (views/inbox/js/inbox.js) and ConversationView (views/conversation/conversation.js) accordingly, asked for review (in review).
  • bug 1156631 - [Messages] ThreadList&Thread separation: separate CSS and image files
  • Fixed comments here as well, PR is ready for review, but it depends on the previous patch so will hold on review until PR above is landed (ready for review, waiting for dependency).
  • bug 1127398 - [Messages] Display existing thread when sending a message using phone-number-/email-link context menu
    • No progress here (in background).
  • bug 1148152 - Intermittent conversion_banner_test.js | Message Type Conversion Banner Message Type Conversion Banner for new threads MMS to email conversion and reminders
    • Got r+ and landed (landed).
  • bug 1153808 - [Messages] Thread is not marked as read (in UI only) when thread is opened from notification
    • Patch uplifted to v2.2 didn't work and made Gij red because of the fact that ThreadListUI.markReadUnread doesn't exist in v2.2, asked Ryan to backout the patch and prepared v2.2-only patch (in review).
  • bug 1156464 - [Window Management] Accessing a message thread via notification after killing Messages app creates adverse effects on future notifications while in app
    • It's likely because of the fact that we have "#notification" URL for the app that is loaded from notification, but "sms-received" system message is only dispatched to document with hashless URL. The first plan is to get rid of this "#notification" part. Will check if it doesn't break anything else + good to have integration test for this (in background).

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.
  • Will reply to Julien's emails about branching and drafts.

Day 9: 28th April

Steve

  • bug 1155542 - [Messages][New Gaia Architecture] Centralizing the global components/styling into a folder
    • Still working on moving shared assets into views subfolder
  • bug 1156711 - [Messages][New Gaia Architecture] remove static attachment menu markup and replace with shared widget
    • Patch updated with requestAttachment promise and other nits addressed.
  • Reviewied the Oleg's patch about the separation
  • Feedback for branching/other possible solution for NG

Today:

  • App folder structure and attachment menu polishing.
  • More discussion with migrating the gaia-component, might start with other general component like gaia-confirm and give more test for performance.

Julien

(This is my report for last friday :) )

  • reproduced bug 1149457 (wrong display when there are a lot of recipients in some situations)
  • reviewed bug 1148152 about flaky integration tests; I spent a lot of time trying to reproduce locally but couldn't, which is weird because Oleg could reproduce the first time :/
  • added CMAS emulator commands in https://wiki.mozilla.org/Gaia/Network_Alerts
    • asked Bevis to have a quick look (and I see he contributed the UCS2 example)
  • wrote the mail to dump by ideas about the branching (or not :) ). Haven't looked at answers yet.
  • spent some time to answer mails and order bugs, not a very efficient day..

Today: I want to:

  • do reviews/need infos to go to 0 requests again ;)
  • start looking at little-browser

If all this moves forward well, I could:

  • continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
  • I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

  • bug 1156625 - [Messages] ThreadList&Thread separation: separate JS files
  • Got review from Steve! (in review).
  • bug 1156631 - [Messages] ThreadList&Thread separation: separate CSS and image files
  • Almost no updates here since yesterday (just move group header style from sms.css to converstation.css) (ready for review, waiting for dependency).
  • bug 1127398 - [Messages] Display existing thread when sending a message using phone-number-/email-link context menu
    • No progress here (in background).
  • bug 1153808 - [Messages] Thread is not marked as read (in UI only) when thread is opened from notification
    • Got r+ from Steve, patch has been uplifted to v2.2 (landed).
  • bug 1155509 - [Messages][New Gaia Architecture] Split ThreadList view from current structure
    • Extracted inbox-related index.html part into views/inbox/index.html with separate startup.js since it requires much more than inbox needs, thinking at the moment how to deal with startup.js better;
    • Started to deal with Inbox-Conversation dependencies (in progress, waits for dependencies).
  • bug 1050823 - [Messages][Refactoring] Revise "ThreadUI.updateHeaderData" call while retrieving threads
    • Looks like we don't need this call anymore, I found only 2 possibilities when we can open conversation view with non-ready inbox: from notification or from activity + 2 ways when inbox is ready: tap on thread in inbox and from composer when we send message. All cases seem to work - added integration tests for notification and activity cases. Waiting for Treeherder before asking for review (almost ready for review).
  • bug 1156464 - [Window Management] Accessing a message thread via notification after killing Messages app creates adverse effects on future notifications while in app
    • In the bug above added code that will allow create integration for this case as well (in background).

Other:

  • Started to review Steve's patch, will finish soon;
  • Replied some thoughts about Julien's draft and branching emails.

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.

Day 10: 29th April

Steve

  • bug 1155542 - [Messages][New Gaia Architecture] Centralizing the global components/styling into a folder
    • Still working on moving shared assets into views subfolder, will create a patch for review
  • bug 1156711 - [Messages][New Gaia Architecture] remove static attachment menu markup and replace with shared widget
    • Patch updated with requestAttachment promise and other nits addressed. will create a patch for review as well
  • gaia-component review with UX: In short, almost none of the component is ready :/ . Some components like text-input(some issue in search type)/checkbox/switch(performance) might be close to ready, but other components is buggy in UX POV.

Today:

  • App folder structure and attachment menu polishing.
  • Create meta to for gaia-component with bugs discovered today

Julien

Mostly spent time reading and handling the bug mail + other mails on dev-gaia about build and architecture...

Today: I want to:

  • do reviews/need infos to go to 0 requests again ;)
  • start looking at little-browser

If all this moves forward well, I could:

  • continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
  • I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

  • bug 1156625 - [Messages] ThreadList&Thread separation: separate JS files
  • No progress since yesterday (in review).
  • bug 1156631 - [Messages] ThreadList&Thread separation: separate CSS and image files
  • No progress since yesterday (ready for review, waiting for dependency).
  • bug 1155509 - [Messages][New Gaia Architecture] Split ThreadList view from current structure
    • Identifying and removing dependencies (in progress, waits for dependencies).
  • bug 1050823 - [Messages][Refactoring] Revise "ThreadUI.updateHeaderData" call while retrieving threads
    • Prepared patch and asked for review (in review).
  • bug 1010216 - [Messages][Drafts] Improve consistency of the draft code in ThreadUI and ThreadListUI
    • Poking around drafts code to remove inter-view dependencies between Conversation and Inbox. I've never dug into it before, so this is good time for me to actually understand how it works (in progress).
      (Julien) Ideally I think the drafts should be handled by the Compose component alone... but not sure.
      (Oleg) Not sure, we have recipients in draft - and it's different component
      (Julien) mmm yes right.

Other:

  • Reviewed Steve's patch about removing attachment-menu;
  • Slowly organizing drafts related bugs.

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.

Day 11: 30th April

Steve

  • bug 1155542 - [Messages][New Gaia Architecture] Centralizing the global components/styling into a folder
    • Patch given for review
  • bug 1156711 - [Messages][New Gaia Architecture] remove static attachment menu markup and replace with shared widget
    • Landed, but I think our action items would affect each other's patch :/ Sorry if the any conflict happens to you
      (Julien) it's ok :) we can rebase ! Because we know each other's work it's also easier. It can be more difficult for contributors.
  • bug 1160054 - [Messages][refactoring] Migrate mozActivity DOM request to promise base
    • Will work it in background. Using promise might help the code more cleaner and easier for mock mozActivity.
  • gaia-component stuff
    • Reviewed with UX and create a wiki[1] and meta bugs for each component. It might be better is we(devs/product/UX) are all in the same page for tracking status and reporting issues. If you found any issue just feel free to create it under meta and we can have a clear picture about the progress

[1] https://wiki.mozilla.org/Gaia/Shared/Components Today:

  • shared folder structure polishing.
  • Create gaia-component bugs we found during the discuss with ux and other devs.

Julien

  • discussed about group mms in bug 1106663 and bug 1020209
  • investigated some transition timings in bug 1143226
  • reviewed bug 1050823
    • especially spent a lot of time discussing about integration tests with Alexandre Lissy and Johan Lorenzo -- depending on external components, etc. Discussion still ongoing ;)
      (Oleg) Sorry for that :) We need to figure out it early, since we have few more bugs that may need similar tests
  • started looking at bug 1155542 until I saw it depends on bug 1156625
  • bug 1156625: reviewed and r+
    • I think we should send a mail to our contributors because of the naming change. Oleg can you do this?
    • (Steve) Do we need to send a mail to dev-gaia or just major contributor like Kumar and Teja? It seems too technical and detail for all gaia developers
      (Oleg) Kumar Rishav will hate me :) :D
      (Julien) maybe dev-gaia + these contributors in Cc ? We don't need to be very technical, only send the naming change + say we change the folder hierarchy and then point to the bugs.
      (Oleg) Sure, I can handle it once I land the patch.
      (Julien) thanks ! maybe point to the meta bug as well (I talked about it in gaia meeting last tuesday already).
      (Oleg) Okay!

Today: I want to:

  • do reviews/need infos to go to 0 requests again ;) -- today I can do it !
  • start looking at little-browser

If all this moves forward well, I could:

  • continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
  • I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

  • bug 1156625 - [Messages] ThreadList&Thread separation: separate JS files
  • Got r+, will squash and merge (ready to check-in).
  • bug 1156631 - [Messages] ThreadList&Thread separation: separate CSS and image files
  • Will rebase on the latest master today and ask for review (ready for review, waiting for dependency).
  • bug 1155509 - [Messages][New Gaia Architecture] Split ThreadList view from current structure
    • No progress since yesterday (in progress, waits for dependencies).
  • bug 1050823 - [Messages][Refactoring] Revise "ThreadUI.updateHeaderData" call while retrieving threads
    • Got review, replied to comments, I had a bit different idea behind integration tests for this bug - will take care of it once we workout best way (in progress).
  • bug 1010216 - [Messages][Drafts] Improve consistency of the draft code in ThreadUI and ThreadListUI
    • Have some more or less ready WIP, will rebase patch on the latest master and try to split my changes to several bugs (in progress).

Other:

  • Reviewed Steve's patch about removing attachment-menu; Everything is good, but it looks like we need to take care about "Replace" case in the follow-up.

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.

Day 12: 1st May

Holiday for every member.

Day 13: 4th May

Steve

  • bug 1155542 - [Messages][New Gaia Architecture] Centralizing the global components/styling into a folder
  • bug 1156719 - [Messages][New Gaia Architecture] remove static wait screen markup and set it as shared widget
    • Create a testing patch by using fetch api for loading html. Got some feedback about generic Template initialization.
  • Review bug 1156631 Oleg's css separation patch
  • gaia-component stuff
    • Meta bug created for each component, need to create the bugs found by visual later.

Today:

  • shared folder structure polishing.
  • Create gaia-component bugs we found during the discuss with ux and other devs.
  • Will figure out the correct cut/paste behavior with Omega
  • Fix the attachment menu for closing the option menu manually.

Julien

  • discussed again about group mms in bug 1106663 and bug 1020209
  • spent some time on bug 818000 to do a simple app that would show the issue -- we'll need this for system messages to work properly with the new architecture :/
  • reviewed bug 1156631: separate CSS and image files between viewes
  • proposed a solution for bug 1156719 -- loading templates from external files
  • had a look at bug 1155542 -- but I think it should come after bug 1156631

Today: I want to:

  • do necessary reviews
  • do a last case for bug 818000
  • start looking at little-browser
  • prepare tomorrow's planning

If all this moves forward well, I could:

  • continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
  • I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

  • bug 1156625 - [Messages] ThreadList&Thread separation: separate JS files
  • Squashed, briefly checked on device once again and landed + brief email about the change to dev-gaia (landed).
  • bug 1156631 - [Messages] ThreadList&Thread separation: separate CSS and image files
  • Rebased on master and got Juline's review, got conflicts while rebasing on current master (using var(--transition-duration) for transition now) - resolving (in review).
  • bug 1155509 - [Messages][New Gaia Architecture] Split ThreadList view from current structure
    • No progress (in progress, waits for dependencies).
  • bug 1050823 - [Messages][Refactoring] Revise "ThreadUI.updateHeaderData" call while retrieving threads
    • Sent "MarionetteJS integration Gaia tests and system messages" email to gaia-automation list, got only Johan's and Julien's replies so far. Still not really convinced what way is better, but will see how integration test based on Julien's suggestion will look like (in progress).
  • bug 1010216 - [Messages][Drafts] Improve consistency of the draft code in ThreadUI and ThreadListUI
    • Testing my changes (in progress).

Other:

  • Reviewed Steve's patches.

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.

Demos

No demos this time.

Retrospective

What was good in the last sprint

  • We discussed a lot about separating and cleaning Messages, so the way forward is quite clear now. +1

What was bad in the last sprint

  • Splitting of resources is routine and needs attention, so it was time consuming.
  • (Julien) I don't think I did much work as planned in the sprint ... time consumed by other tasks + reviews (which are part of the sprint :D). Not a good sprint for me..

Any questions

  • I have some concern about the 2.2 blocker fixing(since the code freeze would be Jun) Seems like we'll take more time for manual uplifting the blocker. Not sure if it will become more complicate when bridge/little browser introduce in master(So we're not going to branch?)
    (Julien) branch or not branch, all fixes will need to go in both codes anyway (new code and old code); so I think the amount of work would be the same -- only easier if we work on master for new code and v2.2 for old code :) It's always more complicated when the code diverges more and more. Fortunately we don't have a big amount of blockers. => hope so :p ;) we didn't do a lot of risky changes in 2.2 release, I think. I'm confident :D
    (Oleg) I feel like developing on master isn't "concrete" rule for now, we do like we do, and in case we feel we can't do our ng work on master anymore we can always switch - that's what I have in mind :) For now it seems more or less ok to work on master....
    (Julien) yep I agree, if we really can't do a change without breaking everything, we'll need a branch. But let's try to not break :)
    (Steve) Ya I agree we don't have to branch right now

Actions for next sprint

Nothing