Gaia/SMS/Scrum/FxOS-S8

From MozillaWiki
< Gaia‎ | SMS‎ | Scrum
Jump to: navigation, search

List of bugs

SMS issues handled by the SMS subteam (blocks the sprint bug 1207091)

Bugzilla link

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Resolution
1176976 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages][Drafts] Remove the draft saving/replacing action menu --- No cf_feature-b2g [sms-sprint-FxOS-S8 p=1][sms-sprint-FxOS-S3][sms-sprint-FxOS-S4] FIXED
1198266 [Messages] Use ConversationService in the application --- No cf_feature-b2g [sms-sprint FxOS-S8 p=1][sms-sprint FxOS-S7 p=3][sms-sprint FxOS-S6 p=2] WONTFIX
1201016 [Messages][NG] Migrate the current Message manager event handling to NGA --- No cf_feature-b2g [sms-sprint FxOS-S8 p=1][sms-sprint FxOS-S7 p=1] WONTFIX
1206678 Steve Chung [:steveck] Outgoing MMS contains subject that was typed by user, but then hidden 2.5+ No cf_feature-b2g [p=1] FIXED
1207093 [Messages][Dialer] Implement low storage condition popup --- No cf_feature-b2g [p=2] WONTFIX
1207094 [Messages] Disable appropriate controls when in low storage condition --- No cf_feature-b2g [p=2] WONTFIX

6 Total; 6 Open (100%); 0 Resolved (0%); 0 Verified (0%);


Remaining points and burndown chart

google chart api url for Sprint FxOS-S8

Burndown chart
Remaining points
Start 8
Day 2 8
Day 3 8
Day 4 8
Day 5 8
Day 6 7
Day 7 7
Day 8 7
Day 9 6
Day 10 6
End


SMS issues handled by the SMS subteam outside of the sprint (contains whiteboard "sms-sprint-FxOS-S8")

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Resolution
1176976 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages][Drafts] Remove the draft saving/replacing action menu --- No cf_feature-b2g [sms-sprint-FxOS-S8 p=1][sms-sprint-FxOS-S3][sms-sprint-FxOS-S4] FIXED
1179586 Oleg Zasypkin [:azasypkin][⏰UTC+1] Intermittent apps/sms/test/marionette/conversation_test.js | Conversation Panel Tests General use cases Long SMS thread User can see all messages when scrolls up --- No cf_feature-b2g [sms-sprint-FxOS-S8] FIXED
1203886 Steve Chung [:steveck] The back button in sms conversation view does not always work 2.5+ No cf_feature-b2g [sms-sprint-FxOS-S8] FIXED
1205874 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages] After starting a new conversation from previously saved draft, that conversation will be counted twice when using Select All in Inbox 2.5+ No cf_feature-b2g [2.5-Daily-Testing][Spark][sms-sprint-FxOS-S8] FIXED
1208532 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages][Refactoring] Extract SystemMessageHandler from ActivityHandler --- No cf_feature-b2g [sms-sprint-FxOS-S8] FIXED

5 Total; 5 Open (100%); 0 Resolved (0%); 0 Verified (0%);


All SMS issues tracked for this sprint (target milestone)

Bugzilla link

Full Query
ID Assigned to Summary Blocking b2g Feature b2g Resolution
1176976 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages][Drafts] Remove the draft saving/replacing action menu --- --- FIXED
1206678 Steve Chung [:steveck] Outgoing MMS contains subject that was typed by user, but then hidden 2.5+ --- FIXED
1207091 SMS sprint FxOS-S8 --- --- WONTFIX

3 Total; 3 Open (100%); 0 Resolved (0%); 0 Verified (0%);


Sprint planning

Minutes are on a separate page.

Daily meetings

Day 2: 23rd September

Steve

  • bug 1179628 - [Messages][NG] Lay out Settings service structure
    • Requesting feedback, but will be in background work.
  • bug 1201016 - [Messages][NG] Migrate the current Message manager event handling to NGA.
    • Waiting for feedback
  • bug 1207094 - [Messages] Disable appropriate controls when in low storage condition
    • Start to test the new lowStorage flag in deviceStorage and implement the device storage(might be device storage shim).
  • bug 1206678 - Outgoing MMS contains subject that was typed by user, but then hidden
    • Ni? Morpheus about how to deal with subject removal.

Today:

  • Read the replay about the conversation service.
  • Low storage work.

Oleg

  • bug 1176976 - [Messages][Drafts] Remove the draft saving/replacing action menu
    • Got review and handling comments (in progress).
  • bug 1206093 - [Messages][Tests] Leverage "client.switchToShadowRoot" to tap on gaia-header action button
    • Guiding contributor on this issue (in progress).
  • bug 1179586 - Intermittent apps/sms/test/marionette/conversation_test.js | Conversation Panel Tests Action links in messages Send message to contact number
    • Investigated this one a bit, was not able to reproduce on my machine, but was more lucky on my slow gaia-vagrant setup;
    • Updated my gaia-vagrant (https://github.com/azasypkin/gaia-vagrant) script to support node v0.12 and npm v2;
    • Fixed tiny issue that I've noticed while working on gaia vagrant setup - "bug 1206687 - Python setup script points to the pip install/upgrade guide that doesn't exist anymore" :)
  • bug 1206844 - Adding Firefox Emoji font support
    • Quickly looked at the PR, asked why we didn't use shared CSS var for the Emoji font - want to have closer look today.
  • bug 1198266 - [Messages] Use ConversationService in the application
    • No progress (awaiting feedback).

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.

Julien

  • Absent/no report

Day 3: 24th September

Steve

  • bug 1179628 - [Messages][NG] Lay out Settings service structure
    • Got some feedback and move to background work.
  • bug 1201016 - [Messages][NG] Migrate the current Message manager event handling to NGA.
    • Might need to migrate some event handling workaround to bug 1207094.
  • bug 1207094 - [Messages] Disable appropriate controls when in low storage condition
    • I think it's doable to finish the devicestorage feature as service(shim). Will reply questions later.
  • bug 1206678 - Outgoing MMS contains subject that was typed by user, but then hidden
    • Still waiting for UX replies.
  • bug 1203886 - The back button in sms conversation view does not always work
    • Take some time for investigation and gave a small patch.

Today:

  • Read the replay about the conversation service.
  • Low storage work.
  • Some blockers if they have any progress.

Julien

  • did a first patch for bug 1207093: popup for low storage condition (not working)
  • gave feedback for stas patch for bug 1203108: conversion to l20n
  • finished the review for bug 1037620 (late arrival notice) from contributor

Today: I want to:

  • continue handling review/feedback/NI queue
  • continue work on the low storage condition

If all this moves forward well, I could:

  • continue the prototype caching the thread list to a single db (including contacts/drafts/etc).

Oleg

  • bug 1176976 - [Messages][Drafts] Remove the draft saving/replacing action menu
    • Handled review comments and asked for the next round of review (in review).
  • bug 1198266 - [Messages] Use ConversationService in the application
    • No progress (awaiting feedback).

Other:

  • bug 1206093 - [Messages][Tests] Leverage "client.switchToShadowRoot" to tap on gaia-header action button
    • Still the same, guiding contributor on this issue (in progress).
  • bug 1206844 - Adding Firefox Emoji font support
    • Trying to get more info from Pavel to better understand what it's and how we should handle it (in progress).
  • bug 1179628 - [Messages][NG] Lay out Settings service structure
    • Left early feedback.
  • bug 1207093 - [Messages][Dialer] Implement low storage condition popup
    • Left early feedback.
  • Attended NGA meeting on behalf of Julien.

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.

Day 4: 25th September

Steve

  • September 28th is national holiday in Taiwan, sorry I forgot to raise it in planning...
  • bug 1179628 - [Messages][NG] Lay out Settings service structure
    • Background work.
  • bug 1201016 - [Messages][NG] Migrate the current Message manager event handling to NGA.
  • bug 1207094 - [Messages] Disable appropriate controls when in low storage condition
    • Migrate event handling workaround for devicestorage service(shim).
  • bug 1206678 - Outgoing MMS contains subject that was typed by user, but then hidden
    • Still waiting for UX replies.
  • bug 1203886 - The back button in sms conversation view does not always work
    • Create a patch for review. I tried to implement integration test but the second tap event is slower than panel switch timing. The transition logic runs in server side is much faster and tap event from client could not insert the topanel action in time.
      (Oleg) Yeah, I've left a proposition with several taps on notification that calls toPanel several times under the hood, you can try this if you have time or just left it to a separate bug :)
      (Steve) So you already implement the specific several taps action in notification integration test?
      (Oleg) We have tests and helper methods to create notifications, and have System libs to tap on them I think and we have activities as well - maybe we can wrap up something out of it :) We just need to open activity in test app while in Conversation view, create notification for the right thread, and tap several times on it, then close activity and try to go back to Inbox.
      (Steve) I wrote the navigation integration test for it already, but the problem is tap action is not fast enough to trigger the problem, even I call conversation.tap();conversation.tap(); continuously without timeout waiting.
      (Oleg) Right, that is why I thought the trick (and actually the bug QA noticed) with opened activity (while document is hidden we don't change panel, so that we can call toPanel several times) can do the job, but maybe I'm missing something.
      (Julien) otherwise maybe we can use scriptWith and call "click" twice on the link ?
      (Oleg) Hmm, maybe it will work as well, I'd try :)

Today:

  • Low storage work.
  • Working on some blockers if they have any progress.

Julien

  • continued work on bug 1207093: popup for low storage condition, now it works on firefox, but bug 1208113 is occurring. I tried to convert it to new-style components but I don't think we should do that here. Will continue work on this today.
  • gave feedback on blocker bug 1203886 about the back button that doesn't work
  • gave feedback on rishav's patch for bug 1180470

Today: I want to:

  • continue handling review/feedback/NI queue
  • continue work on the low storage condition

Oleg

  • bug 1176976 - [Messages][Drafts] Remove the draft saving/replacing action menu
    • No progress (in review).
  • bug 1198266 - [Messages] Use ConversationService in the application
    • Replied to Steve's question (awaiting feedback).
  • bug 1179586 - Intermittent apps/sms/test/marionette/conversation_test.js | Conversation Panel Tests General use cases Long SMS thread User can see all messages when scrolls up
    • Investigated and prepared PR that should fix intermittent failures (awaiting feedback).
  • bug 1205874 - [Messages] After starting a new conversation from previously saved draft, that conversation will be counted twice when using Select All in Inbox.
    • Investigated, figured out the root cause, want to work on fix today (in progress).

Other:

  • bug 1206093 - [Messages][Tests] Leverage "client.switchToShadowRoot" to tap on gaia-header action button
    • Still the same, guiding contributor on this issue (in progress).
  • bug 1206844 - Adding Firefox Emoji font support
    • Reviewing, have to figure out why it partially works for me even without patch (all emojis are recognized except for the fancy numbers, they're recognized as ordinary numbers without patch), the first guess is that if some symbol can't be found in the default font it falls back to another one and eventually finds the right glyph in Emoji font, but numbers are found in the default font. Will ask Pavel (in progress).
      (Julien) emojis are complicated stuff: some symbols are in the normal unicode and part of some fonts, some other symbols are part of unicode's astral plane and part of other fonts
      (Oleg) Ugh, I thought that all emoji's symbols are not normal :) Got it, thanks for the explanation!
      (Julien) I read a very useful article some days ago about it, I'll try to find it back for you.
      (Oleg) Thanks!
      (Julien) http://eev.ee/blog/2015/09/12/dark-corners-of-unicode/

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.

Day 5: 28th September

Julien

  • continued work on bug 1207093: proposed a first review, was reviewed by Oleg and Gabriele already. Will answer questions and fix review comments today
    • created bug 1208456 that appears in Firefox.
    • filed a bug for the work in Settings
  • reviewed blocker bug 1203886 about the back button that doesn't work
  • gave feedback on bug 1179586 (test fix)
  • gave another feedback on bug 1180470 (have a setting to disable sending a read report)

Today: I want to:

  • continue handling review/feedback/NI queue
  • continue work on the low storage condition

Oleg

  • bug 1176976 - [Messages][Drafts] Remove the draft saving/replacing action menu
    • No progress (in review).
      (Julien) will look today !
      (Oleg) Thanks!
  • bug 1198266 - [Messages] Use ConversationService in the application
    • No progress (awaiting feedback).
  • bug 1179586 - Intermittent apps/sms/test/marionette/conversation_test.js | Conversation Panel Tests General use cases Long SMS thread User can see all messages when scrolls up
    • Got r+, landed (landed).
  • bug 1205874 - [Messages] After starting a new conversation from previously saved draft, that conversation will be counted twice when using Select All in Inbox.
    • Prepared PR, asked for review (in review).
  • bug 1192263 - [Messages] We load Inbox before going to the notification conversation when app is run via notification click.
    • Roughly looked at this issue, want to try fix "bug 1208532 - [Messages][Refactoring] Extract SystemMessageHandler from ActivityHandler" first if it doesn't take too much time, has some WIP (in progress).

Other:

  • bug 1207093 - [Messages][Dialer] Implement low storage condition popup
    • Started to review PR, should finish soon (review in progress).
  • bug 1206093 - [Messages][Tests] Leverage "client.switchToShadowRoot" to tap on gaia-header action button
    • Guided contributor, r+'ed (almost landed).
  • bug 1206844 - Adding Firefox Emoji font support
    • Reviewed, PR still have issues with displaying numbers (review on hold, waiting for resolution of found issues)

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.

Steve

  • Absent/no report

Day 6: 29th September

Steve

  • Unexpected typhoon day in Taipei, so I can only do some trivial things within limited time.

Julien

Not much more to add ! Today: I want to:

  • continue handling review/feedback/NI queue
  • continue work on the low storage condition

Oleg

  • bug 1176976 - [Messages][Drafts] Remove the draft saving/replacing action menu
    • Got r+, fixed last review comments, but eventually, during final on-device testing, found out that I had to rollback on of the suggestions (almost landed).
    • Filed mentored integration test bugs to cover that newly discovered issue.
  • bug 1198266 - [Messages] Use ConversationService in the application
    • No progress (awaiting feedback).
  • bug 1205874 - [Messages] After starting a new conversation from previously saved draft, that conversation will be counted twice when using Select All in Inbox.
    • No progress (in review).
  • bug 1208532 - [Messages][Refactoring] Extract SystemMessageHandler from ActivityHandler
    • Almost no progress on this one since Tuesday, should have time today (in progress).

Other:

  • bug 1207093 - [Messages][Dialer] Implement low storage condition popup
    • Reviewed (reviewed).
    • Filed quick-tap-and-break-UI bugs I've discovered some time ago, but forgot to file bugs :)
  • bug 1206093 - [Messages][Tests] Leverage "client.switchToShadowRoot" to tap on gaia-header action button
    • Landed, pointed contributor to other unassigned gaia::sms mentored bugs (landed).

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.

Day 7: 30th September

Steve

  • bug 1179628 - [Messages][NG] Lay out Settings service structure
    • Background work, no progress.
  • bug 1201016 - [Messages][NG] Migrate the current Message manager event handling to NGA.
    • No progress.
  • bug 1207094 - [Messages] Disable appropriate controls when in low storage condition
    • Migrate event handling workaround for devicestorage service(shim).
  • bug 1206678 - Outgoing MMS contains subject that was typed by user, but then hidden
    • Created a patch for original behavior and create another bug for the subject removal discussion.
      (Julien) I left a comment on github ;) Thanks!
  • bug 1203886 - The back button in sms conversation view does not always work
    • Verified the notification part and it should be fixed as well.

Today:

  • Low storage work.
  • Review the patches.
  • Working on some blockers if they have any progress.

Julien

Reminder: I'll be at the Paris-Web conference tomorrow and friday. I'll start to handle things during this afternoon so I won't be very much available this afternoon either.

  • continued work on bug 1207093: finished fixing comments, but I had more questions to Katie before requesting a new review.
  • spent a lot of time on bug mail today. Looks like we have a "rich paste" feature that landed and breaks us in a lot of cases... I wish we were notified of such features in advance. This sounds like some not easy work for us to handle :/ See for example bug 1209900 and bug 1207083.
    (Steve) Maybe I can ask the gecko devs to know if it's possible to disable the rich paste in message app. I don't think we will have sufficient time for handling the image paste feature in 2.5...
    (Julien) Yeah I asked for it in bug 1207083 already... I think we could do it if people tell us it's really super important. But then we'll likely get blockers for next 2 months about it.
    (Steve) BTW the wrong cursor position in bug 1207083 looks familiar... It seems related to the br element in contenteditable element and the cursor position will be misplaced when the delete the
    (Oleg) Not sure if it's related, but we have this one as well 1183595, when cursor is misplaced in subject field.

Today: I want to:

  • continue handling review/feedback/NI queue
  • continue work on the low storage condition

Oleg

  • bug 1176976 - [Messages][Drafts] Remove the draft saving/replacing action menu
    • Tested on device again and could not spot anything wrong, so landed :) (landed)
    • Will keep eye on possible regressions.
  • bug 1198266 - [Messages] Use ConversationService in the application
    • Got Steve's feedback, waiting for Julien's one :) (awaiting feedback).
  • bug 1205874 - [Messages] After starting a new conversation from previously saved draft, that conversation will be counted twice when using Select All in Inbox.
    • No progress (in review).
  • bug 1208532 - [Messages][Refactoring] Extract SystemMessageHandler from ActivityHandler
    • Moving forward with this, I hope to have wip for feedback today (in progress).

Other:

  • Noticed ready-to-land PR from "bug 1140344 - [marionette-apps] Support switching between main and inline activity app frames" has been forgotten :) So asked Johan to land this, so it's landed and we have chance to write tests for Drafts shared between two app instances. And other NGA related things as well since we use SharedWorkers, BC.
    (Steve) That's awesome :)
    (Oleg) Heh, yeah, but we need to try it out to see if it really works as expected :) I hope so.
  • Triaged some draft dialog and auto-draft-saved bugs;
  • Tried to help Rishav with the unit tests for his bug.

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.

Day 8: 1st October

Steve

  • bug 1179628 - [Messages][NG] Lay out Settings service structure
    • Background work, no progress.
  • bug 1201016 - [Messages][NG] Migrate the current Message manager event handling to NGA.
    • No progress.
  • bug 1207094 - [Messages] Disable appropriate controls when in low storage condition
    • I found that there's some cases still missing(like compose view recipient and option). Will raise it in the bug.
  • bug 1206678 - Outgoing MMS contains subject that was typed by user, but then hidden
    • Patch updated per comment
  • Review/feedback for some bugs

Today:

  • Low storage work.
  • Give some feedback for Oleg's patch about the system message.
  • Working on some blockers if they have any progress.
  • Check if we need to do something for avoiding rich-text copy paste.

Oleg

  • bug 1198266 - [Messages] Use ConversationService in the application
    • No progress since yesterday (awaiting feedback).
  • bug 1205874 - [Messages] After starting a new conversation from previously saved draft, that conversation will be counted twice when using Select All in Inbox.
    • Got r+, fixed review comment, rebased and landed (landed).
  • bug 1208532 - [Messages][Refactoring] Extract SystemMessageHandler from ActivityHandler
    • Prepared WIP patch and asked for early feedback, working on fixing tests in the meantime (awaiting feedback, in progress).

Other:

  • bug 1206844 - Adding Firefox Emoji font support
    • One more review round here, still needs some work, involved UX and tested perf with Raptor - don't see anything significant - I wanted to check if new font have impact as we started to use it in Inbox.

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.

Julien

  • Absent/no report

Day 9: 2nd October

Steve

  • bug 1179628 - [Messages][NG] Lay out Settings service structure
    • Background work, no progress.
  • bug 1201016 - [Messages][NG] Migrate the current Message manager event handling to NGA.
    • No progress.
  • bug 1207094 - [Messages] Disable appropriate controls when in low storage condition
    • Create a WIP for early feedback, will list some missing part for UX on bug and some drawback in the code on github.
  • bug 1206678 - Outgoing MMS contains subject that was typed by user, but then hidden
    • In review.
  • Review/feedback for some bugs

Today:

  • Low storage work.
  • Give some feedback for Oleg's patch about the system message.
  • Working on some blockers if they have any progress.
  • Check if we need to do something for avoiding rich-text copy paste.

Oleg

  • bug 1198266 - [Messages] Use ConversationService in the application
    • No progress (awaiting feedback).
  • bug 1208532 - [Messages][Refactoring] Extract SystemMessageHandler from ActivityHandler
    • Mostly worked on this one, rewrote a big portion of SystemMessageHandler related tests, working on it (awaiting feedback, in progress).

Other:

  • bug 1206844 - Adding Firefox Emoji font support
    • Worked with Pavel to finish the patch, hopefully will have final review today (review in progress).
  • Replied with clarifying comments in several bugs.

Today:

  • Will handle review/feedback/need-info requests (Steve's subject visibility patch is in priority);
  • Will work on review comments and assigned bugs.

Julien

  • Absent/no report

Day 10: 5th October

Steve

  • bug 1179628 - [Messages][NG] Lay out Settings service structure
    • Background work, no progress.
  • bug 1201016 - [Messages][NG] Migrate the current Message manager event handling to NGA.
    • No progress.
  • bug 1207094 - [Messages] Disable appropriate controls when in low storage condition
    • Create a WIP for early feedback, will list some missing part for UX on bug and some drawback in the code on github. Waiting for early feedback
  • bug 1206678 - Outgoing MMS contains subject that was typed by user, but then hidden
    • Landed.
  • Rich text copy paste: Boris will disable it for 2.5
    (Julien) OK, good to know; we can plan ahead our work to support it post-2.5 :)
    (Steve) I think they don't have any idea about the proper handle inside message, will keep in touch.
    (Julien) Email has the same issue; we need an event to handle it, instead of Gecko handling it automatically...
    (Steve) It seems the only way if we want to insert the image as attachment. Maybe we can simply have a element attribute or css property to limit the text past only in message input for near future.
    (Julien) yeah, but it would be really cool to support image paste :D
    (Steve) Yeah I understand ;)
  • Reviewing the systemMessage handler, it's not finished yet but it should be in the right direction. And we want to rewrite message receiving part for long time ago so it's good to see the changes.

Today:

  • Low storage work.
  • Give some feedback for Oleg's patch about the system message.
  • Working on some blockers if they have any progress.

Julien

Sorry, not much happened related to SMS for me :) In case you don't know, the "low storage" feature got a "no go", so it's no more 2.5... We can still go on and finish it behind a flag though.

(Oleg) I'm curious what happened? :)
  • (Julien) I think they fear about regressions.
    (Steve) The decision making process is horrible in 2.5....
    (Julien) EPM and some developers (incl me) started looking at the feature in August but there has been a lot of inertia from some teams, likely because they were also busy with other stuff. We don't plan ahead enough with "big blocks of features", somewhat like we did for Milestone 1 (but that we didn't do since then BTW :) )
    (Steve) So how about the ongoing low storage patches, like finish them and disabled or simply pending?
    (Julien) for the dialog patch, it's easy because nobody uses it, so I think i'll just go ahead and merge; for the "input disabling", I think it should be disabled with a boolean in our Settings object. What do you think ?
    (Steve) I do have a flag(it's in device storage client instead of settings) in the patch, so it's fine for me.
    (Julien) OK ! (I think we should have it in Settings though :p)

Got an idea today about how we could use "async" scripts, I'd like to experiment... maybe next "hacking day" ;)

(Oleg) Ah, I've just realized we didn't have hack day this month? Or I just missed?
(Julien) nope, nobody scheduled it (and I still haven't sent the result of last one -- will try to do it today :/)

Today: I want to:

  • read bugmail
  • handle review/feedback/NI queue
  • continue work on the low storage condition

Oleg

  • I'll be on PTO on Friday (moved my b-day Thursday PTO to Friday :))
  • bug 1198266 - [Messages] Use ConversationService in the application
    • No progress (awaiting feedback).
  • bug 1208532 - [Messages][Refactoring] Extract SystemMessageHandler from ActivityHandler
    • Fixed all affected unit tests, especially refactored sms-received and notification ones, started to work on few integration tests for the sms-received system message just to have something for the start (one for sms and one for class-0 message as we don't have any for class-0 messages) (awaiting feedback, in progress).

Other:

  • bug 1206844 - Adding Firefox Emoji font support
    • Worked with Pavel to finish the patch, proposed simpler way to style "sending" state messages that contain emojis, waiting for Pavel's reply to Tim (honestly I'm not sure how it should be done in ideal case). Do you guys have any ideas on how it should be handled? Should gecko manage it somehow as Tim suggests or ... ?
      (Julien) if you add a feedback or needinfo on the bug, I'll try to look at it; otherwise I'll forget :p
      (Oleg) Sure, will ni? :)
  • bug 1206678 - Outgoing MMS contains subject that was typed by user, but then hidden
    • Reviewed PR.
  • bug 1148719 - [Message]The recipient won't be saved in draft if we delete all message in this conversition while editing new message.
    • Explained old idea to UX guys, got reply today - need to read through it.

Today:

  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.

Day 11: 6th October

Steve

  • Not much progress today since there is a SCVP events almost occupied half of the day :/
  • bug 1179628 - [Messages][NG] Lay out Settings service structure
    • Background work, polishing based on Oleg's comment.
  • bug 1201016 - [Messages][NG] Migrate the current Message manager event handling to NGA.
    • No progress.
  • bug 1207094 - [Messages] Disable appropriate controls when in low storage condition
    • Waiting for early feedback
  • Reviewing the systemMessage handler, it's not finished yet but it should be in the right direction. And we want to rewrite message receiving part for long time ago so it's good to see the changes.

Today:

  • Low storage work.
  • Review Oleg's patch about the system message.
  • Working on some blockers if they have any progress.

Julien

(sorry, I'm filling it in advance because I'll be in the subway during our normal time) Didn't move forward much things, mostly read my bug mail. Today I want to continue this but maybe start with bugzilla requests... Today: I want to:

  • read bugmail
  • handle review/feedback/NI queue
  • continue work on the low storage condition

Oleg

  • I'll be on PTO on Friday.
  • bug 1198266 - [Messages] Use ConversationService in the application
    • No progress (awaiting feedback).
  • bug 1208532 - [Messages][Refactoring] Extract SystemMessageHandler from ActivityHandler
    • Finished integration tests, handled feedback comments, tested on device and asked for review (in review).

Other:

  • bug 1206844 - Adding Firefox Emoji font support
    • Finished review and tested on device, waiting for input from Pavel/Julien/Tim.
  • bug 1207094 - [Messages] Disable appropriate controls when in low storage condition
    • Started to look into Steve's PR, should finish soon (feedback in progress).
  • bug 1148719 - [Message]The recipient won't be saved in draft if we delete all message in this conversition while editing new message.
    • Marked as post-2.5 feature and moved to backlog.
  • Guided contributor on IRC on "bug 1209963 - [Messages][Refactoring] InboxView.deleteThread should not attempt to close notification for the thread-less drafts";
  • Guided contributor on "bug 1209419 - [Messages][Tests] Add basic integration tests for the Conversation view Edit mode".

Today:

  • Today is bug-mail day - will skim through mails;
  • Want to help with "bug 1210704 - Add service worker benchmark for Flame and Aries".
  • Will handle review/feedback/need-info requests;
  • Will work on review comments and assigned bugs.

Demos

Retrospective

Previous sprints' actions

From 2.1S3:

  • Look into VM with gaia dev environment
    Nothing more done in this sprint

From 2.1S5:

  • in planning for sprint N, we pick some items we want to do in sprint N+1 to ask early questions to UX and Designers (esp refresh bugs, but also bugs with UX changes)
  • we'll add screenshots of panels in Wiki, with the various cases for these panels, to help analyzing change impacts and not forgetting things
    Oleg started this: https://wiki.mozilla.org/Gaia/SMS/Current_App_State

From 2.2S4:

  • undercommit in the sprints.
  • use bugs and github's PR for spec definition and changes

From 2.2S14:

  • move more discussions to #gaia
  • figure out 2.5 features for SMS

From FxOS-S3:

  • split patches as much as we can when we develop it, and split bugs as much as we can when planning them.

From FxOS-S7:

  • stand-up at 11:30am CET / 5:30pm Taipei

What was good in the last sprint

  • I feel this sprint was quite productive for me;
  • I'm glad to see new Messages app contributors;
  • We've resolved several blockers;

What was bad in the last sprint

  • Low storage is deprioritized _unexpectedly_. Not our fault, but still I think it's bad when we have a lot of stuff to do :)
  • I overestimated my available time, as a result we didn't finish some tasks directly because of me :(
  • The low storage disabling part didn't progress as much as I expected, and some spec is still not clear to me(Althought it's pending now)

Any questions

  • October is for blockers? (just confirming that nothing has changed _again_ :))
    • Actually in this sprint we'll need to focus on low storage first. - not anymore, right?
    • Not anymore ;) I think we want to finish unfinished bugs (or maybe keep that for background ?) but focus is definitely on blockers -- including blockers from other teams
    • Yeah, I think we can have low storage tasks in background as you've already started them and we don't want them to become very obsolete :)
  • Should we take care/investigate about perf regressions in this sprint?
    • I think so; Oleg I think one of your patches could make it possible to decide whether we use workers or not, right ?
    • Yeah, at least we need to decide if it's OK to have "upgradable" services (in window on startup and then in workers). If the approach looks good to you, I can take a closer look to numbers.
    • I think it's our first best approach for now. If this doesn't work we can try other ideas (like moving back at everything in the window "statically".
    • we can discuss a little more during the planning
    • We should finish the upgrade service first and see what we'll need to do later in following sprints(I feel that we still have lots of things for improvement...)
    • I'd like to try something around async scripts -- but I think it's a bigger work.

Actions for next sprint

None