Confirmed users
821
edits
Gaia/SMS/Scrum/2.2S5: Difference between revisions
→Day 5: 2nd February
| Line 255: | Line 255: | ||
=== Day 5: 2nd February === | === Day 5: 2nd February === | ||
====Steve==== | |||
* Fix text selection bugs. I only set user-select: none to main panel but not for other widgets, and we also need to set for position: absolute elements(see MDN, -moz-user-select is not inherited by absolutely positioned elements). So I think there is no better selector than universal selector | |||
*: (Julien) :( with the universal selector, will it work if we set user-select: text for a specific element, I mean, will it be inherited by its child elements? | |||
*: (Steve) Sorry not sure what you mean, could child elements inherit user-select: text? | |||
*: (Julien) I mean, if we use "* { user-select: none }", can we add ".bubble { user-select: text }" and the subchildren (like p and other elements) will be selectable? Or do we need ".bubble *" ? | |||
*: (Steve) hmm, good question, I haven't tried this since currently we don't have this scenario, maybe I can test it for whole message container. | |||
*: (Julien) yeah, the bubble was an example, but I'm sure we have similar cases :) If we need to use the universal selector everywhere, then I'm not really OK with this. If we don't, then ok :) | |||
* {{Bug|1089154}} - [Messages] investigate scoping CSS rules | |||
** Patch given for feedback and test for other apps | |||
Today: | |||
* Investigative some text selection issues | |||
* More testing on {{Bug|1089154}} for other apps used shared styling | |||
* Create RTL refinement for network-alerts | |||
====Julien==== | |||
* {{Bug|1089920}}: fix gaia-header performance | |||
** no update on friday | |||
* {{Bug|1082618}}: add a README file | |||
** no progress | |||
* {{Bug|1122649}}: mozSettings has a synchronous penalty | |||
** not much more move for now. I don't know if we'll be able to make it better. | |||
* still no move for {{Bug|1115796}}'s issue even if Gandalf did measurements that give the same result than mine | |||
* {{Bug|1127550}}: looks like we can't send a message while a thread is loading... | |||
** tried to reproduce with workloads or my old data, but I can't; I'll need to try with my current data. Also maybe it's been fixed since my current dogfooding build has been done (it's several weeks old now). | |||
Others: had some meetings with HR about inclusiveness. | |||
Today: | |||
I want to (again): | |||
* more review | |||
* investigate if read-ahead value changes something in SMS | |||
* move forward some background matters (organize group MMS bugs, and drafts handling issues started some weeks ago) | |||
* land the README file | |||
====Oleg==== | |||
* {{Bug|1122501}} - [Messages][Drafts] Unsaved draft is silently discarded when user tries to forward message | |||
** No updates for now (in review). | |||
* {{Bug|1104961}} - Intermittent share_activity_test.js | Messages as share target Share via Messages Activity close button Should return to Thread panel if in Participants panel | |||
** Tried on Treeeherder one more time and landed (landed). | |||
* {{Bug|1121766}} - Intermittent failing test, TEST-UNEXPECTED-FAIL | apps/sms/test/marionette/composer_test.js | Messages Composer Messages Composer Test Suite Message char counter and MMS label | |||
** Patch from previous bug reduced number of intermittent failures in this test, but we still have some that I currently investigating, trying to debug and reproduce locally and trying not to spend much time on it. Will keep you updated (in progress) | |||
Other: | |||
* Friday was unlucky day, found and investigated a bit several regressions: | |||
** {{Bug|1127773}} - [Messages] It's impossible to scroll content inside message input - added video per :kats request. | |||
** {{Bug|1127898}} - [Messages] Send button is misaligned if message input has more than one line of text - :dholbert will look into, it looks like a conflict of display:flex and height: 100% on the same element, if we remove height: 100% everything works, but it's still regression. | |||
** {{Bug|1128093}} - [Messages] It's impossible to scroll participants list in group MMS report panel - per regression window it doesn't look like the same issue as we have with message input. | |||
** {{Bug|1128337}} - [Messages] Last thread in thread list is a bit cut off when in edit mode | |||
** Some weirdness with gaia-header buttons, especially with Settings button, when you try to tap on it from the right side, it's visible that button style changed to "hover", but action isn't called, when you tap somewhere between "New message" and "Settings" buttons, both change style to hover. It became harder for me to call Settings, I'd say I hit that "non-actionable" area 4 times of 10 while using Flame. I don't see these problems in v2.2 - will talk to Wilson in person today :) | |||
* Looked at Steve's "css scoping" patch - changes look good for me, I'm only worried about :last-child -> ".last" replacement in data-type="action" dialogs - at the first look there are too much dialogs use relies on it that doesn't use OptionMenu for it (the only thing that takes care about adding ".last" for its buttons), but don't have better idea right now other than carefully update all cases. Also tried to run performance tests with the patch to see improvement, but for 20 RUNS on eng build current master gives better results :( I use this command to get moz-visual-complete: "RUNS=20 APP=sms MOZPERFOUT=~/perf.json MARIONETTE_RUNNER_HOST=marionette-device-host make test-perf" and "". Steve, am I doing smth wrong? | |||
Today: | |||
* Will handle review/feedback/need-info requests; | |||
* Will work on review comments and assigned bugs | |||
====Teja==== | |||
*{{Bug|961572}} - [Messages][Refactoring] Implement a new independent cancel button for information view's header | |||
** About to merge. yay \o/ .Thanks Steve. | |||
*{{Bug|986510}} - [Messages app] Replace menu icon with settings icon when no messages in app | |||
** Needed to add '!important' to override the gaia-header properties. | |||
** Made changes as Julien suggested.Thanks Julien. | |||
** Under review. | |||
Today: | |||
*{{Bug|1124624}} - Add transition to the group view panel | |||
** Start working. | |||
=== Day 5: 3rd February === | === Day 5: 3rd February === | ||
=== Day 5: 4th February === | === Day 5: 4th February === | ||