Confirmed users
821
edits
Gaia/SMS/Scrum/FxOS-S3: Difference between revisions
/* Day 15: July 22nd
(/* Day 14: July 23rd) |
(/* Day 15: July 22nd) |
||
| Line 720: | Line 720: | ||
* Will work on review comments and assigned bugs. | * Will work on review comments and assigned bugs. | ||
=== Day 15: July 22nd === | === Day 15: July 22nd === | ||
====Steve==== | |||
* {{Bug|1184865}} - [Messages][NG] Replace some methods in MessageManager with messaging service in conversation view. | |||
** Sync with Oleg's idea about the iframe for shim | |||
* {{Bug|1179628}} - [Messages][NG] Lay out Settings service structure | |||
** Starting {{Bug|1180591}} for settings shim. | |||
* {{Bug|1180591}} - [Messages][NG] mozSettings shim Implementation | |||
** Left some minor question/thoughts on github. | |||
* Faced some integration test problem while removing the Threads dependency... Will take some time to figure out. | |||
Today: | |||
* Layout for mozSettings/mozConnections shim | |||
* Still working on messaging service in conversation view(could be only the retrivalMMS method since settings shim/service is not ready). | |||
* Review Oleg's patch about first conversation service method migration. | |||
====Julien==== | |||
* still worked on navigation ({{Bug|1162030}}): | |||
** worked on a separate bug ({{Bug|1185983}}) to make Compose focus handling saner -- so that I can simplify things in the navigation patch. I have one case that doesn't work properly still, should be fixed today (I hope :p). | |||
* did some long standing reviews: | |||
** {{Bug|1055357}} to remove role=search in our composer (from a contributor) | |||
** {{Bug|1167144}}: reduce use of Threads.active from Steve (will be very useful then, when activeThread will be fetched with a service) | |||
** had a quick look at {{Bug|1180591}} for the settings shim | |||
Today: | |||
I want to: | |||
* move forward the navigation patch: continue creating new tests, work on the focus handling to make it more explicit and less heuristic. | |||
* more reviews for other app than SMS | |||
If all this moves forward well, I could: | |||
* continue the prototype caching the thread list to a single db (including contacts/drafts/etc). | |||
* I'd like to work on the deduplication logic for network alerts, it seems important for users ({{Bug|1067938}}) | |||
====Oleg==== | |||
* {{Bug|1155534}} - [Messages][NG] Extract NewMessage view from Conversation view | |||
** No updates (in background). | |||
* {{Bug|1176976}} - [Messages][Drafts] Remove the draft saving/replacing action menu | |||
** No updates (in background). | |||
* {{Bug|1172902}} - [Messages][NG] Use SimpleOfflineCache to cache all app resources | |||
** Reviewed PR, will merge today (almost landed). | |||
* {{Bug|1169576}} - [Messages][NG] Implement Conversation service: method for streaming joined threads and drafts list | |||
** Prepared more or less good looking WIP and asked for early feedback. PR contains second commit just for you to be able to run it in browser if you want (awaiting feedback) :) | |||
** Will see how we can improve performance and pin point intermittent issues I see in browser in the meantime. + unit tests | |||
**: (Steve) What kind of intermittent issues did you faced? Only in browser mode? | |||
**: (Oleg) Sometimes when I refresh browser with ctrl-f5 nothing works in my shim_host vs bridge setup... Yeah, I've only seen this in browser, but haven't tested heavily on device yet. I was first suspecting that it's something related to SharedWorker - but need to investigate. | |||
**: (Julien) no message in the logs ? | |||
**: (Oleg) There is message like "no response", when bridge request is timed out - happens usually when it can't connect to other party or other party doesn't respond at all. Will reach out to Wilson if/when I find more details. And it seems we can't pass Errors (and mozMobile entities, as we know) to other end since some (all?) are not "structure clonable"... But that's minor, just in case you notice "data clone error" entries in logs that don't have neither origin nor line number. | |||
**: (Julien) so we can't do Promise.reject(new Error) in services ? | |||
**: (Oleg) I'll better double check and let you guys know :) | |||
**: (Julien) I think this should be handled by the threads library if it's not possible, it's a too common case :/ but yeah better dble check. | |||
Other: | |||
* Reviewed "{{Bug|1180591}} - [Messages][NG] mozSettings shim Implementation"; | |||
* Was waiting for the screening with candidate, but it has been eventually cancelled due to urgent candidate's family reasons. | |||
Today: | |||
* Will handle review/feedback/need-info requests; | |||
* Will work on review comments and assigned bugs. | |||
=== Day 16: July 23rd === | === Day 16: July 23rd === | ||
====Steve==== | ====Steve==== | ||