Gaia/SMS/Scrum/FxOS-S3: Difference between revisions

Jump to navigation Jump to search
/* Day 14: July 23rd
(/* Remaining points and burndown chart)
(/* Day 14: July 23rd)
Line 716: Line 716:
* Reviewed "{{Bug|1082052}} - [Messages][Refactoring] Return a Promise from SMIL.parse".
* Reviewed "{{Bug|1082052}} - [Messages][Refactoring] Return a Promise from SMIL.parse".
* Organized DraftService bugs a bit, going to work on this in this quarter.
* Organized DraftService bugs a bit, going to work on this in this quarter.
Today:
* Will handle review/feedback/need-info requests;
* Will work on review comments and assigned bugs.
=== Day 15: July 22nd ===
=== Day 16: July 23rd ===
====Steve====
* {{Bug|1184865}} - [Messages][NG] Replace some methods in MessageManager with messaging service in conversation view.
** Ongoing, but  it might conflict with Oleg's patch if we set iframe in index.html. Maybe we will have several iframes before markup splitting and place the iframe html under view folder directly? Then we can have less efforts once we need to split the markup. Or I should add the iframe to conversation's markup directly(but not runnable).
**: (Julien) I don't follow what is your alternative here :) It seems to me that all of what you say is correct so I don't understand the "or" ;)
**: (Steve) I mean, we already split the conversation markup in conversation view folder but not in used now. Maybe I can just append the iframe here and test it manually in local(And still use original message manager method in master).
**: (Julien) I'd be glad if we can use the same code in both split and non-split modes :)
**: (Steve) Ok, will try
* {{Bug|1179628}} - [Messages][NG] Lay out Settings service structure
** Starting {{Bug|1180591}} for settings shim.
* {{Bug|1180591}} -  [Messages][NG] mozSettings shim Implementation
** Left some minor question/thoughts on github.
*  {{Bug|1160049}} -  [Messages] Attach menu should not dismiss when user cancel the replace attachment request
** Take a look since it's 2.5 blocker, should not be difficult to fix.
* Still reviewing Oleg's conversation service/client.
Today:
* Layout for mozSettings/mozConnections shim
* Still working on messaging service in conversation view(could be only the retrivalMMS method since settings shim/service is not ready).
* Review Oleg's patch about first conversation service method migration.
====Julien====
* still worked on navigation ({{Bug|1162030}}):
** finished the separate bug ({{Bug|1185983}}) to make Compose focus handling saner (in review).
** finished unit tests (including new tests)
** now I need to focus on integration tests. I think the failures comes from the fact that they do actions or checks before the end of a transition now. Hopefully I can ask a new review today !! (but today is brantina + Rik's leaving party day, so the afternoon will be short..)
Today:
I want to:
* do the asked reviews (sorry that I did none yesterday :/)
* move forward the navigation patch: integration tests.
If all this moves forward well, I could:
* continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
* I'd like to work on the deduplication logic for network alerts, it seems important for users ({{Bug|1067938}})
====Oleg====
* {{Bug|1155534}} - [Messages][NG] Extract NewMessage view from Conversation view
** No updates (in background).
* {{Bug|1176976}} - [Messages][Drafts] Remove the draft saving/replacing action menu
** Finally found a way to fix drafts tests and fixed them all! Only one thing left in this patch - is to decided how to deal with "draft saved" banner shown in Inbox, will find a way today (in background).
* {{Bug|1172902}} - [Messages][NG] Use SimpleOfflineCache to cache all app resources
** Merged Francisco's PR, but benchmarks with SWW started to crash app/b2g-browser, so investigating (in progress).
* {{Bug|1169576}} - [Messages][NG] Implement Conversation service: method for streaming joined threads and drafts list
** Not much updates since yesterday. Received some feedback already, but haven't looked yet (awaiting feedback)
Other:
* Spent some amount of time to learn how to run new raptor on my machine - I have several problems: it works only with Node v0.12 - so had to upgrade first, then there were problems with running it since it now uses marionette, but it was failing because of globally installed node-gyp - so after removing that I was able to successfully run it. Want to remeasure benchmarks as this new raptor is supposed to give more accurate numbers + want to confirm that it works well with installed hosted app and see how different "app:// + SWW" vs "hosted + SWW" app.
*: (Julien) I had issues with node 0.12 locally -- maybe also because of my node-gyp then? What was your issue, was it a compilation error ?
*: (Oleg) Raptor was failing on run stage with "Error: Module did not self-register."
*: (Julien) I mean, your issue with node-gyp ? My issue was with "ffi-prebuilt" and I had an error when compiling this module. I'll try removing node-gyp because I'd be happy to use node 0.12.
*: (Oleg) Ah, let me remember... IIRC sockit-to-me was not able to compile - it tried to use node-gyp-0.10.4 (my old node version) or something. :rwood also had problem with node-gyp - removing helped. Let me insert some details from #raptor channel. So yeah I've removed node-gyp, gyp deb package as well (suggested by Eli) and then reinstall node-gyp with "npm install -g node-gyp". I also had some permissions issues on my machine - so it may be different :) Also I've seen node-gyp related warnings when I was reinstalling @mozilla/raptor - like "gyp WARN EACCES user "root" does not have permission to access the dev dir "/home/azasypkin/.node-gyp/0.10.40"" Sorry for messy explanation :)
*: (Julien) thanks for the pointers, I'll dig a little from my side as well :) I think node-gyp should definitely be used from node_modules... but not sure if this is possible !
* After upgrading to Node v0.12 integration tests still can be run locally (heard that only Node v.010 + npm v2 worked for some people), I'm happy :)
* Btw, looks like we have new bridge documentation: http://gaia-components.github.io/threads/docs/out/index.html
Today:
Today:
* Will handle review/feedback/need-info requests;
* Will handle review/feedback/need-info requests;
Confirmed users
821

edits

Navigation menu