Electrolysis/Release Criteria/Slow Script: Difference between revisions

Electrolysis/Release Criteria/Slow Script (view source)

Revision as of 21:49, 22 February 2016

45 bytes added , 22 February 2016

More test results.

Azhang

10

edits

@@ Line 11: / Line 11: @@
 Technical details:
-* The slow script timeout will not change with e10s
 * SLOW_SCRIPT_NOTICE_COUNT is the telemetry histogram
+* There should be no differences in the slow script '''reporting''' mechanism between e10s and non-e10s; 1 call to ShowSlowScriptDialog means 1 addition to the histogram regardless of e10s setting. Manual testing supports this.
+* The timeout has changed from 2 to 10 in e10s builds (see https://hg.mozilla.org/mozilla-central/rev/63680efe6d55#l35.12 for before and https://hg.mozilla.org/mozilla-central/rev/5002e9c06365#l2.13 for after). However, the value is correct on all beta versions, from 45.0b1 to 45.0b8 - the timeouts are identical between e10s and non-e10s.
+* :azhang has verified that beta 45 releases with/without e10s both seem to increment SLOW_SCRIPT_NOTICE_COUNT if and only if there is a slow script notification shown.
 Links:
@@ Line 34: / Line 36: @@
 * [PARENT] JS function '''ProcessHangMonitor.reportHang''' accumulates the SLOW_SCRIPT_NOTICE_COUNT histogram (https://dxr.mozilla.org/mozilla-central/source/browser/modules/ProcessHangMonitor.jsm#403)
 * :azhang checked that this is currently the only code path that results in SLOW_SCRIPT_NOTICE_COUNT being incremented.
-Have we tested the metric to make sure it's working properly in e10s?
-* There should be no differences in the slow script '''reporting''' mechanism between e10s and non-e10s; 1 call to ShowSlowScriptDialog means 1 addition to the histogram regardless of e10s setting. Manual testing supports this.
-* The timeout has changed from 2 to 10 in e10s builds (see https://hg.mozilla.org/mozilla-central/rev/63680efe6d55#l35.12 for before and https://hg.mozilla.org/mozilla-central/rev/5002e9c06365#l2.13 for after). However, the value is correct on all beta versions, from 45.0b1 to 45.0b8 - the timeouts are identical between e10s and non-e10s.