10
edits
Electrolysis/Release Criteria/Slow Script: Difference between revisions
Electrolysis/Release Criteria/Slow Script (view source)
Revision as of 23:47, 23 February 2016
, 23 February 2016Add summary and update results.
(More test results.) |
(Add summary and update results.) |
||
| Line 9: | Line 9: | ||
* Consulted: | * Consulted: | ||
* Informed: cpeterson, elan | * Informed: cpeterson, elan | ||
Summary | |||
* It seems that there is indeed a higher number of slow-script notices per session on e10s. | |||
* We've verified that we're measuring the same thing across e10s and non-e10s. | |||
* Does this imply that e10s has more slow-script notifications? Possible confounding factors: | |||
* The dialog on e10s can potentially stop and re-show multiple times (theorized by :jimm). For example, if facebook.com freezes the content process for 12 seconds every minute, non-e10s will block while showing the dialog, while e10s will show the dialog, hide it after 12 seconds, and then reshow it, every minute. | |||
* Slow script notices can occur in multiple tabs at once in e10s. This seems like a rare occurrence, however, so it shouldn't be significant. | |||
Technical details: | Technical details: | ||
| Line 14: | Line 21: | ||
* There should be no differences in the slow script '''reporting''' mechanism between e10s and non-e10s; 1 call to ShowSlowScriptDialog means 1 addition to the histogram regardless of e10s setting. Manual testing supports this. | * There should be no differences in the slow script '''reporting''' mechanism between e10s and non-e10s; 1 call to ShowSlowScriptDialog means 1 addition to the histogram regardless of e10s setting. Manual testing supports this. | ||
* The timeout has changed from 2 to 10 in e10s builds (see https://hg.mozilla.org/mozilla-central/rev/63680efe6d55#l35.12 for before and https://hg.mozilla.org/mozilla-central/rev/5002e9c06365#l2.13 for after). However, the value is correct on all beta versions, from 45.0b1 to 45.0b8 - the timeouts are identical between e10s and non-e10s. | * The timeout has changed from 2 to 10 in e10s builds (see https://hg.mozilla.org/mozilla-central/rev/63680efe6d55#l35.12 for before and https://hg.mozilla.org/mozilla-central/rev/5002e9c06365#l2.13 for after). However, the value is correct on all beta versions, from 45.0b1 to 45.0b8 - the timeouts are identical between e10s and non-e10s. | ||
* :azhang has verified that beta 45 releases with/without e10s both seem to increment SLOW_SCRIPT_NOTICE_COUNT if and only if there is a slow script notification shown. | * :azhang has verified that beta 45 releases with/without e10s both seem to increment SLOW_SCRIPT_NOTICE_COUNT if and only if there is a slow script notification shown, and that they seem to have the exact same timeout in all cases. | ||
Links: | Links: | ||