Confirmed users
1,567
edits
Compatibility/Meetings/2016-06-work-week: Difference between revisions
Jump to navigation
Jump to search
Compatibility/Meetings/2016-06-work-week (view source)
Revision as of 10:37, 16 June 2016
, 16 June 2016→webcompat.com development conventions -- what works and what can be improved: discussion about code conventions
(→🛠 Moving bug stage labels to milestones for webcompat.com: adding status) |
(→webcompat.com development conventions -- what works and what can be improved: discussion about code conventions) |
||
| Line 60: | Line 60: | ||
==== webcompat.com development conventions -- what works and what can be improved ==== | ==== webcompat.com development conventions -- what works and what can be improved ==== | ||
'''Pull Requests Format''' | |||
I would like to write a script which generates changelog. | |||
* pull request number URI | |||
* issue number being fixed | |||
* short description of the change | |||
When miketaylr creates a pull request. The title is "Fix #issue_number. Short description". | |||
Bad example. | |||
* https://github.com/webcompat/webcompat.com/issues/1084 | |||
* https://github.com/webcompat/webcompat.com/pull/1073 | |||
Agreed Format. "Fixes #issue_number Short description" | |||
'''Pull Requests Merging''' | |||
If you are merging a pull request. | |||
* add the addtochangelog label | |||
'''Pull Requests Labels''' | |||
Guillaume will propose a taxonomy of labels. | |||
'''Commit messages''' | |||
"#issue_number short description" | |||
Prefer atomic commits to large commits, there are easier to review and manage. | |||
'''Tests and Pull Requests''' | |||
When submitting a Pull request for python or JavaScript code, run the test before. | |||
==== [DONE] 🛠 Moving bug stage labels to milestones for webcompat.com ==== | ==== [DONE] 🛠 Moving bug stage labels to milestones for webcompat.com ==== | ||