Confirmed users
978
edits
User:Hsinyi/Gecko engineering: Difference between revisions
Jump to navigation
Jump to search
→Patch scope & size: adding link
(→Creating a patch & testing: patch scope & size) |
(→Patch scope & size: adding link) |
||
| Line 100: | Line 100: | ||
It’s arguable if the size of a patch matters much and optimizing for “small changes v.s. big diffs” is hard. But a good principle to keep is: '''seek to understand''' (understand the code, implement the change), and '''seek to be understood''' (present the change in an understandable form). Normally, smaller is better. | It’s arguable if the size of a patch matters much and optimizing for “small changes v.s. big diffs” is hard. But a good principle to keep is: '''seek to understand''' (understand the code, implement the change), and '''seek to be understood''' (present the change in an understandable form). Normally, smaller is better. | ||
An example for arranging patches in sequence to help reviewers: https://bugzilla.mozilla.org/show_bug.cgi?id=1615581 | An example for arranging patches in sequence to [https://phabricator.services.mozilla.com/D63324#1956232 help reviewers]: https://bugzilla.mozilla.org/show_bug.cgi?id=1615581 | ||
Ensure to always stick with *the* real problem you want to fix. Be conscious about '''not''' adding unrelated fixes into that patch, even if they are super tiny. | Ensure to always stick with *the* real problem you want to fix. Be conscious about '''not''' adding unrelated fixes into that patch, even if they are super tiny. | ||