Confirmed users
425
edits
Security/Fusion/Esr140: Difference between revisions
remove non-updating (closed)-annotation on gitlab issue references
(→Uplift Bugs: user_story seems always empty) |
(remove non-updating (closed)-annotation on gitlab issue references) |
||
| Line 19: | Line 19: | ||
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1746668 '''Bug 1746668''']: l10n leak important improvements, see comment 28 with a plan I outlined, we need approval, or to somehow review it and then get started with it | * [https://bugzilla.mozilla.org/show_bug.cgi?id=1746668 '''Bug 1746668''']: l10n leak important improvements, see comment 28 with a plan I outlined, we need approval, or to somehow review it and then get started with it | ||
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1944251 '''Bug 1944251''']: drop ''font.system.whitelist'', make TB consistent with Firefox and improve compatibility ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/43322 #43322 | * [https://bugzilla.mozilla.org/show_bug.cgi?id=1944251 '''Bug 1944251''']: drop ''font.system.whitelist'', make TB consistent with Firefox and improve compatibility ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/43322 #43322]) | ||
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1397996 '''Bug 1397996''']: scrollbar leaks, we want an upstream take on it (tradeoffs with accessibility) ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/22137 #22137]) | * [https://bugzilla.mozilla.org/show_bug.cgi?id=1397996 '''Bug 1397996''']: scrollbar leaks, we want an upstream take on it (tradeoffs with accessibility) ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/22137 #22137]) | ||
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1676104 '''Bug 1676104''']: this is not a P1 only because it should affect UI and/or AC requests (e.g., addons?). Our current patch is ''BB 40171: Make WebRequest and GeckoWebExecutor First-Party aware'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5240a3b51428d50626a385976e7da78d121b8ee4 5240a3b5]); see also [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40171 #40171 | * [https://bugzilla.mozilla.org/show_bug.cgi?id=1676104 '''Bug 1676104''']: this is not a P1 only because it should affect UI and/or AC requests (e.g., addons?). Our current patch is ''BB 40171: Make WebRequest and GeckoWebExecutor First-Party aware'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5240a3b51428d50626a385976e7da78d121b8ee4 5240a3b5]); see also [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40171 #40171] (still open for uplift). | ||
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1869821 '''Bug 1869821''']: ''intl.accept_languages'' is very dangerous. P2 only because Firefox has localized builds rather than multi-lingual like us and because we might want to talk about our patches first (''BB 42084: Ensure English spoofing works even if preferences are set out of order.'' + ''BB 41930: Remove the UI to customize accept_languages.'', [https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2d23c333201787af1ea5fbef2b9cf2426fc0c0e3 2d23c333] and [https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/79f3e7cd3ba260e7a43aba21ce99f2ddf5cda7b9 79f3e7cd]). Good analysis in [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41930 #41930 | * [https://bugzilla.mozilla.org/show_bug.cgi?id=1869821 '''Bug 1869821''']: ''intl.accept_languages'' is very dangerous. P2 only because Firefox has localized builds rather than multi-lingual like us and because we might want to talk about our patches first (''BB 42084: Ensure English spoofing works even if preferences are set out of order.'' + ''BB 41930: Remove the UI to customize accept_languages.'', [https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2d23c333201787af1ea5fbef2b9cf2426fc0c0e3 2d23c333] and [https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/79f3e7cd3ba260e7a43aba21ce99f2ddf5cda7b9 79f3e7cd]). Good analysis in [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41930 #41930]. | ||
* '''''BB 30605: Honor privacy.spoof_english in Android''''' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/160f0b8a68bf41abfa797a51df813743c188bfa0 160f0b8a]), no Bug yet, as far as I know. We'll need some help from upstream because it needs also an additional part for the UI (''TB 40087 [android]: Implement a switch for spoof English.'', [https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/7e749377ceefee0424efb640c84a1fd4c41b6ed6 7e749377], for us), and I think we've never uplifted something user-exposed. | * '''''BB 30605: Honor privacy.spoof_english in Android''''' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/160f0b8a68bf41abfa797a51df813743c188bfa0 160f0b8a]), no Bug yet, as far as I know. We'll need some help from upstream because it needs also an additional part for the UI (''TB 40087 [android]: Implement a switch for spoof English.'', [https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/7e749377ceefee0424efb640c84a1fd4c41b6ed6 7e749377], for us), and I think we've never uplifted something user-exposed. | ||
* '''''BB 42562: Normalized the Accepted Languages on Android.''''' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/299ae962bed521da68c408b2184593a5d02deae1 299ae962]): this goes probably with spoof English. In any case, locale protection is pretty weak on Firefox, especially on Android (even though Android has a lot of other problems) | * '''''BB 42562: Normalized the Accepted Languages on Android.''''' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/299ae962bed521da68c408b2184593a5d02deae1 299ae962]): this goes probably with spoof English. In any case, locale protection is pretty weak on Firefox, especially on Android (even though Android has a lot of other problems) | ||
| Line 36: | Line 36: | ||
==== Build and vendoring ==== | ==== Build and vendoring ==== | ||
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1393901 '''Bug 1393901''']: WebRTC on mingw (various commits, [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41021 #41021 | * [https://bugzilla.mozilla.org/show_bug.cgi?id=1393901 '''Bug 1393901''']: WebRTC on mingw (various commits, [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41021 #41021], [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41459 #41459], [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42758 #42758 (moved)]). Our patches work, at least in ESR 128, but vendoring these 3rd party libs isn't trivial in Firefox, we might need help to prepare the patches as you like. | ||
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1115874 '''Bug 1115874''']: make openh264 reproducible. We have the knowledge to do it, but we need to check how upstream wants to do it ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/15910 #15910]). | * [https://bugzilla.mozilla.org/show_bug.cgi?id=1115874 '''Bug 1115874''']: make openh264 reproducible. We have the knowledge to do it, but we need to check how upstream wants to do it ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/15910 #15910]). | ||
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1902067 '''Bug 1902067''']: official support for the gnullvm Rust target. We've been using it for almost a year now, with success ([https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/29320 tor-browser-build#29320 | * [https://bugzilla.mozilla.org/show_bug.cgi?id=1902067 '''Bug 1902067''']: official support for the gnullvm Rust target. We've been using it for almost a year now, with success ([https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/29320 tor-browser-build#29320]) | ||
=== P3 === | === P3 === | ||
| Line 70: | Line 70: | ||
* ''BB 33955: When copying an image only copy the image contents to the clipboard'', maybe with a pref? | * ''BB 33955: When copying an image only copy the image contents to the clipboard'', maybe with a pref? | ||
* ''BB 41791: Omit the source URL when copying page contents to the clipboard'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/33fc8474a22c13b222f010cdbae00f613b4c22e6 33fc8474]) with ''MOZ_PROXY_BYPASS_PROTECTION''? | * ''BB 41791: Omit the source URL when copying page contents to the clipboard'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/33fc8474a22c13b222f010cdbae00f613b4c22e6 33fc8474]) with ''MOZ_PROXY_BYPASS_PROTECTION''? | ||
* ''Customize moz-toggle for tor-browser.'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d999affc921dedaf0304603331e2cc95fbbe68e0 d999affc], [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41333 #41333 | * ''Customize moz-toggle for tor-browser.'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d999affc921dedaf0304603331e2cc95fbbe68e0 d999affc], [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41333 #41333], [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40837 #40837]) | ||
** Some Bugs might already exist, but I don't know. | ** Some Bugs might already exist, but I don't know. | ||
* ''TB 41822: Unconditionally disable default browser UX in about:preferences'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/05ac42bf7af5b5bcb4a18f64d5001b20d1903973 05ac42bf]) behind a pref? | * ''TB 41822: Unconditionally disable default browser UX in about:preferences'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/05ac42bf7af5b5bcb4a18f64d5001b20d1903973 05ac42bf]) behind a pref? | ||
| Line 83: | Line 83: | ||
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1895857 Bug 1895857] to drop BB 43072, [https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4e8ccc775a923f2f19e2d7a0ea728fb8e965a7a0 4e8ccc77] | * [https://bugzilla.mozilla.org/show_bug.cgi?id=1895857 Bug 1895857] to drop BB 43072, [https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4e8ccc775a923f2f19e2d7a0ea728fb8e965a7a0 4e8ccc77] | ||
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1790187 Bug 1790187] to drop BB 41483, [https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2e8f8a65fd7edbcdd4fafca1c0e9c7f9dcf50a9b 2e8f8a65] | * [https://bugzilla.mozilla.org/show_bug.cgi?id=1790187 Bug 1790187] to drop BB 41483, [https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2e8f8a65fd7edbcdd4fafca1c0e9c7f9dcf50a9b 2e8f8a65] | ||
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1940296 Bug 1940296] so that our pref becomes a defense-in-depth ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/43236 #43236 | * [https://bugzilla.mozilla.org/show_bug.cgi?id=1940296 Bug 1940296] so that our pref becomes a defense-in-depth ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/43236 #43236]) | ||
* [https://bugzilla.mozilla.org/show_bug.cgi?id=1261591 Bug 1261591] as an official way to disable NTLM at build time (and replace ''BB 12974: Disable NTLM and Negotiate HTTP Auth'', [https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/cef5b636f03cdc785ca6905214879599b69fd3bc cef5b636]; close [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/27602 #27602]) | * [https://bugzilla.mozilla.org/show_bug.cgi?id=1261591 Bug 1261591] as an official way to disable NTLM at build time (and replace ''BB 12974: Disable NTLM and Negotiate HTTP Auth'', [https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/cef5b636f03cdc785ca6905214879599b69fd3bc cef5b636]; close [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/27602 #27602]) | ||
* Reconsider the ''LoadLibrary'' protection disabled in [https://bugzilla.mozilla.org/show_bug.cgi?id=1869397 Bug 1869397] | * Reconsider the ''LoadLibrary'' protection disabled in [https://bugzilla.mozilla.org/show_bug.cgi?id=1869397 Bug 1869397] | ||
| Line 99: | Line 99: | ||
* ''BB 16285: Exclude ClearKey system for now'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/cdcd7ee6d6ea3f2fa8a4bd77963af256afde3974 cdcd7ee6]): can we make ''--disable-eme'' remove clearkey again? It was changed in [https://bugzilla.mozilla.org/show_bug.cgi?id=1300654 Bug 1300654] | * ''BB 16285: Exclude ClearKey system for now'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/cdcd7ee6d6ea3f2fa8a4bd77963af256afde3974 cdcd7ee6]): can we make ''--disable-eme'' remove clearkey again? It was changed in [https://bugzilla.mozilla.org/show_bug.cgi?id=1300654 Bug 1300654] | ||
* Some compile-time flag to disable the Windows PB proxy exe (also part of ''Tweaks to the build system'', [https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f4c94fc48c9b5e234efbd38b883f86858814e8b6 f4c94fc4]) | * Some compile-time flag to disable the Windows PB proxy exe (also part of ''Tweaks to the build system'', [https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f4c94fc48c9b5e234efbd38b883f86858814e8b6 f4c94fc4]) | ||
* ''BB 40283: Workaround for the file upload bug'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/76ca7566c1690e640c263b7a7888ce28ef610304 76ca7566]): I think it's still needed, but it also depends on some preference we set? See the original analysis in [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40283 #40283 | * ''BB 40283: Workaround for the file upload bug'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/76ca7566c1690e640c263b7a7888ce28ef610304 76ca7566]): I think it's still needed, but it also depends on some preference we set? See the original analysis in [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40283 #40283]. | ||
* An "official" way to disable ''RemoteSettings'' (currently we have ''BB 31740: Remove some unnecessary RemoteSettings instances'', [https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b5d5a565824437890549527d48f9e1f305b82cac b5d5a565]) | * An "official" way to disable ''RemoteSettings'' (currently we have ''BB 31740: Remove some unnecessary RemoteSettings instances'', [https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b5d5a565824437890549527d48f9e1f305b82cac b5d5a565]) | ||
* ''BB 43386: Use Firefox in the UA in RFP-exempt request.'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/626d276ed28fd10acdb875dec94d1cecae615b1a 626d276e]): would other forks benefit from a way to force compatibility mode without the actual product name? | * ''BB 43386: Use Firefox in the UA in RFP-exempt request.'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/626d276ed28fd10acdb875dec94d1cecae615b1a 626d276e]): would other forks benefit from a way to force compatibility mode without the actual product name? | ||
| Line 116: | Line 116: | ||
* ''BB 26345: Hide tracking protection UI'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/dcc729b19c4c8973a4b54b0d28f4bdf4bbaa4cc8 dcc729b1]): we don't use ETP because we've never audited/compared it with our threat model, maybe something to discuss at a certain point ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/30939 #30939]) | * ''BB 26345: Hide tracking protection UI'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/dcc729b19c4c8973a4b54b0d28f4bdf4bbaa4cc8 dcc729b1]): we don't use ETP because we've never audited/compared it with our threat model, maybe something to discuss at a certain point ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/30939 #30939]) | ||
* ''TB 12647: Support symlinks in the updater.'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/451f22691cfd9cfda6e8d878868eec9aaea73f58 451f2269]): we have an issue about removing it ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/34319 #34319]) | * ''TB 12647: Support symlinks in the updater.'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/451f22691cfd9cfda6e8d878868eec9aaea73f58 451f2269]): we have an issue about removing it ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/34319 #34319]) | ||
* ''TB 40073: Disable remote Public Suffix List fetching'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/84e9763d5a1ea6e0428fe51e1208e9d4eab8e060 84e9763d]): will not be needed anymore once we implement changes described in [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41831 #41831 | * ''TB 40073: Disable remote Public Suffix List fetching'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/84e9763d5a1ea6e0428fe51e1208e9d4eab8e060 84e9763d]): will not be needed anymore once we implement changes described in [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41831 #41831] and [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41022 #41022] for onion aliases | ||
* ''TB 21952: Implement Onion-Location'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/23edd89d8188fd3da424a4cfb0f31a58666e38e0 23edd89d]): needs complete refactor, in the past we talked also with Brave (related issues: [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40100 #40100], [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42688 #42688], [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42736 #42736] | * ''TB 21952: Implement Onion-Location'' ([https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/23edd89d8188fd3da424a4cfb0f31a58666e38e0 23edd89d]): needs complete refactor, in the past we talked also with Brave (related issues: [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40100 #40100], [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42688 #42688], [https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42736 #42736] | ||
* New identity&Firefox's "fire" button: should we start a conversation to incrementally move our new identity in this new upstream functionality? I don't know if there's a specific Bug for that. | * New identity&Firefox's "fire" button: should we start a conversation to incrementally move our new identity in this new upstream functionality? I don't know if there's a specific Bug for that. | ||