Firefox/Projects/TabCandy/Work: Difference between revisions

Firefox/Projects/TabCandy/Work (view source)

Revision as of 23:52, 2 February 2011

135 bytes added , 2 February 2011

→‎Landing

Khanes

9

edits

@@ Line 128: / Line 128: @@
 # Attach your patch to the bug and assign it for feedback from one of the Panorama team (mitcho, raymondlee, seandunn)
 # Once you've got f+, mark it r? for review (generally to iangilman, but other potentials include dao, dietrich, dolske, gavin; ask in #tabcandy if you're not sure who to assign it to)
-# Once they've given you an r+, you'll need approval (unless it's already marked as a blocker, which means it's already approved for landing, or if it's a test fix):
-## Mark it with a question mark under "approval 2.0", if the reviewer hasn't already done so
-## If it's a rush, poke someone to do the approval 2.0 (beltzner, johnath, dietrich, gavin, dolske are good candidates, or ask in #tabcandy if unsure who)
 # Push your patch to tryserver to make sure it doesn't break anything:
 ## Update your m-c local repo
@@ Line 136: / Line 133: @@
 ## hg push -f ssh://hg.mozilla.org/try
 ## Check the results at: http://tests.themasta.com/tinderboxpushlog/?tree=MozillaTry
+## Add a comment to the bug in question with a link to your try run like so: http://tbpl.mozilla.org/?tree=MozillaTry&rev=9a8979f8ef4b
+# Once they've given you an r+, you'll need approval (unless it's already marked as a blocker, which means it's already approved for landing, or if it's a test fix):
+## Mark it with a question mark under "approval 2.0", if the reviewer hasn't already done so
+## If it's a rush, poke someone to do the approval 2.0 (beltzner, johnath, dietrich, gavin, dolske are good candidates, or ask in #tabcandy if unsure who)
 # Once you've got your approval, make a fresh patch with the commit message giving the bug number and title (if you haven't already done that), and updated with "r=foo a=bar"
 # Mark the bug for checkin, by adding the keyword "checkin-needed" to it.