Confirmed users
591
edits
No edit summary |
No edit summary |
||
| Line 7: | Line 7: | ||
* some values depends on the OS theme. Use template (?) values for (<tt>-moz-dialog</tt> or <tt>@toolbarbuttonCornerRadius@</tt>) (FIXME Is there a list somewhere?); | * some values depends on the OS theme. Use template (?) values for (<tt>-moz-dialog</tt> or <tt>@toolbarbuttonCornerRadius@</tt>) (FIXME Is there a list somewhere?); | ||
* Avoid magic numbers, privilege automatic sizing; | * Avoid magic numbers, privilege automatic sizing; | ||
* In a selector: <tt>s/[checked="true"]/[checked]</tt> | * In a selector: <tt>s/[checked="true"]/[checked]</tt>; | ||
* Don't use shorthands to overwrite a property; | |||
* Make sure you know why you use <tt>!important</tt> (add a comment if not obvious); | |||
* Always add a space before !important; | |||
Don't use shorthands to overwrite a property | * Use <tt>:empty</tt> to match a node that doesn't have children; | ||
* Make sure your code is present for the 3 platforms, and that files are referenced twice in the Windows' jar.mn; | |||
Make sure you know why you use !important (add a | * Instead of using <tt>margin:0</tt>, Add the <tt>plain</tt> to the node; | ||
* new line after <tt>;</tt>; | |||
* add a space after each comma, '''except''' within color functions: <tt>-moz-linear-gradient(top, black 1px, rgba(255,255,255,0.2) 1px)</tt>; | |||
* Descendent selector should be avoided; | |||
* Functional stuff should be in content; | |||
> | |||
> | |||
Instead of | |||
> | |||
new line after ; | |||
-moz-linear-gradient(top, black 1px, rgba(255,255,255,0.2) 1px) | |||
> | |||
Functional stuff should be in content | |||