Confirmed users
425
edits
Web Testing/Automation/CodeReviewProcess: Difference between revisions
Web Testing/Automation/CodeReviewProcess (view source)
Revision as of 13:49, 26 September 2013
, 26 September 2013→When doing a code review where should you start?
| Line 5: | Line 5: | ||
===When doing a code review where should you start?=== | ===When doing a code review where should you start?=== | ||
* Start by checking that the pull conforms as much as possible to the [[https://wiki.mozilla.org/QA/Execution/Web_Testing/Docs/Automation/StyleGuide StyleGuide]] | * Start by checking that the pull conforms as much as possible to the [[https://wiki.mozilla.org/QA/Execution/Web_Testing/Docs/Automation/StyleGuide StyleGuide]] | ||
* Use a pep8 | * Use a pep8 checker to ensure that the code conforms to pep8 (except for line length) | ||
* Check that the code meets Python best-practices | * Check that the code meets Python best-practices | ||
* Check that the code looks maintainable and easy to read | * Check that the code looks maintainable and easy to read | ||