234
edits
User:Sspitzer/GlobalFrecency: Difference between revisions
Jump to navigation
Jump to search
no edit summary
No edit summary |
No edit summary |
||
| Line 136: | Line 136: | ||
'''todo''' | '''todo''' | ||
x) | |||
what about the other occurrences of hidden <> 1 in nsNavHistory.cpp? see comment #23 about about why that is bogus. use frecency <> 0? | |||
x) | x) | ||
| Line 157: | Line 161: | ||
on clear all data (and bm import or restore? should we do a quick recalc of bookmarks? what if they have a lot of bookmarks? should part of our work on idle be to recalc bookmarks? | on clear all data (and bm import or restore? should we do a quick recalc of bookmarks? what if they have a lot of bookmarks? should part of our work on idle be to recalc bookmarks? | ||
x) | x) | ||
| Line 169: | Line 170: | ||
in the places organizer and history sidebar ui, visit count is lazily corrected (except for place: and for unvisited children of livemarks, because we use visit count in our query. | in the places organizer and history sidebar ui, visit count is lazily corrected (except for place: and for unvisited children of livemarks, because we use visit count in our query. | ||
note, untrusted visit count is used in other places, like the smart bookmarks menu | |||
x) | x) | ||
| Line 219: | Line 222: | ||
verify we check oldVisitCount and frecency = -1 everywhere we should be. | verify we check oldVisitCount and frecency = -1 everywhere we should be. | ||
x) | x) | ||
| Line 228: | Line 229: | ||
covered by another bug, but we need to fix it before landing, otherwise going back and forth between versions will hork the organizer. | covered by another bug, but we need to fix it before landing, otherwise going back and forth between versions will hork the organizer. | ||
x) | x) | ||
| Line 254: | Line 253: | ||
first time, all bogus (need to take the top <x> and recalc), on migration and import from fx 2 | first time, all bogus (need to take the top <x> and recalc), on migration and import from fx 2 | ||
x) | x) | ||