TPE-Layout/2017-02-21

Weekly Announcement

Weekly Sharing

Weekly Status

Astley Chen

DocGroup Labeling - meta bug to track all layout labeling bugs.

• bug 1339343 - Label runnables in layout modules.

Media Playback

• bug 1339990 - Videos on napolitoday.it are cut off
  • Can't reproduce and possibly a video decoding issue instead of in rendering.

Regression bugs

• bug 1337944 - Buttons with display: table-cell wrap unexpectedly when Inspector is opened

Reftest bugs

• bug 1337766 - determine why some reftest manifest conditions have an order of operations

Boris Chiou

stylo animations

• bug 1338087 - stylo: Stop storing StyleAnimationValue
  • land
• bug 1339704 - stylo: The property value with !important level doesn't override that with animation level
  • file
• bug 1340445 - stylo: use DOM slots for EffectSet
  • file
• bug 1340506 - stylo: avoid doing composeStyle for overridden animation properties
  • file
• bug 1339704 - stylo: Filter out the CascadeLevel which doesn't need to be styled in GetServoAnimationRule
  • file
• bug 1340961 - stylo: handle missing final keyframe with !important on CSS Animations properly
  • file
• bug 1341195 - stylo: getComputedStyle() doesn't return a valid value while the animation is running on compositor
  • file
• bug 1334036 - stylo: Support off-main-thread animations
  • wip

stylo

• bug 1341003 - stylo: we wait for visited coloring forever in test_animations_omta.html
  • file

Cameron McCormack

Stylo

• bug 1340090 - make nsStyleSheetService notify PresShells directly instead of using the observer service
  • r+ | land
• bug 1337258 - stylo: support ServoStyleSheets in nsIStyleSheetService::loadAndRegisterSheet
  • r+ | land
• #15630 - stylo: Don't leak nsStyleCoord::Calc objects when setting gradients.
  • r+ | land
• bug 1335321 - stylo: Unsafe parallel refcount drop in CachedBorderImageData::PurgeCachedImages
  • r+ | land

Other

• bug 1340186
  • debug, reassign
• bug 1340885 - crash in print preview [@ GetCorrectedParent ][@ nsFrame::DoGetParentStyleContext const ]
  • r+ | land

Stylo reviews

• bug 1338388 - stylo: Bindings for css::URLValue and all remaining nsStyleSVG values
• bug 1339314 - stylo: update glue to set clip-path as a mozilla::StyleShapeSource
• bug 1339341 - stylo: Downgrade several stylo errors to warnings to reduce assertions
• bug 1339394 - Don't serialize transparent colors to "transparent" keyword in various cases
• bug 1337674 - stylo: Land the list of known failures in style system mochitests in-tree and make mochitest-style green
• bug 1340022 - stylo: Implement the "change hints handled for descendants" optimization
• bug 1290218 - stylo: Cache servo stylesheets
• bug 1340339 - stylo: Make more style struct access sites servo-safe

Other reviews

• bug 842114 - "ASSERTION: How did we getting here, then?" with filter
• bug 824300 - "ASSERTION: GetVisualOverflowRect() won't return the pre-effects rect!" with {ib}, CSS filter
• bug 1321488 - [webvtt] Restrict css attributes in ::cue
• bug 1339355 - [webvtt] Remove the strongRTLChars table in vtt.jsm
• bug 1339765 - Replace NS_STYLE_GRID_TRACK_BREADTH_* with enum classes
• bug 1339891 - Presshell flushes should short-circuit immediately if the shell doesn't need that flush type
• bug 1340593

CJ Ku

Farmer Tseng

• bug 1339716-[Mortar] Create a interface for PDF printing
  • r?
• bug 1339735-[Mortar] send PDF file name and printing setting to Chrome process
  • r?
• funeral leave on 2/20, 2/21

Jeremy Chen

CSS hyphens property

• bug 1056516 - presence of explicit soft-hyphen in a word should override automatic hyphenation
  • r?
  • run Talos Tp tests to see if the current implementation regress anything
• bug 1340852 - investigate avoiding passing raw pointers for gfxTextRun::PropertyProvider::Spacing
  • file

CSS text-justify property

• bug 1341018 - Convert NS_STYLE_TEXT_ALIGN_* and NS_STYLE_VERTICAL_ALIGN_* to an enum class
  • file
• bug 1341182 - Investigate using a separate enum to represent legend align="" values
  • file

Shing Lyu

Stylo

• Reviewed overall test plan progress
• Bug 1329919 - Landed tp5 crash fix
• Bug 1337305 - Identified talos g2 crash root cause
• Bug 1337229 - Rebase
• Testsed real website diff testcase from cpterson

Evangelism

• NTU School program coordination
• Student project mentoring

Tingyu Lin

• bug 1326407 - Implement the rendering of basic shape inset() for CSS shape-outside
  • land
• bug 775624 - Refactor nsReflowStatus
  • r?
• bug 1339797 - Using "Select all" option in Text selection menu in a text box dismisses the menu
  • land
• bug 1326409 - Implement the rendering of basic shape polygon() for CSS shape-outside
  • OOAD
• bug 1338445 - Long tapping in block element which has only a short word selects odd range on Android
  • land
• bug 1340966 - Add assertion to nsReflowStatus::SetNextInFlowNeedsReflow()
  • file
• bug 1341009 - Eliminate unneeded nsReflowStatus::Reset() calls
  • file

Tommy Kuo

• Prototyping css-rhythm
  • Add `line-height-step` to style system
• bug 1340379 - Remove hardcoded Homebrew URL of autoconf 2.13 for macOS
  • file | land

Rule of Thumb

Status code:

• OOAD: In analysis or design phase.
• WIP: working on WIP patch.
• feedback(f): feedback a patch
• feedback?(f?): WIP is ready for feedback grant.
• feedback+(f+): Get positive feedback.
• feedback-(f-): Get negative feedback.
• review(r): review a patch.
• review?(r?): patch is under review
• review+(r+): get review+ and ready to check-in
• review-(r-): get negative review feedback. Fix problems and switch back to r? again.
• land: patch check in.
• debug: Figure out the root cause of a bug/ try to repro that bug, etc...
• file: file a bug
• PTO: take personal leave
• interview(I)
• study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
• presentation
  • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
  • WIKI/ MDN article writing.
  • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
  • Do a presentation of technical topics