Electrolysis/Meetings/2016-02-18: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
(Add first bits)
 
(→‎mconley: Add mconley stuff.)
Line 7: Line 7:


== mconley ==
== mconley ==
* TBD
* '''M9''' {{bug|1246115}} - "This isn't a web forgery…" never appear for webpages detected as forgery
** Fixed, waiting on uplift approval.
* '''M9''' {{bug|1246291}} - [e10s] about:preferences#advanced - "Warn me when websites try to redirect or reload the page" doesn't allow redirects
** Found a way forward. Patches up for review.
* '''M9''' {{bug|1248599}} - [e10s] The user is not automatically signed into the Firefox account after resetting the password
** The problem is that about:accounts is run in the parent process, and the localStorage thing they're doing to detect when the session has been opened doesn't work across processes.
** Looking at alternatives now - specifically, looking at seeing how hard it would be to make about:accounts run remotely (I don't think it does much privileged stuff)
* '''Perf P1''' {{bug|1195295}} - content-sessionStore.js sends a sync message to the parent in SyncHandler.init
** This has turned into a pretty epic leak hunt that has nothing really to do with my patch (I think my patch just exposed it more).
** Apparently, nsFrameLoader leaks sometimes which keeps nsInProcessTabChildGlobal alive. See {{bug|1249226}}.
* Bug 1247100 - 5.08% sessionrestore (linux64) regression on push cb036027df84 (Mon Feb 8 2016)
** I've found a potential solution to this, and the pattern I've used (moving things out of frame scripts into common JSM's) might help us gain more ground all around on session restore times.

Revision as of 16:08, 18 February 2016


« previous week | index | next week »

mconley

  • M9 bug 1246115 - "This isn't a web forgery…" never appear for webpages detected as forgery
    • Fixed, waiting on uplift approval.
  • M9 bug 1246291 - [e10s] about:preferences#advanced - "Warn me when websites try to redirect or reload the page" doesn't allow redirects
    • Found a way forward. Patches up for review.
  • M9 bug 1248599 - [e10s] The user is not automatically signed into the Firefox account after resetting the password
    • The problem is that about:accounts is run in the parent process, and the localStorage thing they're doing to detect when the session has been opened doesn't work across processes.
    • Looking at alternatives now - specifically, looking at seeing how hard it would be to make about:accounts run remotely (I don't think it does much privileged stuff)
  • Perf P1 bug 1195295 - content-sessionStore.js sends a sync message to the parent in SyncHandler.init
    • This has turned into a pretty epic leak hunt that has nothing really to do with my patch (I think my patch just exposed it more).
    • Apparently, nsFrameLoader leaks sometimes which keeps nsInProcessTabChildGlobal alive. See bug 1249226.
  • Bug 1247100 - 5.08% sessionrestore (linux64) regression on push cb036027df84 (Mon Feb 8 2016)
    • I've found a potential solution to this, and the pattern I've used (moving things out of frame scripts into common JSM's) might help us gain more ground all around on session restore times.