WebDriver/Meetings/2018-10-15: Difference between revisions
Jump to navigation
Jump to search
(→Status updates: ato updates) |
(→Intermittents update: is_shutting_down improvements) |
||
| (5 intermediate revisions by 2 users not shown) | |||
| Line 2: | Line 2: | ||
* Follow-up on actions | * Follow-up on actions | ||
* Recap from CDP meeting with devtools | |||
* TPAC | |||
* ARM builds disabled | |||
* Intermittents update | * Intermittents update | ||
* Minidumps from geckodriver | |||
== Minutes == | == Minutes == | ||
=== Recap from CDP meeting with devtools === | |||
; ato | |||
: We had a meeting with the devtools last week. | |||
: Nothing practical came out of it, but good to clear the air and keep them appraised of what we intend to do. | |||
: They have the same impression of CDP that we do, that it would be good for Mozilla to implement it. | |||
; whimboo | |||
: Who was there? | |||
; AutomatedTester | |||
: ''[summarises who attended]'' | |||
: Can we have a meaningful discussion at TPAC about CDP? What can CDP do for us? | |||
: I will also have discussions with other vendors regarding this. | |||
; ato | |||
: But they have different reasons for wanting that does not necessarily overlap with what we want out of CDP. | |||
: jgraham ran some grep expressions on the Puppeteer source code and came up with some crude information about what parts of CDP is used: https://docs.google.com/document/d/1YHZ7FAhGhH_VUyxuj4auwOQu4EMKDBi3-RWPbjrjOxs/edit | |||
=== TPAC === | |||
; whimboo | |||
: Should we prepare issues to raise at TPAC? | |||
; ato | |||
: Yes, good thing you mentioned. | |||
: We should add them to https://www.w3.org/wiki/WebDriver/2018-TPAC-F2F to ensure they are addressed. | |||
=== ARM builds disabled === | |||
; ato | |||
: I’ve disabled ARMv7 HF builds to preparation of releasing from TaskCluster and making the geckodriver 1.0 release. | |||
: It’s not that we can’t support them on Travis, but we can’t yet on TaskCluster. | |||
: They are however quite easy to self-provide. | |||
=== Intermittents update === | |||
whimboo updated us on the intermittents of the last two weeks. Highlights are: | |||
* [fixed] Firefox startup hang for ASAN builds on Linux64 (Bug 1487243) | |||
* [fixed] Lots of shutdown hangs caused by VRListenerThreadHolder (Bug 1494490, Bug 1494556) | |||
* [needs fix by kris] (Perma ccov) Assertion failure: m_refCount == 1 or pages_.empty() (Bug 1485985) | |||
==== <code>is_shutting_down</code> ==== | |||
<code>AttributeError: 'Marionette' object has no attribute 'is_shutting_down' if Marionette kills application due to a timeout</code> ([https://bugzilla.mozilla.org/show_bug.cgi?id=1496897 1496897]) | |||
; whimboo | |||
: We didn’t handle this intermittent in the most ideal way. | |||
: What can we do to improve this? | |||
; ato | |||
: I saw your needinfo but I simply didn’t have capacity. | |||
: Was also out two days last week. | |||
: But I believe AutomatedTester wrote a patch for this. | |||
; AutomatedTester | |||
: Yes. | |||
; whimboo | |||
: How can we improve this to ensure we look at it sooner? | |||
; AutomatedTester | |||
: It depends how often it happens. | |||
: I don’t think setting a needinfo is the first thing to do after there’s one or a cases. | |||
: I won’t drop everything to look at a very low intermittent. | |||
: But it was clouded by the fact that there were a lot of different intermittent bugs that it turned out were related. | |||
: It wasn’t until I duped the bugs that I saw a pattern and that this was more serious than it first appeared. | |||
; whimboo | |||
: Part of the problem is that we don’t monitor other test jobs, just Mn. | |||
: We have to trust the sheriffs to alert us when they think something might be a Marionette issue. | |||
=== Minidumps from geckodriver === | |||
; whimboo | |||
: We have to get crash handling for wdspec implemented (geckodriver support first)! Any update? | |||
; ato | |||
: I haven’t looked at it since we last spoke. | |||
: I hope that my window manipulation changes can land this week. | |||
: I will make this my next priority. | |||
== Status updates == | == Status updates == | ||
| Line 22: | Line 99: | ||
** Fixed problems with my Kumascript patch for a sidebar for WebDriver MDN documentation ([https://github.com/mdn/kumascript/pull/775 PR 775]) | ** Fixed problems with my Kumascript patch for a sidebar for WebDriver MDN documentation ([https://github.com/mdn/kumascript/pull/775 PR 775]) | ||
** Added references to new <code>--headless</code> flag in wptrunner to docs ([https://bugzilla.mozilla.org/show_bug.cgi?id=1497961 1497961]) | ** Added references to new <code>--headless</code> flag in wptrunner to docs ([https://bugzilla.mozilla.org/show_bug.cgi?id=1497961 1497961]) | ||
* Henrik | |||
** '''[wdspec] Enabled Wd job on Windows platforms (Bug 1370636)''' | |||
** [geckodriver] Fix broken formatting of table in Support.md (Bug 1496311) | |||
** '''[marionette] _handle_socket_failure should not be called when application is shutting down via quit/restart (Bug 1433873)''' | |||
** [marionette] Started work on WebDriver:ElementSendKeys to use action primitives (Bug 1418995) | |||
** '''[mozprocess] ProcessHandler.poll() returns invalid process status when process quit itself (Bug 1433905)''' | |||
== PTO/travel (🍂) == | == PTO/travel (🍂) == | ||
| Line 28: | Line 111: | ||
** SeleniumConf 17–21 October | ** SeleniumConf 17–21 October | ||
** TPAC 24–28 October | ** TPAC 24–28 October | ||
* Henrik: | |||
** TPAC 23–26 October | |||
Latest revision as of 14:27, 15 October 2018
Agenda
- Follow-up on actions
- Recap from CDP meeting with devtools
- TPAC
- ARM builds disabled
- Intermittents update
- Minidumps from geckodriver
Minutes
Recap from CDP meeting with devtools
- ato
- We had a meeting with the devtools last week.
- Nothing practical came out of it, but good to clear the air and keep them appraised of what we intend to do.
- They have the same impression of CDP that we do, that it would be good for Mozilla to implement it.
- whimboo
- Who was there?
- AutomatedTester
- [summarises who attended]
- Can we have a meaningful discussion at TPAC about CDP? What can CDP do for us?
- I will also have discussions with other vendors regarding this.
- ato
- But they have different reasons for wanting that does not necessarily overlap with what we want out of CDP.
- jgraham ran some grep expressions on the Puppeteer source code and came up with some crude information about what parts of CDP is used: https://docs.google.com/document/d/1YHZ7FAhGhH_VUyxuj4auwOQu4EMKDBi3-RWPbjrjOxs/edit
TPAC
- whimboo
- Should we prepare issues to raise at TPAC?
- ato
- Yes, good thing you mentioned.
- We should add them to https://www.w3.org/wiki/WebDriver/2018-TPAC-F2F to ensure they are addressed.
ARM builds disabled
- ato
- I’ve disabled ARMv7 HF builds to preparation of releasing from TaskCluster and making the geckodriver 1.0 release.
- It’s not that we can’t support them on Travis, but we can’t yet on TaskCluster.
- They are however quite easy to self-provide.
Intermittents update
whimboo updated us on the intermittents of the last two weeks. Highlights are:
- [fixed] Firefox startup hang for ASAN builds on Linux64 (Bug 1487243)
- [fixed] Lots of shutdown hangs caused by VRListenerThreadHolder (Bug 1494490, Bug 1494556)
- [needs fix by kris] (Perma ccov) Assertion failure: m_refCount == 1 or pages_.empty() (Bug 1485985)
is_shutting_down
AttributeError: 'Marionette' object has no attribute 'is_shutting_down' if Marionette kills application due to a timeout (1496897)
- whimboo
- We didn’t handle this intermittent in the most ideal way.
- What can we do to improve this?
- ato
- I saw your needinfo but I simply didn’t have capacity.
- Was also out two days last week.
- But I believe AutomatedTester wrote a patch for this.
- AutomatedTester
- Yes.
- whimboo
- How can we improve this to ensure we look at it sooner?
- AutomatedTester
- It depends how often it happens.
- I don’t think setting a needinfo is the first thing to do after there’s one or a cases.
- I won’t drop everything to look at a very low intermittent.
- But it was clouded by the fact that there were a lot of different intermittent bugs that it turned out were related.
- It wasn’t until I duped the bugs that I saw a pattern and that this was more serious than it first appeared.
- whimboo
- Part of the problem is that we don’t monitor other test jobs, just Mn.
- We have to trust the sheriffs to alert us when they think something might be a Marionette issue.
Minidumps from geckodriver
- whimboo
- We have to get crash handling for wdspec implemented (geckodriver support first)! Any update?
- ato
- I haven’t looked at it since we last spoke.
- I hope that my window manipulation changes can land this week.
- I will make this my next priority.
Status updates
(Spoken status updates in bold.)
- ato
- Continued work on redrafting the changes for making window manipulation more reliable (1492499)
- Now up for review, but due to the amount of changes between the first draft and this, I had to re-upload everything. This caused some confusion for Phabricator.
- Worked a lot on WebDriver MDN documentation
- Disabled ARMv7 HF builds ([https://bugzilla.mozilla.org/show_bug.cgi?id=1496987 14969879)
- Attended meeting about CDP with devtools
- Fixed a bug with the in-view centre point definition in the WebDriver spec (PR 1315)
- Fixed a bug with shifted characters, also in the WebDriver spec (PR 1316)
- Fixed a logic mistake in the definition of the WebDriver clear algorithm (PR 1317)
- Added link to Perl API docs in the geckodriver README (1497882)
- Fixed problems with my Kumascript patch for a sidebar for WebDriver MDN documentation (PR 775)
- Added references to new
--headlessflag in wptrunner to docs (1497961)
- Continued work on redrafting the changes for making window manipulation more reliable (1492499)
- Henrik
- [wdspec] Enabled Wd job on Windows platforms (Bug 1370636)
- [geckodriver] Fix broken formatting of table in Support.md (Bug 1496311)
- [marionette] _handle_socket_failure should not be called when application is shutting down via quit/restart (Bug 1433873)
- [marionette] Started work on WebDriver:ElementSendKeys to use action primitives (Bug 1418995)
- [mozprocess] ProcessHandler.poll() returns invalid process status when process quit itself (Bug 1433905)
PTO/travel (🍂)
- ato travelling:
- SeleniumConf 17–21 October
- TPAC 24–28 October
- Henrik:
- TPAC 23–26 October