47
edits
WebExtensions/Contribution Onramp: Difference between revisions
WebExtensions/Contribution Onramp (view source)
Revision as of 10:33, 14 December 2019
, 14 December 2019checkin-needed keyword on BMO -> check-in needed tag on Phab
Caitmuenster (talk | contribs) (→General Tips: changed info about how bugs are assigned) |
(checkin-needed keyword on BMO -> check-in needed tag on Phab) |
||
| Line 87: | Line 87: | ||
* If you need to make a change to a patch that has already been submitted to Phabricator, make sure you update the existing revision so the reviewers can check the interdiff and history of changes. | * If you need to make a change to a patch that has already been submitted to Phabricator, make sure you update the existing revision so the reviewers can check the interdiff and history of changes. | ||
* When working on unrelated changes at the same time, it is useful to work on them into separate hg bookmarks (or entire separate mozilla-central clones if you are not yet feeling confident enough with how the hg bookmarks works) | * When working on unrelated changes at the same time, it is useful to work on them into separate hg bookmarks (or entire separate mozilla-central clones if you are not yet feeling confident enough with how the hg bookmarks works) | ||
* When the patch is approved, add the | * When the patch is approved, edit your Phabricator revision and add the “Check-in needed” tag. | ||
* QA will verify your patch after it lands, unless your mentor has added a “qa-not-needed” keyword. | * QA will verify your patch after it lands, unless your mentor has added a “qa-not-needed” keyword. | ||
* Once your patch is accepted, you can expect to see your code in an upcoming version of Firefox! | * Once your patch is accepted, you can expect to see your code in an upcoming version of Firefox! | ||