Services/Process/Code Review: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
(Created page with ''''Code Review Policy for Weave''' Code review prior to landing is now required for _all_ changes to all production-oriented Weave code. This includes the Weave Sync client c…')
 
 
(18 intermediate revisions by 4 users not shown)
Line 1: Line 1:
'''Code Review Policy for Weave'''
'''Code Review Policy for Mozilla Services Code'''


Code review prior to landing is now required for _all_ changes to all  production-oriented Weave code.  This includes the Weave Sync client code, the Sync server code, and the user registration code. Future  parts of the Weave client will fall under this policy once they move  past the experimental phase.
Code review prior to landing is now required for _all_ changes to all  production-oriented Mozilla Services code.  This includes the Firefox Sync client code, the various pieces of server code, and anything else living in [http://hg.mozilla.org/services http://hg.mozilla.org/services].


=== Reviewers ===
All changes must have at least one review, and all large changes (significant refactorings, new features, new codebases) must have at least two reviews from qualified reviewers.  Where it is unclear, the first reviewer should determine that a second review would be appropriate.


{| cellpadding="5"
== Code Areas ==
|-
|[http://hg.mozilla.org/labs/weave/ Sync Client]
|[mailto:edilee@mozilla.com Ed Lee], [mailto:mconnor@mozilla.com Mike Connor]
|-
|[http://hg.mozilla.org/labs/weaveserver-sync/ Sync Server]
|[mailto:telliott@mozilla.com Toby Elliott], [mailto:lmorchard@mozilla.com Les Orchard], [mailto:mhanson@mozilla.com Mike Hanson]
|-
|[http://hg.mozilla.org/labs/weaveserver-registration/ User Registration Server]
|[mailto:telliott@mozilla.com Toby Elliott], [mailto:lmorchard@mozilla.com Les Orchard], [mailto:mhanson@mozilla.com Mike Hanson]
|}


=== System-review ===
=== Firefox Sync ===


System-review  (similar to super-review in core Mozilla code) is designed to ensure  the overall coherence and stability of the Weave ecosystem. Changes to  any Weave code covered under this policy that impacts APIs, scalability,  or client performance must receive system-review, in addition to  primary review.  This review will generally not cover the details of the  code, but will focus on the overall system performance aspects of the  patches.
'''Repositories'''
* [http://hg.mozilla.org/services/services-central/ services-central]
* [http://hg.mozilla.org/services/fx-sync/ fx-sync (now defunct)]


Mike Hanson (mhanson@mozilla.com) is the only current system-reviewer
'''Reviewers'''
* [mailto:rnewman@mozilla.com Richard Newman]
* [mailto:gps@mozilla.com Greg Szorc]
* [mailto:mconnor@mozilla.com Mike Connor]
* [mailto:philipp@weitershausen.de Philipp von Weitershausen]
 
=== Android Sync ===
 
No formal code review policy yet. :rnewman owns this one.
 
=== Firefox Share (f.k.a. F1) ===
 
'''Repositories'''
* [https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/ fx-share]
 
'''Reviewers'''
* [mailto:philipp@weitershausen.de Philipp von Weitershausen]
* [mailto:mixedpuppy@gmail.com Shane Caraveo]
 
=== Identity client ===
 
'''Repositories'''
* [http://hg.mozilla.org/services/server-identity/ Identity-Server]/static
 
'''Reviewers'''
* [mailto:rnewman@mozilla.com Richard Newman] :rnewman
* [mailto:jrconlin@mozilla.com JR Conlin] :jconlin
 
=== Server Code (PHP) ===
 
'''Repositories'''
* [http://hg.mozilla.org/services/sync-server/ Sync Server]
* [http://hg.mozilla.org/services/reg-server/ Registration Server]
* [http://hg.mozilla.org/services/reg-server-secure/ Registration Server (Secure)]
 
'''Reviewers'''
* [mailto:telliott@mozilla.com Toby Elliott]
* [mailto:tarek@mozilla.com Tarek Ziade]
* [mailto:jconlin@mozilla.com JR Conlin]
* [mailto:mconnor@mozilla.com Mike Connor]
 
=== Sync/Reg Server Code (Python) ===
 
'''Repositories'''
* [http://hg.mozilla.org/services/server-core/ Core Functions (Shared)]
* [http://hg.mozilla.org/services/server-reg/ Registration Code]
* [http://hg.mozilla.org/services/server-storage/ Storage API Code]
* [http://hg.mozilla.org/services/server-full/ Full Server] ''server-full is a meta-package that pulls in all components needed for a standalone server''
 
'''Reviewers'''
* [mailto:tarek@mozilla.com Tarek Ziade]
* [mailto:telliott@mozilla.com Toby Elliott]
* [mailto:jconlin@mozilla.com JR Conlin]
* [mailto:ianb@mozilla.com Ian Bicking]
 
=== Key Exchange Server (Python) ===
 
'''Repositories'''
* [http://hg.mozilla.org/services/server-key-exchange/ Key Exchange]
 
'''Reviewers'''
* [mailto:tarek@mozilla.com Tarek Ziade]
* [mailto:telliott@mozilla.com Toby Elliott]
* [mailto:jconlin@mozilla.com JR Conlin]
* [mailto:ianb@mozilla.com Ian Bicking]
 
=== Identity server ===
 
'''Repositories'''
* [http://hg.mozilla.org/services/server-identity/ Identity Server]
 
'''Reviewers'''
* [mailto:jrconlin@mozilla.com JR Conlin] :jconlin
* [mailto:telliott@mozilla.com Toby Elliott] :telliot
* [mailto:tarek@mozilla.com Tarek Ziade] :tarek

Latest revision as of 22:19, 6 March 2012

Code Review Policy for Mozilla Services Code

Code review prior to landing is now required for _all_ changes to all production-oriented Mozilla Services code. This includes the Firefox Sync client code, the various pieces of server code, and anything else living in http://hg.mozilla.org/services.

All changes must have at least one review, and all large changes (significant refactorings, new features, new codebases) must have at least two reviews from qualified reviewers. Where it is unclear, the first reviewer should determine that a second review would be appropriate.

Code Areas

Firefox Sync

Repositories

Reviewers

Android Sync

No formal code review policy yet. :rnewman owns this one.

Firefox Share (f.k.a. F1)

Repositories

Reviewers

Identity client

Repositories

Reviewers

Server Code (PHP)

Repositories

Reviewers

Sync/Reg Server Code (Python)

Repositories

Reviewers

Key Exchange Server (Python)

Repositories

Reviewers

Identity server

Repositories

Reviewers

Retrieved from "https://wiki.mozilla.org/index.php?title=Services/Process/Code_Review&oldid=404777"