Services/Process/Code Review: Difference between revisions

Latest revision as of 22:19, 6 March 2012

Code Review Policy for Mozilla Services Code

Code review prior to landing is now required for _all_ changes to all production-oriented Mozilla Services code. This includes the Firefox Sync client code, the various pieces of server code, and anything else living in http://hg.mozilla.org/services.

All changes must have at least one review, and all large changes (significant refactorings, new features, new codebases) must have at least two reviews from qualified reviewers. Where it is unclear, the first reviewer should determine that a second review would be appropriate.

Code Areas

Firefox Sync

Repositories

Reviewers

Android Sync

No formal code review policy yet. :rnewman owns this one.

Firefox Share (f.k.a. F1)

Repositories

fx-share

Reviewers

Identity client

Repositories

Identity-Server/static

Reviewers

Richard Newman :rnewman
JR Conlin :jconlin

Server Code (PHP)

Repositories

Reviewers

Sync/Reg Server Code (Python)

Repositories

Core Functions (Shared)
Registration Code
Storage API Code
Full Server server-full is a meta-package that pulls in all components needed for a standalone server

Reviewers

Key Exchange Server (Python)

Repositories

Key Exchange

Reviewers

Identity server

Repositories

Identity Server

Reviewers

JR Conlin :jconlin
Toby Elliott :telliot
Tarek Ziade :tarek

@@ Line 1: / Line 1: @@
 '''Code Review Policy for Mozilla Services Code'''
-Code review prior to landing is now required for _all_ changes to all  production-oriented Mozilla Services code.  This includes the Firefox Sync client  code, the various pieces of server code, and anything else living in [http://hg.mozilla.org/services http://hg.mozilla.org/services].
+Code review prior to landing is now required for _all_ changes to all  production-oriented Mozilla Services code.  This includes the Firefox Sync client code, the various pieces of server code, and anything else living in [http://hg.mozilla.org/services http://hg.mozilla.org/services].
+All changes must have at least one review, and all large changes (significant refactorings, new features, new codebases) must have at least two reviews from qualified reviewers.  Where it is unclear, the first reviewer should determine that a second review would be appropriate.
 == Code Areas ==
-=== Firefox Sync (add-on and library code) ===
+=== Firefox Sync ===
+'''Repositories'''
+* [http://hg.mozilla.org/services/services-central/ services-central]
+* [http://hg.mozilla.org/services/fx-sync/ fx-sync (now defunct)]
+'''Reviewers'''
+* [mailto:rnewman@mozilla.com Richard Newman]
+* [mailto:gps@mozilla.com Greg Szorc]
+* [mailto:mconnor@mozilla.com Mike Connor]
+* [mailto:philipp@weitershausen.de Philipp von Weitershausen]
+=== Android Sync ===
+No formal code review policy yet. :rnewman owns this one.
+=== Firefox Share (f.k.a. F1) ===
 '''Repositories'''
-[http://hg.mozilla.org/services/fx-sync/ Sync Client]
+* [https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/ fx-share]
 '''Reviewers'''
 * [mailto:philipp@weitershausen.de Philipp von Weitershausen]
-* [mailto:mconnor@mozilla.com Mike Connor]
+* [mailto:mixedpuppy@gmail.com Shane Caraveo]
-* [mailto:edilee@mozilla.com Ed Lee]
+=== Identity client ===
+'''Repositories'''
+* [http://hg.mozilla.org/services/server-identity/ Identity-Server]/static
+'''Reviewers'''
+* [mailto:rnewman@mozilla.com Richard Newman] :rnewman
+* [mailto:jrconlin@mozilla.com JR Conlin] :jconlin
 === Server Code (PHP) ===
@@ Line 25: / Line 51: @@
 * [mailto:telliott@mozilla.com Toby Elliott]
 * [mailto:tarek@mozilla.com Tarek Ziade]
+* [mailto:jconlin@mozilla.com JR Conlin]
 * [mailto:mconnor@mozilla.com Mike Connor]
-=== Primary Server Code (Python) ===
+=== Sync/Reg Server Code (Python) ===
 '''Repositories'''
@@ Line 38: / Line 65: @@
 * [mailto:tarek@mozilla.com Tarek Ziade]
 * [mailto:telliott@mozilla.com Toby Elliott]
+* [mailto:jconlin@mozilla.com JR Conlin]
 * [mailto:ianb@mozilla.com Ian Bicking]
 === Key Exchange Server (Python) ===
@@ Line 48: / Line 75: @@
 '''Reviewers'''
 * [mailto:tarek@mozilla.com Tarek Ziade]
+* [mailto:telliott@mozilla.com Toby Elliott]
+* [mailto:jconlin@mozilla.com JR Conlin]
 * [mailto:ianb@mozilla.com Ian Bicking]
-= System-review =
+=== Identity server ===
-System-review  (similar to super-review in core Mozilla code) is designed to ensure  the overall coherence and stability of the Weave ecosystem.  Changes to  any Weave code covered under this policy that impacts APIs, scalability,  or client performance may require system-review, in addition to  primary review.  This review will generally not cover the details of the  code, but will focus on the overall system performance aspects of the  patches.
+'''Repositories'''
+* [http://hg.mozilla.org/services/server-identity/ Identity Server]
-Mike Connor (mconnor@mozilla.com) is  the only current system-reviewer
+'''Reviewers'''
+* [mailto:jrconlin@mozilla.com JR Conlin] :jconlin
+* [mailto:telliott@mozilla.com Toby Elliott] :telliot
+* [mailto:tarek@mozilla.com Tarek Ziade] :tarek

Services/Process/Code Review: Difference between revisions

Latest revision as of 22:19, 6 March 2012

Contents

Code Areas

Firefox Sync

Android Sync

Firefox Share (f.k.a. F1)

Identity client

Server Code (PHP)

Sync/Reg Server Code (Python)

Key Exchange Server (Python)

Identity server

Navigation menu

Services/Process/Code Review: Difference between revisions

Latest revision as of 22:19, 6 March 2012

Code Areas

Firefox Sync

Android Sync

Firefox Share (f.k.a. F1)

Identity client

Server Code (PHP)

Sync/Reg Server Code (Python)

Key Exchange Server (Python)

Identity server

Navigation menu

Search