Services/Process/Code Review: Difference between revisions
| (11 intermediate revisions by 4 users not shown) | |||
| Line 10: | Line 10: | ||
'''Repositories''' | '''Repositories''' | ||
* [http://hg.mozilla.org/services/services-central/ ] | * [http://hg.mozilla.org/services/services-central/ services-central] | ||
* [http://hg.mozilla.org/services/fx-sync/ | * [http://hg.mozilla.org/services/fx-sync/ fx-sync (now defunct)] | ||
'''Reviewers''' | '''Reviewers''' | ||
* [mailto:rnewman@mozilla.com Richard Newman] | * [mailto:rnewman@mozilla.com Richard Newman] | ||
* [mailto:gps@mozilla.com Greg Szorc] | |||
* [mailto:mconnor@mozilla.com Mike Connor] | * [mailto:mconnor@mozilla.com Mike Connor] | ||
* [mailto:philipp@weitershausen.de Philipp von Weitershausen] | |||
=== Android Sync === | |||
No formal code review policy yet. :rnewman owns this one. | |||
=== Firefox Share (f.k.a. F1) === | |||
'''Repositories''' | |||
* [https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/ fx-share] | |||
'''Reviewers''' | |||
* [mailto:philipp@weitershausen.de Philipp von Weitershausen] | |||
* [mailto:mixedpuppy@gmail.com Shane Caraveo] | |||
=== Identity client === | |||
'''Repositories''' | |||
* [http://hg.mozilla.org/services/server-identity/ Identity-Server]/static | |||
'''Reviewers''' | |||
* [mailto:rnewman@mozilla.com Richard Newman] :rnewman | |||
* [mailto:jrconlin@mozilla.com JR Conlin] :jconlin | |||
=== Server Code (PHP) === | === Server Code (PHP) === | ||
| Line 55: | Line 78: | ||
* [mailto:jconlin@mozilla.com JR Conlin] | * [mailto:jconlin@mozilla.com JR Conlin] | ||
* [mailto:ianb@mozilla.com Ian Bicking] | * [mailto:ianb@mozilla.com Ian Bicking] | ||
=== Identity server === | |||
'''Repositories''' | |||
* [http://hg.mozilla.org/services/server-identity/ Identity Server] | |||
'''Reviewers''' | |||
* [mailto:jrconlin@mozilla.com JR Conlin] :jconlin | |||
* [mailto:telliott@mozilla.com Toby Elliott] :telliot | |||
* [mailto:tarek@mozilla.com Tarek Ziade] :tarek | |||
Latest revision as of 22:19, 6 March 2012
Code Review Policy for Mozilla Services Code
Code review prior to landing is now required for _all_ changes to all production-oriented Mozilla Services code. This includes the Firefox Sync client code, the various pieces of server code, and anything else living in http://hg.mozilla.org/services.
All changes must have at least one review, and all large changes (significant refactorings, new features, new codebases) must have at least two reviews from qualified reviewers. Where it is unclear, the first reviewer should determine that a second review would be appropriate.
Code Areas
Firefox Sync
Repositories
Reviewers
Android Sync
No formal code review policy yet. :rnewman owns this one.
Repositories
Reviewers
Identity client
Repositories
- Identity-Server/static
Reviewers
- Richard Newman :rnewman
- JR Conlin :jconlin
Server Code (PHP)
Repositories
Reviewers
Sync/Reg Server Code (Python)
Repositories
- Core Functions (Shared)
- Registration Code
- Storage API Code
- Full Server server-full is a meta-package that pulls in all components needed for a standalone server
Reviewers
Key Exchange Server (Python)
Repositories
Reviewers
Identity server
Repositories
Reviewers
- JR Conlin :jconlin
- Toby Elliott :telliot
- Tarek Ziade :tarek